Denis Vlasenko [Thu, 15 Nov 2007 00:57:40 +0000 (00:57 -0000)]
cosmetic change in message text
Paul Fox [Wed, 14 Nov 2007 23:48:35 +0000 (23:48 -0000)]
bad syntax error should go to stderr
Denis Vlasenko [Wed, 14 Nov 2007 10:18:33 +0000 (10:18 -0000)]
Introduce FEATURE_PREFER_IPV4_ADDRESS. If selected, we have:
function old new delta
str2sockaddr 328 344 +16
Denis Vlasenko [Tue, 13 Nov 2007 22:23:57 +0000 (22:23 -0000)]
tr: more of code shrink (getopt32-ification)
runtest: cleanup. Method of getting $applets was truly bizarre
function old new delta
tr_main 655 527 -128
Denis Vlasenko [Tue, 13 Nov 2007 22:22:29 +0000 (22:22 -0000)]
tr: better comments, small code shrink
function old new delta
expand 2232 2230 -2
tr_main 677 655 -22
Denis Vlasenko [Tue, 13 Nov 2007 17:51:40 +0000 (17:51 -0000)]
tr: properly detect read errors (Fernando Silveira <fsilveira@gmail.com>)
readprofile: use xwrite
function old new delta
tr_main 679 677 -2
readprofile_main 1964 1944 -20
Denis Vlasenko [Tue, 13 Nov 2007 17:36:12 +0000 (17:36 -0000)]
trylink: accomodate older versions of ld
Denis Vlasenko [Tue, 13 Nov 2007 17:26:21 +0000 (17:26 -0000)]
who: code shrink by Tito <farmatito@tiscali.it>
function old new delta
who_main 271 259 -12
Denis Vlasenko [Tue, 13 Nov 2007 17:13:31 +0000 (17:13 -0000)]
add sed mini-doc
Denis Vlasenko [Tue, 13 Nov 2007 16:48:10 +0000 (16:48 -0000)]
sed: support GNU-like '\t' escape in substitutions
Denis Vlasenko [Mon, 12 Nov 2007 21:21:35 +0000 (21:21 -0000)]
inetd: revert bogus fix for bug 1562; shrink inetd a bit
function old new delta
dupconfig 159 146 -13
getconfigent 1123 1073 -50
Denis Vlasenko [Mon, 12 Nov 2007 02:13:12 +0000 (02:13 -0000)]
open_transformer: do not duplicate "<program> -cf -"
text data bss dec hex filename
677858 738 7236 685832 a7708 busybox_old
677804 738 7236 685778 a76d2 busybox_unstripped
Denis Vlasenko [Mon, 12 Nov 2007 01:44:49 +0000 (01:44 -0000)]
gzip: fix a case where tar xzf fails (we use uninitialized fd)
Denis Vlasenko [Sun, 11 Nov 2007 06:35:41 +0000 (06:35 -0000)]
who: fix wrong date/time field size
Denis Vlasenko [Sat, 10 Nov 2007 03:24:21 +0000 (03:24 -0000)]
Announce 1.8.1
Denis Vlasenko [Sat, 10 Nov 2007 01:57:35 +0000 (01:57 -0000)]
init: fix bug 1584: improper check for fork error
Denis Vlasenko [Sat, 10 Nov 2007 01:45:03 +0000 (01:45 -0000)]
umount: stop using excessive aounts of stack. Surprisingly,
code shrank a lot too
function old new delta
umount_main 751 640 -111
Denis Vlasenko [Sat, 10 Nov 2007 01:35:47 +0000 (01:35 -0000)]
lineedit: stop using both data/bss and tons of stack.
stack usage was ~10 kb!
unfortunately, noticeable code size growth:
text data bss dec hex filename
9252 12 181 9445 24e5 busybox.t7/libbb/lineedit.o
9714 4 0 9718 25f6 busybox.t8/libbb/lineedit.o
Denis Vlasenko [Sat, 10 Nov 2007 01:32:18 +0000 (01:32 -0000)]
*: remove superfluous "?" in option parsing
Denis Vlasenko [Sat, 10 Nov 2007 01:31:19 +0000 (01:31 -0000)]
readlink: realpath requires PATH_MAX, bb_common_bufsiz1 can be too small
umount: don't actually need char[2 * PATH_MAX] for realpath
Denis Vlasenko [Sat, 10 Nov 2007 01:28:19 +0000 (01:28 -0000)]
syslogd: support "symlink to symlink" for /dev/log; reduce stack usage
function old new delta
create_socket - 134 +134
syslogd_main 1132 865 -267
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/1 up/down: 134/-267) Total: -133 bytes
text data bss dec hex filename
775603 974 9420 785997 bfe4d busybox_old
775445 974 9420 785839 bfdaf busybox_unstripped
Bernhard Reutner-Fischer [Thu, 8 Nov 2007 21:11:43 +0000 (21:11 -0000)]
- commentary fixes
- use common exit sequence for failure path:
text data bss dec hex filename
308 0 0 308 134 libbb/xreadlink.o.pgf
296 0 0 296 128 libbb/xreadlink.o
Paul Fox [Thu, 8 Nov 2007 20:00:36 +0000 (20:00 -0000)]
xmalloc_follow_symlinks() -- fix ELOOP issue with absolute paths,
return full path in cases where path doesn't resolve to a link.
change name to better differentiate from xmalloc_readlink().
Denis Vlasenko [Thu, 8 Nov 2007 17:40:23 +0000 (17:40 -0000)]
xreadlink: code shrink
udhcp: add missing tryagain member to client_config
function old new delta
xmalloc_readlink_follow 169 154 -15
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-15) Total: -15 bytes
Paul Fox [Thu, 8 Nov 2007 01:12:38 +0000 (01:12 -0000)]
follow symlinks to find the true passwd file before updating.
Paul Fox [Thu, 8 Nov 2007 01:11:41 +0000 (01:11 -0000)]
new xmalloc_readlink_follow() routine to fully expand trailing symlinks
to get to a "real" file (or directory).
Paul Fox [Wed, 7 Nov 2007 16:01:28 +0000 (16:01 -0000)]
add "-A N" / "--tryagain=N" option to client, to allow altering the
default 60 second wait after failure to get a lease.
Paul Fox [Wed, 7 Nov 2007 15:51:35 +0000 (15:51 -0000)]
flush typeahead before prompt
Denis Vlasenko [Wed, 7 Nov 2007 00:23:47 +0000 (00:23 -0000)]
login: fix PAM login (was unable to complete Kerberos login)
Denis Vlasenko [Tue, 6 Nov 2007 11:34:03 +0000 (11:34 -0000)]
modprobe: fix a bug where we were entering endless loop
syslogd: strip trailing '\n' too, not only NULs
Denis Vlasenko [Tue, 6 Nov 2007 05:26:51 +0000 (05:26 -0000)]
login: clear dangerous environment variables if started by non-root
Denis Vlasenko [Tue, 6 Nov 2007 03:05:54 +0000 (03:05 -0000)]
fbset: fix buglet where we were using wrong pointer
readahead: stop using stdio.h
*: style fixes
Denis Vlasenko [Tue, 6 Nov 2007 02:23:39 +0000 (02:23 -0000)]
telnet: use poll, it's shorter
*: style fixes
Denis Vlasenko [Tue, 6 Nov 2007 02:16:01 +0000 (02:16 -0000)]
unzip: hmm... gcc doesn't like ATTRIBUTE_PACKED?? Document that...
Denis Vlasenko [Tue, 6 Nov 2007 02:02:45 +0000 (02:02 -0000)]
insmod: make error reporting less verbose
Denis Vlasenko [Tue, 6 Nov 2007 01:38:46 +0000 (01:38 -0000)]
telnetd: fix problem with zombies (by Paul Fox <pgf@brightstareng.com>)
syslogd: strip trailing NULs
Paul Fox [Mon, 5 Nov 2007 23:09:03 +0000 (23:09 -0000)]
change safety check on zip header to allow for extra length, and
revert the header read to use the correct constant rather than
sizeof. at least one version of gcc (armv4-linux-gcc-3.4.1) pads
the struct to 28 bytes in spite of the packing.
Denis Vlasenko [Mon, 5 Nov 2007 19:33:38 +0000 (19:33 -0000)]
swaponoff: prevent arithmetic overflow (spotted by Paul Fox <pgf@brightstareng.com>)
Denis Vlasenko [Mon, 5 Nov 2007 19:31:01 +0000 (19:31 -0000)]
fix incorrect text of link-time error message. No code changes
Denis Vlasenko [Mon, 5 Nov 2007 16:26:34 +0000 (16:26 -0000)]
webpage: fix typo, remove inconsistent trailing dots
Makefile: version is 1.9.0.svn now
Denis Vlasenko [Sun, 4 Nov 2007 15:57:35 +0000 (15:57 -0000)]
update screenshot
Denis Vlasenko [Sun, 4 Nov 2007 15:43:26 +0000 (15:43 -0000)]
Announce 1.8.0
Denis Vlasenko [Sun, 4 Nov 2007 04:46:46 +0000 (04:46 -0000)]
docs: fix new-applet-HOWTO.txt, delete ipv4_ipv6.txt (it's obsolete)
Denis Vlasenko [Sun, 4 Nov 2007 04:30:20 +0000 (04:30 -0000)]
Announce 1.7.3 on website
Denis Vlasenko [Sun, 4 Nov 2007 04:10:17 +0000 (04:10 -0000)]
ifconfig: code shrink
adjtimex: code shrink
libbb: move nth_string function into libbb
hdparm: nth_string was here
text data bss dec hex filename
730013 10334 12032 752379 b7afb busybox_old
730093 10134 12032 752259 b7a83 busybox_unstripped
Denis Vlasenko [Sun, 4 Nov 2007 00:46:03 +0000 (00:46 -0000)]
grep: fix -Fo
Denis Vlasenko [Fri, 2 Nov 2007 23:31:10 +0000 (23:31 -0000)]
insmod: code shrink, stop exporting insmod_ng_main.
function old new delta
add_ksymoops_symbols - 421 +421
static.section_names 20 40 +20
lsmod_main 425 424 -1
set_tainted 153 150 -3
main_opts 4 - -4
obj_symbol_patch 47 42 -5
obj_string_patch 144 139 -5
already_loaded 144 138 -6
check_dep 348 341 -7
append_option 75 68 -7
obj_allocate_commons 515 501 -14
new_process_module_arguments 1039 1018 -21
arch_new_symbol 31 9 -22
check_module_name_match 85 61 -24
obj_create_alloced_section 164 136 -28
include_conf 930 902 -28
modprobe_main 1643 1535 -108
obj_load 924 777 -147
insmod_ng_main 245 - -245
insmod_main 4122 3794 -328
------------------------------------------------------------------------------
(add/remove: 1/2 grow/shrink: 1/16 up/down: 441/-1003) Total: -562 bytes
text data bss dec hex filename
776020 974 9420 786414 bffee busybox_old
775384 974 9420 785778 bfd72 busybox_unstripped
Denis Vlasenko [Tue, 30 Oct 2007 19:54:39 +0000 (19:54 -0000)]
inetd: fix bug 1562 "inetd does not set argv[0] properly" (fix by IlyaPanfilov)
inetd: code shrink while at it
function old new delta
static.SOCK_xxx - 6 +6
getconfigent 1222 1123 -99
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/1 up/down: 6/-99) Total: -93 bytes
text data bss dec hex filename
776099 974 9420 786493 c003d busybox_old
776020 974 9420 786414 bffee busybox_unstripped
Denis Vlasenko [Tue, 30 Oct 2007 19:36:54 +0000 (19:36 -0000)]
hdparm: code shrink
text data bss dec hex filename
776494 974 9420 786888 c01c8 busybox_old
776099 974 9420 786493 c003d busybox_unstripped
Denis Vlasenko [Tue, 30 Oct 2007 19:36:07 +0000 (19:36 -0000)]
e2fsprogs: code shrink
text data bss dec hex filename
776594 974 9420 786988 c022c busybox_old
776494 974 9420 786888 c01c8 busybox_unstripped
Bernhard Reutner-Fischer [Mon, 29 Oct 2007 21:21:27 +0000 (21:21 -0000)]
- fix typo in helptext
Denis Vlasenko [Mon, 29 Oct 2007 19:52:21 +0000 (19:52 -0000)]
minor fix in comment, no code changes
Denis Vlasenko [Mon, 29 Oct 2007 19:33:26 +0000 (19:33 -0000)]
ll_types.c: optimize link type table, make it conditional
on FEATURE_IP_RARE_PROTOCOLS
function old new delta
static.arphrd_name - 373 +373
static.arphrd_type - 124 +124
ll_type_n2a 58 78 +20
static.arphrd_names 496 - -496
------------------------------------------------------------------------------
(add/remove: 2/1 grow/shrink: 1/0 up/down: 517/-496) Total: 21 bytes
text data bss dec hex filename
776880 974 9420 787274 c034a busybox_old
776594 974 9420 786988 c022c busybox_unstripped
Denis Vlasenko [Mon, 29 Oct 2007 19:25:45 +0000 (19:25 -0000)]
appletlib.c: make it actally follow _BB_SUID_ALWAYS rules
adduser: implement -S and code shrink / fix uid selection
*: sanitize getspnam_r use
text data bss dec hex filename
777042 974 9676 787692 c04ec busybox_old
776883 974 9676 787533 c044d busybox_unstripped
Denis Vlasenko [Mon, 29 Oct 2007 19:22:13 +0000 (19:22 -0000)]
syscall: code shrink
text data bss dec hex filename
777209 974 9676 787859 c0593 busybox_old
777042 974 9676 787692 c04ec busybox_unstripped
Denis Vlasenko [Mon, 29 Oct 2007 19:18:39 +0000 (19:18 -0000)]
mount: size-optimize mount_options[] and nfs_errtbl[]
777253 974 9676 787903 c05bf busybox_old
777209 974 9676 787859 c0593 busybox_unstripped
Denis Vlasenko [Mon, 29 Oct 2007 19:17:29 +0000 (19:17 -0000)]
ash: if tcgetattr(stdin) fails, don't mess with tcsetattr
ash: size-optimize ulimit's table of limits
text data bss dec hex filename
777345 974 9676 787995 c061b busybox_old
777253 974 9676 787903 c05bf busybox_unstripped
Denis Vlasenko [Mon, 22 Oct 2007 15:53:34 +0000 (15:53 -0000)]
svlogd: fix compat problem: svlogd -tt should timestanp stderr too
Denis Vlasenko [Sun, 21 Oct 2007 23:24:42 +0000 (23:24 -0000)]
httpd: fix trivial bug (spotted by Alex Landau)
Denis Vlasenko [Sun, 21 Oct 2007 18:59:58 +0000 (18:59 -0000)]
bzip2: make -d actually work
Denis Vlasenko [Sat, 20 Oct 2007 19:20:22 +0000 (19:20 -0000)]
bb_askpass: handle Ctrl-C, restore termoios on Ctrl-C.
sulogin: remove alarm handling, as it is redundant there.
code shrink. After all differences cancel out:
text data bss dec hex filename
777543 1000 9532 788075 c066b busybox_old
777543 1000 9532 788075 c066b busybox_unstripped
Denis Vlasenko [Sat, 20 Oct 2007 18:30:38 +0000 (18:30 -0000)]
read_line_input: fix it to not do any fancy editing if echoing is disabled.
ash: make read handling both more correct and smaller
read_line_input 4037 4101 +64
input_backward 140 139 -1
readcmd 1079 1070 -9
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/2 up/down: 65/-10) Total: 54 bytes
text data bss dec hex filename
777575 1000 9532 788107 c068b busybox_old
777629 1000 9532 788161 c06c1 busybox_unstripped
Denis Vlasenko [Sat, 20 Oct 2007 14:54:58 +0000 (14:54 -0000)]
more fixes for help text wrt long options
Denis Vlasenko [Sat, 20 Oct 2007 04:44:08 +0000 (04:44 -0000)]
website: add link to "No ifup" document
Denis Vlasenko [Sat, 20 Oct 2007 02:00:49 +0000 (02:00 -0000)]
ping: fix breakage from -I fix
passwd: SELinux support by KaiGai Kohei <kaigai@ak.jp.nec.com>
Denis Vlasenko [Sat, 20 Oct 2007 00:17:34 +0000 (00:17 -0000)]
kbd_mode: new applet by Loïc Grenié <loic.grenie@gmail.com>
kbd_mode_main - 189 +189
packed_usage 22745 22833 +88
applets 3132 3144 +12
static.opts 7 12 +5
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 3/0 up/down: 294/0) Total: 294 bytes
text data bss dec hex filename
777210 1000 9532 787742 c051e busybox_old
777575 1000 9532 788107 c068b busybox_unstripped
Denis Vlasenko [Fri, 19 Oct 2007 21:49:48 +0000 (21:49 -0000)]
mkswap: selinux support by KaiGai Kohei <kaigai@ak.jp.nec.com>
Denis Vlasenko [Fri, 19 Oct 2007 21:39:25 +0000 (21:39 -0000)]
paing: make -I ethN work too (-I addr already worked)
Denis Vlasenko [Fri, 19 Oct 2007 21:03:09 +0000 (21:03 -0000)]
unzip: add a comment explaining why we don't die
Denis Vlasenko [Thu, 18 Oct 2007 23:27:46 +0000 (23:27 -0000)]
unzip: fix endianness bugs
Denis Vlasenko [Thu, 18 Oct 2007 13:01:22 +0000 (13:01 -0000)]
httpd: free big buffer after use; improve grep-ability of 'headers' variable
Denis Vlasenko [Thu, 18 Oct 2007 12:54:39 +0000 (12:54 -0000)]
xatonum.h: add comment
lineedit: fix typo in comment
httpd: support for proxying connection to other http server
(by Alex Landau <landau_alex@yahoo.com>)
Denis Vlasenko [Thu, 18 Oct 2007 11:11:12 +0000 (11:11 -0000)]
more of usage text fixes wrt long options
Denis Vlasenko [Thu, 18 Oct 2007 10:52:36 +0000 (10:52 -0000)]
exclude --longopts from usage texts if those are disabled
Denis Vlasenko [Thu, 18 Oct 2007 10:46:42 +0000 (10:46 -0000)]
snv add setsebool
Denis Vlasenko [Wed, 17 Oct 2007 14:33:31 +0000 (14:33 -0000)]
telnetd: make sure telnetd -K exits if child dies
Denis Vlasenko [Wed, 17 Oct 2007 11:18:49 +0000 (11:18 -0000)]
telnetd: trivial optimization
Denis Vlasenko [Wed, 17 Oct 2007 11:08:53 +0000 (11:08 -0000)]
ash: use fdprintf, not dprintf.
*: trailing whitespace removed
Denis Vlasenko [Wed, 17 Oct 2007 10:14:11 +0000 (10:14 -0000)]
bzip2: more of code shrink
compressStream 503 473 -30
BZ2_bzCompress 78 - -78
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 0/1 up/down: 0/-108) Total: -108 bytes
text data bss dec hex filename
676300 2538 12104 690942 a8afe busybox_old
676192 2538 12104 690834 a8a92 busybox_unstripped
Denis Vlasenko [Wed, 17 Oct 2007 09:59:01 +0000 (09:59 -0000)]
another fix for build failure found by randomconfig
Denis Vlasenko [Tue, 16 Oct 2007 23:00:50 +0000 (23:00 -0000)]
even more fixes from randomconfig runs
Denis Vlasenko [Tue, 16 Oct 2007 22:53:05 +0000 (22:53 -0000)]
fixes revealed by randomconfig run
Denis Vlasenko [Tue, 16 Oct 2007 22:01:23 +0000 (22:01 -0000)]
telnetd: fix comment
Denis Vlasenko [Tue, 16 Oct 2007 21:35:17 +0000 (21:35 -0000)]
telnetd: code shrink suggested by Ralf Friedl <Ralf.Friedl@online.de>
Denis Vlasenko [Tue, 16 Oct 2007 14:07:41 +0000 (14:07 -0000)]
bzip2: move state pointer to the offset 0 (smaller code)
ifdef out DecompressEnd if FEATURE_CLEAN_UP is not seleted
fallbackSort 1655 1672 +17
mainSort 2447 2458 +11
bzip2_main 109 119 +10
.rodata 123466 123469 +3
generateMTFValues 433 435 +2
handle_compress 355 356 +1
BZ2_bzCompress 79 78 -1
prepare_new_block 55 48 -7
compressStream 547 503 -44
sendMTFValues 2225 2140 -85
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 6/4 up/down: 44/-137) Total: -93 bytes
text data bss dec hex filename
676421 2538 12104 691063 a8b77 busybox_old
676328 2538 12104 690970 a8b1a busybox_unstripped
Denis Vlasenko [Tue, 16 Oct 2007 10:47:27 +0000 (10:47 -0000)]
bzip2: make -s equivalent to -2 (compatible with standard bzip2)
telnetd: typo fix in comment
Denis Vlasenko [Mon, 15 Oct 2007 22:09:15 +0000 (22:09 -0000)]
telnetd: at Alexander Kriegisch <Alexander@kriegisch.name> insistence
add an option to close sessions as soon as child exits.
Maybe it should be a CONFIG option. OTOH, maybe it should be always on,
as it mimics, say, getty's behaviour.
function old new delta
handle_sigchld - 49 +49
telnetd_main 1312 1355 +43
.rodata 123429 123466 +37
packed_usage 22770 22806 +36
make_new_session 525 532 +7
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 4/0 up/down: 172/0) Total: 172 bytes
text data bss dec hex filename
676285 2538 12104 690927 a8aef busybox_old
676421 2538 12104 691063 a8b77 busybox_unstripped
Denis Vlasenko [Mon, 15 Oct 2007 17:28:00 +0000 (17:28 -0000)]
telnetd: document bug in remove_iacs. reinstate band-aid
which was making it near-impossible to trigger.
remove memmove call which was happening at each network read,
and in 99%+ cases was not needed. Unfortunately, +50 bytes.
Denis Vlasenko [Mon, 15 Oct 2007 15:19:36 +0000 (15:19 -0000)]
telnetd: some simplifications and better error hadling.
telnetd: don't SIGKILL child when closing the session.
kernel will seng SIGHUP for us.
static.iacs_to_send - 15 +15
.rodata 123418 123429 +11
make_new_session 549 525 -24
send_iac 26 - -26
free_session 144 118 -26
telnetd_main 1303 1261 -42
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 1/3 up/down: 26/-118) Total: -92 bytes
text data bss dec hex filename
676341 2538 12104 690983 a8b27 busybox_old
676234 2538 12104 690876 a8abc busybox_unstripped
Denis Vlasenko [Sun, 14 Oct 2007 07:57:26 +0000 (07:57 -0000)]
bzip2: update help text
Denis Vlasenko [Sun, 14 Oct 2007 07:51:19 +0000 (07:51 -0000)]
bzip2: implement -1..-9 command line flags
Denis Vlasenko [Sun, 14 Oct 2007 07:49:48 +0000 (07:49 -0000)]
bzip2: eliminate some divisions
Denis Vlasenko [Sun, 14 Oct 2007 04:55:59 +0000 (04:55 -0000)]
remove trailing whitespace
Denis Vlasenko [Sun, 14 Oct 2007 04:48:44 +0000 (04:48 -0000)]
setsebool: new applet (Yuichi Nakamura <ynakam@hitachisoft.jp>)
Denis Vlasenko [Sun, 14 Oct 2007 02:34:20 +0000 (02:34 -0000)]
httpd: fix bug where we were trying to read more POSTDATA than content-length
Denis Vlasenko [Sun, 14 Oct 2007 01:37:53 +0000 (01:37 -0000)]
bzip2: code size shrink
Denis Vlasenko [Sun, 14 Oct 2007 00:44:10 +0000 (00:44 -0000)]
bzip2: remove files which are not used anymore
Denis Vlasenko [Sun, 14 Oct 2007 00:43:01 +0000 (00:43 -0000)]
bzip2: size reduction, to just below 9k.
Denis Vlasenko [Sat, 13 Oct 2007 03:36:03 +0000 (03:36 -0000)]
bzip2: port bzip2 1.0.4 to busybox. note: bzip2 code resides
in separate directory (archival/bz/*)
and is covered by BSD-style license.
code size: 13k
Denis Vlasenko [Thu, 11 Oct 2007 19:53:10 +0000 (19:53 -0000)]
whitespace/style fix