Glenn L McGrath [Fri, 23 Jul 2004 02:11:25 +0000 (02:11 -0000)]
Patch from Dmitry Zakharov to fix a bug discovered via the freeswap
script.
Glenn L McGrath [Fri, 23 Jul 2004 01:49:46 +0000 (01:49 -0000)]
Fix for a bug identied by Harald Kuthe, when using many interfaces (29
in this case) the order was incorrect and there were duplicate entries.
Glenn L McGrath [Fri, 23 Jul 2004 01:42:28 +0000 (01:42 -0000)]
Felipe Kellermann writes,
"As noticed today by Steven Scholz, the od's `-v' was broken.
I've fixed that and now both the flags `-v' and `-a' are OK"
Fixes a segfault in
echo "uuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu\02bar\4"| ./busybox od -av
Glenn L McGrath [Fri, 23 Jul 2004 01:35:41 +0000 (01:35 -0000)]
Patch from Felipe Kellermann, "There is a call to printf using `*pr-cchar'
referencing a string and using a single char, when *p <= 0x1f."
Glenn L McGrath [Fri, 23 Jul 2004 01:27:56 +0000 (01:27 -0000)]
Patch from Felipe Kellermann to fix some typo's
Glenn L McGrath [Fri, 23 Jul 2004 01:20:57 +0000 (01:20 -0000)]
Patch from Adam Slattery to add bzip2 support to rpm2cpio
Glenn L McGrath [Fri, 23 Jul 2004 01:10:22 +0000 (01:10 -0000)]
Patch from Manousaridis Angelos to bring dhclient down more elegently
Glenn L McGrath [Thu, 22 Jul 2004 04:23:18 +0000 (04:23 -0000)]
Reverse my previous change, "::" is a GNU getopt extension that allows
an optional argument.
Looks like a glibc bug to me
Robert Griebl [Thu, 22 Jul 2004 00:03:39 +0000 (00:03 -0000)]
Patch from Mike Snitzer <snitzer@gmail.com>:
Support for /etc/modprobe.conf (for 2.6 kernels) should likely be added
to bb's modprobe, see attached patch.
modprobe.conf is just a (even simpler) variant of modules.conf
Glenn L McGrath [Wed, 21 Jul 2004 23:56:31 +0000 (23:56 -0000)]
Patch from Mike Snitzer to fix return codes.
"I have a need to _really_ know if the interface was properly configured
via ifup so I made busybox's ifupdown pass the return codes through rather
than dropping them on the floor."
"All the functions in ifupdown.c return 1 on success and 0 on failure
(which happens to the opposite of standard practices but whatever).
So it is important for all these functions to not blindly return 1."
"The problem with blindly returning ret, even if it is != 1, is the
callers expect a 0 or 1 and accumulate the return codes. So a function that
makes 3 calls to execute will have a value of 3 accumulated. That value
of 1 (success) was almost always returned even if 1 of the commands in the
command sequence failed. The attached patch fixes the lack of checking
to verify thar result == expected_reult."
Glenn L McGrath [Wed, 21 Jul 2004 13:06:30 +0000 (13:06 -0000)]
Fix bug in accepting buffer size argument
Glenn L McGrath [Wed, 21 Jul 2004 12:25:55 +0000 (12:25 -0000)]
Patch from Tito, ass usage for strings -a options
Glenn L McGrath [Wed, 21 Jul 2004 12:21:39 +0000 (12:21 -0000)]
Patch from Mike Snitzer, bring down dhclient using its correct pid, fix
a grammatical error.
Glenn L McGrath [Wed, 21 Jul 2004 10:20:19 +0000 (10:20 -0000)]
Patch from Jean Wolter, fixes compiler warning when ASH_ALIAS is
disabled.
Glenn L McGrath [Wed, 21 Jul 2004 09:00:39 +0000 (09:00 -0000)]
Fixup -T (--files-from) option, works for non-directories now
Eric Andersen [Tue, 20 Jul 2004 22:53:59 +0000 (22:53 -0000)]
Avoid a naming conflict with include/bits/fcntl.h
Robert Griebl [Tue, 20 Jul 2004 18:36:51 +0000 (18:36 -0000)]
Patch from Mike Snitzer <snitzer@gmail.com>:
Please see the attached patch for the following crash with busybox'
2.6 rmmod support
Robert Griebl [Tue, 20 Jul 2004 15:43:57 +0000 (15:43 -0000)]
new_process_module_arguments returns 0 on error and 1 if everything went ok
somehow the ! got lost..
symptoms: modules could only be loaded _without_ parameters
Eric Andersen [Tue, 20 Jul 2004 11:41:16 +0000 (11:41 -0000)]
oops
Eric Andersen [Tue, 20 Jul 2004 11:31:52 +0000 (11:31 -0000)]
Yet more doc updates
Eric Andersen [Tue, 20 Jul 2004 11:31:08 +0000 (11:31 -0000)]
more doc updates
Eric Andersen [Tue, 20 Jul 2004 11:23:45 +0000 (11:23 -0000)]
cut-n-paste strikes again
Eric Andersen [Tue, 20 Jul 2004 11:08:30 +0000 (11:08 -0000)]
Update for release
Eric Andersen [Tue, 20 Jul 2004 10:12:21 +0000 (10:12 -0000)]
Update changelog
Eric Andersen [Tue, 20 Jul 2004 10:05:13 +0000 (10:05 -0000)]
Deal with the fact that 2.6.x kernels replace any '-'s in the
module name with a '_'.
-Erik
Eric Andersen [Tue, 20 Jul 2004 09:23:41 +0000 (09:23 -0000)]
Bump version up to release candidate 1
Eric Andersen [Tue, 20 Jul 2004 08:07:10 +0000 (08:07 -0000)]
Include some documentation posted to the list by vodz
Eric Andersen [Tue, 20 Jul 2004 06:44:46 +0000 (06:44 -0000)]
Assign 'forced' before the goto to avoid a warning
Eric Andersen [Tue, 20 Jul 2004 06:35:54 +0000 (06:35 -0000)]
Prevent "`bootp_down' was declared implicitly `extern' and later `static'" warning
Eric Andersen [Tue, 20 Jul 2004 06:09:14 +0000 (06:09 -0000)]
Add missing type for CONFIG_FEATURE_QUERY_MODULE_INTERFACE
Eric Andersen [Tue, 20 Jul 2004 06:06:56 +0000 (06:06 -0000)]
Update the default config to not ask stuff
Eric Andersen [Tue, 20 Jul 2004 06:04:28 +0000 (06:04 -0000)]
The 'tests' target is long gone.
Eric Andersen [Thu, 15 Jul 2004 12:53:49 +0000 (12:53 -0000)]
Replace the old and somewhat buggy pwd_grp stuff with the shiny
new stuff mjn3 wrote for uClibc
Eric Andersen [Thu, 15 Jul 2004 06:01:05 +0000 (06:01 -0000)]
Peter Kjellerstedt at axis.com writes:
Hello,
the attached patch should bring extra/config in line
with the Linux 2.6.7 sources.
The following are the commit messages for the respective
files from the Linux bk-repository:
checklist.c:
* fix menuconfig choice item help display
confdata.c:
* config: choice fix
* kconfig: don't rename target dir when saving config
expr.c, expr.h:
* config: disable debug prints
mconf.c:
* fix menuconfig choice item help display
menu.c:
* Kconfig: use select statements
symbol.c:
* config: choice fix
* Avoid bogus warning about recursive dependencies
* c99 struct initialiser conversions
textbox.c:
* janitor: don't init statics to 0
util.c:
* fix lxdialog behaviour
//Peter
Eric Andersen [Wed, 14 Jul 2004 10:01:04 +0000 (10:01 -0000)]
Fixup a few documentation bugs
Eric Andersen [Tue, 13 Jul 2004 00:09:34 +0000 (00:09 -0000)]
Fixup some cases of "QM_MODULES: not implemented" for both
lsmod and rmmod when using 2.6.x module support
-Erik
Eric Andersen [Tue, 29 Jun 2004 00:48:30 +0000 (00:48 -0000)]
Paul Fox writes:
hi --
working with ifupdown, i've found a couple of buglets --
the wrong string is passed to an error message.
paul
Eric Andersen [Mon, 28 Jun 2004 23:50:31 +0000 (23:50 -0000)]
Avoid a number of places where large drives could wrap a uint, and
instead use off_t which will be automagically promoted to 64bit if
compiled with support for large drives.
-Erik
Eric Andersen [Fri, 25 Jun 2004 11:23:03 +0000 (11:23 -0000)]
Do not mess with the console logging level unless
asked to do so.
-Erik
Glenn L McGrath [Fri, 25 Jun 2004 09:01:09 +0000 (09:01 -0000)]
Revert my previous commit
Glenn L McGrath [Fri, 25 Jun 2004 07:47:03 +0000 (07:47 -0000)]
Fix compile error under 2.6, check for newer versions first or all the
checks wont be considered.
Glenn L McGrath [Fri, 25 Jun 2004 07:05:13 +0000 (07:05 -0000)]
Fix compile error when math support disabled.
Eric Andersen [Tue, 22 Jun 2004 20:10:53 +0000 (20:10 -0000)]
fix a stupid compile error when CONFIG_FEATURE_INSMOD_VERSION_CHECKING
is disabled
Eric Andersen [Tue, 22 Jun 2004 20:09:40 +0000 (20:09 -0000)]
Stupidity-1, Erik-0
Eric Andersen [Tue, 22 Jun 2004 19:07:21 +0000 (19:07 -0000)]
Bastian Blank notices a couple of int64_ts that should have
been longs
Eric Andersen [Tue, 22 Jun 2004 19:05:05 +0000 (19:05 -0000)]
Add missing 'S' to the getopt string.
Eric Andersen [Tue, 22 Jun 2004 11:50:52 +0000 (11:50 -0000)]
kill off insmod support for older pre 2.1 Linux kernels,
which are not supported with the current busybox 1.0 release
-Erik
Eric Andersen [Tue, 22 Jun 2004 10:43:09 +0000 (10:43 -0000)]
Patrick Huesmann writes:
Hi,
There was some problem with busybox modprobe. For details see
http://www.busybox.net/lists/busybox/2004-May/011507.html
I made a patch against busybox-1.00-pre10 to fix that one.
This is a slight variant of Patrick's patch with a slightly
cleaner implementation of mod_strcmp()
-Erik
Eric Andersen [Tue, 22 Jun 2004 10:18:30 +0000 (10:18 -0000)]
Robin Farine writes:
Hi,
Package: BusyBox
Version: 1.0.0-pre10
When an incomplete read or write from/to a local file occurs (i.e.
not an EOF condition), the tftp client prematurely exits. This
problem can be reproduced by slowly piping data to the tftp client
like this:
(for v in 1 2 3; do echo $v; sleep 1; done) | \
tftp -p -l - -r output.txt <host>
The output file on the TFTP server will contain "1".
The attached patch provides a possible solution to this problem.
I can reproduce this on ARM sa1110 and ARM xscale boards, both
running Linux-2.6.4 & glibc-2.3.2. Thanks for the wonderful
program!
Robin
Eric Andersen [Tue, 22 Jun 2004 10:12:59 +0000 (10:12 -0000)]
Patch from Bastian Blank:
Hi folks
The following patch adds a new log message output to syslogd. This
output omits hostname and priority and is used in d-i to make the syslog
output better readable without lossing information.
Bastian
I am applying this since I have syslogd hacked up in my wife's
access point with the same format string.... Might as well make
this hack official.
-Erik
Eric Andersen [Tue, 22 Jun 2004 10:07:17 +0000 (10:07 -0000)]
Patch from Bastian Blank:
On Sat, Jun 19, 2004 at 10:57:37PM +0200, Bastian Blank wrote:
> The following patch changes klogd to use openlog/syslog themself
> instead of calling syslog_msg which always calls the triple
> openlog/syslog/closelog.
Updated patch: get rid of syslog_msg entirely. Request from Erik Andersen.
Bastian
Eric Andersen [Tue, 22 Jun 2004 08:40:54 +0000 (08:40 -0000)]
Robin Farine writes:
Package: BusyBox
Version: 1.0.0-pre10
Passing the -q <integer> option to inetd causes it to dereference an
invalid pointer (optarg). The attached patch provides a fix to this
problem.
Robin
Eric Andersen [Tue, 22 Jun 2004 08:29:45 +0000 (08:29 -0000)]
Patch from Bastian Blank:
The updated patch adds a config option to explicitely enable 64 bit
arithmetic.
Also it removes the arith prototype from libbb.h as it is not used
outside of ash.
Bastian
this patch has been slightly modified by Erik for cleanliness.
Eric Andersen [Sat, 19 Jun 2004 06:26:30 +0000 (06:26 -0000)]
note the new mailing list policy
Eric Andersen [Wed, 9 Jun 2004 10:00:20 +0000 (10:00 -0000)]
Typo fix from Niemann Hartmut
Glenn L McGrath [Sun, 6 Jun 2004 10:22:43 +0000 (10:22 -0000)]
Update reference for zip format
Glenn L McGrath [Sat, 5 Jun 2004 07:58:18 +0000 (07:58 -0000)]
Woops, the previous commit was an accident, its supplied in the patch,
dont commit yet as we are in feature freeze
Glenn L McGrath [Sat, 5 Jun 2004 07:54:52 +0000 (07:54 -0000)]
Device table support for makedevs, the previous behaviour can been
selected at configure time.
Rob Landley [Wed, 26 May 2004 22:09:37 +0000 (22:09 -0000)]
Ahem. ("I'm just tweaking a documentation string, I don't need to compile
test it before checking in..." New entry for famous last words list.)
Add the missing backslash at the end of the new sed doc string line.
(This one actually compiled with "show verbose applet usage messages"...)
Rob Landley [Wed, 26 May 2004 21:59:31 +0000 (21:59 -0000)]
Update sed help. (Add -r option to long help, add -i option to brief help,
and alphabetizie the option list.)
Eric Andersen [Wed, 26 May 2004 21:26:07 +0000 (21:26 -0000)]
Kevin P. Fleming writes:
Yes, I know busybox is in feature freeze. If this two-liner is too much
that's fine, but it's handy.
This patch allows busybox mount to support "-o move" just like it
supports "-o bind", which is the equivalent of util-linux "mount --move".
Usage is:
mount -o move /mnt/point/1 /mnt/point/2
where /mnt/point/1 is an already mounted filesystem; it will be moved to
/mnt/point/2.
Eric Andersen [Wed, 26 May 2004 17:17:39 +0000 (17:17 -0000)]
Update U.S. Robotics and Actiontec entries
Manuel Novoa III [Wed, 26 May 2004 15:21:19 +0000 (15:21 -0000)]
If read were to return with an error, bad things would happen. Fix it.
Also, make sure read errors are reflected in the applet exit code.
Eric Andersen [Wed, 26 May 2004 12:06:38 +0000 (12:06 -0000)]
oops
Eric Andersen [Wed, 26 May 2004 11:59:19 +0000 (11:59 -0000)]
Per suggestion from Bastian Blank, be less evil when we force fdisk to
transparently remap 32-bit interfaces to actually use 64 bit interfaces.
-Erik
Eric Andersen [Wed, 26 May 2004 11:50:37 +0000 (11:50 -0000)]
Use tab not space
Eric Andersen [Wed, 26 May 2004 11:48:29 +0000 (11:48 -0000)]
Make the grep option values a bit less horrible
Eric Andersen [Wed, 26 May 2004 11:47:55 +0000 (11:47 -0000)]
Rick Richardson writes:
Here is a patch that adds egrep -L support (the opposite of egrep -l).
I realize this is probably too late for 1.0. But I offer it for your
future consideration.
egrep -L is used in some networking startup scripts I inherited.
-Rick
Eric Andersen [Wed, 26 May 2004 11:38:46 +0000 (11:38 -0000)]
Patch from Yoshinori Sato:
This patch is uClinux-2.4.x for H8/300 module support.
please apply.
--
Yoshinori Sato
Eric Andersen [Wed, 26 May 2004 10:28:32 +0000 (10:28 -0000)]
As discussed, drop minit, which was not being supported in busybox.
People wishing to use minit can obtain it and obtain support from
http://www.fefe.de/minit/
Eric Andersen [Wed, 26 May 2004 10:26:10 +0000 (10:26 -0000)]
Use STDIN_FILENO rather than '0'
Eric Andersen [Wed, 26 May 2004 10:03:33 +0000 (10:03 -0000)]
Rob Landley writes:
add sed -r support.
I bumped into a couple of things that want to use extended regular expressions
in sed, and it really isn't that hard to add. Can't say I've extensively
tested it, but it's small and isn't going to break anything that doesn't use
it, so...
Rob
Eric Andersen [Wed, 26 May 2004 09:54:36 +0000 (09:54 -0000)]
Rob Landley writes:
Run this test, against both busybox and a non-busybox version of "tee".
while true; do i=$[$i+1]; echo "hello $i"; sleep 1; done | ./busybox tee
Now run the busybox one again with the following small patch applied:
Eric Andersen [Wed, 26 May 2004 09:46:41 +0000 (09:46 -0000)]
Patch from vodz to correct 'grep -e pattern1 -e pattern2' logic
Eric Andersen [Tue, 25 May 2004 11:30:22 +0000 (11:30 -0000)]
Do not prompt about FDISK large disk support when LFS is enabled.
Resolve a dependancy problem with the various malloc debug libs
and make them mutually exclusive.
-Erik
Eric Andersen [Wed, 19 May 2004 11:06:20 +0000 (11:06 -0000)]
Do not select LFS
Eric Andersen [Wed, 19 May 2004 10:49:17 +0000 (10:49 -0000)]
Erik,
>http://busybox.net/cgi-bin/cvsweb/busybox/util-linux/fdisk.c?r1=1.22&r2=1.23&diff_format=u
Its hack for "force" ;-)
If to return the previous version of a Config.in
http://busybox.net/cgi-bin/cvsweb/busybox/util-linux/Config.in?r1=1.12&r2=1.13
and to apply last patch, then I shall calm down. ;-)
(OOPS, last patch have autocorrected from my editor begins spaces to tabs and
removed spaces from empty lines too).
--w
vodz
Russ Dill [Wed, 19 May 2004 09:18:04 +0000 (09:18 -0000)]
use busybox sysinfo struct
Eric Andersen [Wed, 19 May 2004 09:00:00 +0000 (09:00 -0000)]
Make vodz happy and make fdisk always use large file support if
possible, even if LFS is not enabled for the rest of busybox.
-Erik
Eric Andersen [Wed, 19 May 2004 08:54:28 +0000 (08:54 -0000)]
Fix a compile problem
Russ Dill [Wed, 19 May 2004 08:29:05 +0000 (08:29 -0000)]
fix timewarp in client (server fix later)
Russ Dill [Wed, 19 May 2004 07:46:23 +0000 (07:46 -0000)]
remove uneccessary check (already done in pidfile.c)
Russ Dill [Wed, 19 May 2004 07:45:47 +0000 (07:45 -0000)]
fix memory leak caused by switch to vfork
Glenn L McGrath [Sun, 16 May 2004 02:35:49 +0000 (02:35 -0000)]
Use int instead of char for return type, in theory avoiding a cast
Glenn L McGrath [Mon, 10 May 2004 08:59:17 +0000 (08:59 -0000)]
Fix for debian bug #248106, should use int for returned getopt value.
Eric Andersen [Wed, 5 May 2004 19:39:21 +0000 (19:39 -0000)]
Steve Grubb writes:
Hi,
I just re-reviewed the patch I just sent...and it needed to be BUFSIZ-3 in
dos2unix.c . tempFn is BUFSIZ so the last addressable spot it BUFSIZ-1. The loop
increments by 2. That's why it should be BUFSIZ-3.
Best Regards,
Steve Grubb
Eric Andersen [Wed, 5 May 2004 10:37:49 +0000 (10:37 -0000)]
Steve Grubb writes:
Hello,
I found and patched 2 more bugs. The first is a misplaced semi-colon. The second
one is a buffer overflow. I doubt the buffer overflow is triggered in real life.
But you never know what those wily hackers are up to.
Thanks,
Steve Grubb
Eric Andersen [Wed, 5 May 2004 07:05:32 +0000 (07:05 -0000)]
Steve Grubb writes:
Hello,
Last November a bug was found in iproute. CAN-2003-0856 has more information.
Basically, netlink packets can come from any user. If a program performs action
based on netlink packets, they must be examined to make sure they came from the
place they are expected (the kernel).
Attached is a patch against pre8. Please apply this before releasing 1.00 final.
All users of busy box may be vulnerable to local attacks without it.
Best Regards,
Steve Grubb
Glenn L McGrath [Tue, 4 May 2004 10:43:34 +0000 (10:43 -0000)]
Fix size command, safe_strtoul gives and error if the \r is left in, the
RFC spec says the \r should be there.
This fix is the same as a recent wget fix
Glenn L McGrath [Sun, 2 May 2004 08:38:53 +0000 (08:38 -0000)]
Add part of a patch from Vernon Sauder that i missed a while back
Glenn L McGrath [Sun, 2 May 2004 03:01:08 +0000 (03:01 -0000)]
Update dpkg-deb usage to match current practices
Glenn L McGrath [Sat, 1 May 2004 11:47:24 +0000 (11:47 -0000)]
This patch makes the id command SuS3 compliant and provides a groups
applet via an alias to id.
- Add G option
- Pedantic option checking
- If effective group and user differs from the real one show both.
id.
- Alias id -Gn to groups applet
Eric Andersen [Sat, 1 May 2004 01:27:30 +0000 (01:27 -0000)]
Do not use getpass(3)
Glenn L McGrath [Sat, 1 May 2004 00:49:49 +0000 (00:49 -0000)]
Re-add the TODO list, mention tr
Glenn L McGrath [Fri, 30 Apr 2004 23:09:39 +0000 (23:09 -0000)]
Bugfixes
1) a non NULL terminated buffer that can mess up output, spotted by Ian
Latter
2) in miscutils/strings.c: get rid of useless pointer dereference in
third part of for(;;), spotted by Larry Doolittle
3) bug when reading from a pipe and being invoked as strings
"cat Readme | strings" is broken
"cat Readme | busybox strings" works
spotted by Ian Latter and fixed by Tito.
Glenn L McGrath [Thu, 29 Apr 2004 09:24:19 +0000 (09:24 -0000)]
Fix symlink handling and small memory leak
Eric Andersen [Mon, 26 Apr 2004 19:32:49 +0000 (19:32 -0000)]
Thomas Koeller writes:
Hi,
the following output is from BusyBox 1.0.0-pre10:
~ # ip link help
ip: Command "help" is unknown, try "ip link help".
tk
This patch fixes it by removing the advertisements for
the "ip blah help" stuff that is not implemented.
Glenn L McGrath [Sun, 25 Apr 2004 06:05:14 +0000 (06:05 -0000)]
Sync my tasks with AUTHORS file
Glenn L McGrath [Sun, 25 Apr 2004 05:11:19 +0000 (05:11 -0000)]
Update my email address, document some of my tasks in the AUTHORS file
Eric Andersen [Wed, 21 Apr 2004 00:57:14 +0000 (00:57 -0000)]
This sed patch can only be described as "duh". Stat the source file, chmod
the _destination_ file. (Ah hah! That works _much_ better...) I
implemented the behavior, I just forgot to test this corner of it. My fault,
sorry...
No, gnu sed -i doesn't preverve ownership information. I checked.
Permissions, yes, ownership info, no.
Rob