red-001 [Thu, 27 Apr 2017 09:49:44 +0000 (10:49 +0100)]
Allow scripts to get the client protocol version in non-debug builds. (#5649)
Bluebird [Thu, 27 Apr 2017 09:49:07 +0000 (04:49 -0500)]
Fix incorrect formspec-tooltip doc, add detail in 'floodable' & 'on_flood' docs (#5660)
* Fix incorrect formspec tooltip documentation
* Improve `floodable` and `on_flood` documentation.
The original documentation did not specify that liquids should not themselves be floodable. This is probably something that should be mentioned.
Loic Blot [Wed, 26 Apr 2017 19:11:46 +0000 (21:11 +0200)]
red-001 [Wed, 26 Apr 2017 19:10:13 +0000 (20:10 +0100)]
Fix #5655 (#5658)
Client: Don't send `TOSERVER_RECEIVED_MEDIA` since it's not used anymore
Server: Handle `TOSERVER_RECEIVED_MEDIA` using `Server::handleCommand_Deprecated`
Bluebird [Wed, 26 Apr 2017 05:24:15 +0000 (00:24 -0500)]
Tiny documentation fix. (#5659)
There are plenty of lines longer than 80 characters, and spliting the function declaration across two lines can be momentarily confusing.
ShadowNinja [Tue, 25 Apr 2017 17:38:08 +0000 (13:38 -0400)]
Rename Scripting API files for consistency
Louis Pearson [Tue, 25 Apr 2017 11:11:51 +0000 (06:11 -0500)]
Footsteps without view bobbing (#5645)
* Remove redundant view_bobbing setting
Also fixes bug where disabling view_bobbing disables footstep sounds.
* Removes redundant view_bobbing setting
Setting view_bobbing amount to 0 is now the only way to
turn view_bobbing on and off. Also fixed a bug where footstep
sounds would not play when view_bobbing was disabled.
Loïc Blot [Tue, 25 Apr 2017 08:17:53 +0000 (10:17 +0200)]
Fix various points reported by cppcheck (#5656)
* Fix various performance issues reported by cppcheck + code style (CI)
* Make CI happy with code style on master
* guiFileSelectMenu: remove useless includes
* some performance fixes pointed by cppcheck
* remove some useless casts
* TextDest: remove unused setFormSpec function
* Fix various iterator post-increment reported by cppcheck
Loïc Blot [Mon, 24 Apr 2017 14:06:27 +0000 (16:06 +0200)]
Gitlab-CI: keep build workspace only 1 hour
Loic Blot [Sun, 23 Apr 2017 14:22:53 +0000 (16:22 +0200)]
Fix lint since recent player to db merge
Loïc Blot [Sun, 23 Apr 2017 12:35:08 +0000 (14:35 +0200)]
Player data to Database (#5475)
* Player data to Database
Add player data into databases (SQLite3 & PG only)
PostgreSQL & SQLite: better POO Design for databases
Add --migrate-players argument to server + deprecation warning
* Remove players directory if empty
Loic Blot [Sun, 23 Apr 2017 08:24:00 +0000 (10:24 +0200)]
LINT fix
Loic Blot [Sun, 23 Apr 2017 08:21:08 +0000 (10:21 +0200)]
Revert "CONTRIBUTING: disallow signed git commits"
This reverts commit
7a6502a7a5007e4bed8c1dd10af39d4fa2b296a4.
Signed commits are supported by PPA and weblate now
Loïc Blot [Sun, 23 Apr 2017 07:52:40 +0000 (09:52 +0200)]
Pass clang-format on various cpp/header files (#5559)
red-001 [Sat, 22 Apr 2017 11:59:02 +0000 (12:59 +0100)]
Network:Remove old opcodes and fix documentation. (#5573)
paramat [Sat, 22 Apr 2017 04:16:50 +0000 (05:16 +0100)]
Mgflat, Mgv7: Fix noise crash on world exit.
Fix crash caused by destructor 'delete' on noise objects that are not
created due to mapgen options.
Crash was caused by commit
57eaf62c697cec91890d9cb28d10385d293d2d3f
Dániel Juhász [Fri, 21 Apr 2017 10:56:10 +0000 (12:56 +0200)]
Add /fixlight chat command
paramat [Fri, 21 Apr 2017 01:19:24 +0000 (02:19 +0100)]
Mgflat, Mgv7: Only create noise objects if needed
paramat [Thu, 20 Apr 2017 21:47:28 +0000 (22:47 +0100)]
Sneak glitch: Set default to false
The 'sneak glitch' physics override now controls whether a player can
use the new move code replications of the old sneak side-effects:
sneak ladders and 2 node sneak jump. This completes our intention to
replicate the old sneak side-effects in new code and provide them as
an option that is disabled by default.
Auke Kok [Thu, 20 Apr 2017 06:10:39 +0000 (23:10 -0700)]
Add on_flood() callback.
This callback is called if a liquid definitely floods a non-air
node on the map. The callback arguments are (pos, oldnode, newnode)
and can return a `bool` value indicating whether flooding the
node should be cancelled (`return true` will prevent the node
from flooding).
Documentation is added, the callback function was tested with a
modified minetest_game.
Note that `return true` will likely cause the node's `on_flood()`
callback to be called every second until the node gets removed,
so care must be taken to prevent many callbacks from using this
return value. The current default liquid update interval is 1.0
seconds, which isn't unmanageable.
The larger aim of this patch is to remove the lava cooling ABM,
which is a significant cost to idle servers that have lava on their
map. This callback will be much more efficient.
Dániel Juhász [Fri, 21 Apr 2017 22:55:07 +0000 (00:55 +0200)]
Fix a memory leak (#5636)
Loic Blot [Fri, 21 Apr 2017 22:51:13 +0000 (00:51 +0200)]
Fixing warning pointed by @sfan5 and clang and cleanup guiFileSelectMenu
* Also pass clang-format on guiFileSelectMenu.h and remove it from whitelist
Loic Blot [Fri, 21 Apr 2017 22:36:59 +0000 (00:36 +0200)]
Revert a const ref on update texture
if mod is a reference to a class member a variable swap breaks.
We should find a way to keep this const ref if possible.
Added a comment about this in header
Loïc Blot [Fri, 21 Apr 2017 22:34:00 +0000 (00:34 +0200)]
lua: remove core.cause_error call (#5637)
it was used in minimal to trigger core crash, not very useful
Loïc Blot [Fri, 21 Apr 2017 21:40:48 +0000 (23:40 +0200)]
Fix various performance issues reported by cppcheck + code style (CI) (#5635)
* Make CI happy with code style on master
* guiFileSelectMenu: remove useless includes
* some performance fixes pointed by cppcheck
* remove some useless casts
* TextDest: remove unused setFormSpec function
orwell96 [Fri, 21 Apr 2017 17:31:59 +0000 (19:31 +0200)]
Fix #5617 - respect message and reconnect parameters when shutting down immediately (#5621)
Dániel Juhász [Fri, 21 Apr 2017 16:04:06 +0000 (18:04 +0200)]
Fix after soft node overlays
This removes a segmentation fault and makes node meshes well colorized.
Dániel Juhász [Fri, 21 Apr 2017 13:34:59 +0000 (15:34 +0200)]
Soft node overlay (#5186)
This commit adds node overlays, which are tiles that are drawn on top of
other tiles.
Loïc Blot [Fri, 21 Apr 2017 08:22:20 +0000 (10:22 +0200)]
Gitlab-CI enhancements (#5629)
Loïc Blot [Fri, 21 Apr 2017 08:06:08 +0000 (10:06 +0200)]
Fix various performance issues reported by cppcheck (#5628)
* Also remove 1 non declared but defined functions
Ekdohibs [Thu, 20 Apr 2017 04:06:15 +0000 (06:06 +0200)]
Run generate_from_settingtypes.lua
Dániel Juhász [Sat, 11 Mar 2017 16:07:04 +0000 (17:07 +0100)]
Light update for map blocks
This is not really different from the light update of a voxel
manipulator. This update does not assume that the lighting was correct
before, therefore it is useful for correction.
Also expose this function to the Lua API for light correction, and
allow voxel manipulators not to update the light.
Dániel Juhász [Sat, 11 Mar 2017 16:03:15 +0000 (17:03 +0100)]
Split light update into two parts
The common part can be reused.
Loïc Blot [Wed, 19 Apr 2017 22:12:52 +0000 (00:12 +0200)]
Fix various copy instead of const ref reported by cppcheck (part 3) (#5616)
* Also remove 2 non declared but defined functions
* Make some functions around const ref changes const
Loïc Blot [Wed, 19 Apr 2017 21:02:07 +0000 (23:02 +0200)]
Fix various copy instead of const ref reported by cppcheck (#5615)
* Also remove InventoryList::peekItem unused function
* Fix some post increment to preincrement reported by cppcheck
paramat [Mon, 17 Apr 2017 13:17:43 +0000 (14:17 +0100)]
Conf.example: Move some lines to minetest.conf.example.extra
Some information in conf.example cannot be generated from
settingtypes.txt, moving it to a new file makes generating
conf.example while preserving that information easier.
Regenerate conf.example from settingtypes.txt.
MarkuBu [Thu, 13 Apr 2017 11:58:34 +0000 (13:58 +0200)]
Pointed thing to face pos: Fix crash if opening door with slab or stair
Avoids crash caused when 'pointed thing -under' and '-above' are not
face-neighbours, for example in the case of pointing to the top half
of a door.
Hybrid Dog [Mon, 10 Apr 2017 20:07:52 +0000 (22:07 +0200)]
Tools: Fix tool digging speed limit
Loïc Blot [Tue, 18 Apr 2017 22:36:30 +0000 (00:36 +0200)]
Fix various variables passed by copy instead of const ref (#5610)
Pointed by cppcheck
Loïc Blot [Tue, 18 Apr 2017 15:13:50 +0000 (17:13 +0200)]
Auke Kok [Tue, 18 Apr 2017 05:48:17 +0000 (22:48 -0700)]
Reorder TileSpec. (#5591)
Put accessed members that are needed by updateFastFaceRow()
all in the same cacheline.
Ekdohibs [Tue, 18 Apr 2017 04:40:53 +0000 (06:40 +0200)]
Fix always using the xbox layout (reported by coverity).
Auke Kok [Sat, 15 Apr 2017 05:16:57 +0000 (22:16 -0700)]
Don't make TAB exit game if bound to inventory.
I play with the TAB key bound to the inventory. However, the
code here assumes that TAB means "close formspec" in all contexts,
including the main menu. This causes my game to exit when I attempt
to TAB in between USERNAME and PASSWORD fields.
We know when m_client != NULL that the game is a client game and
not in the main menu, and then it's OK to use the INVENTORY bound
key to exit the formspec, since it's not the main menu.
SmallJoker [Mon, 17 Apr 2017 11:49:48 +0000 (13:49 +0200)]
Fix MSVC build broken by
34d32ce
`round` -> `myround`
Remove superflous `floor` calls
Perttu Ahola [Sat, 15 Apr 2017 07:55:52 +0000 (10:55 +0300)]
MeshUpdateQueue: Add a MapBlock cache that minimizes the amount of MapBlock copying done in the main thread
Cache size is configurable by the meshgen_block_cache_size (default 20 MB).
New profiler stats:
- MeshUpdateQueue MapBlock cache hit %
- MeshUpdateQueue MapBlock cache size kB
Removes one type of stutter that was seen on the client when received MapBlocks
were being handled. (the "MeshMakeData::fill" stutter)
Kind of related to at least #5239
Originally preceded by these commits, now includes them:
- Move the mesh generator thread into src/mesh_generator_thread.{cpp,h}
- mesh_generator_thread.cpp: Update code style
- MeshUpdateThread: Modify interface to house a different implementation: Actual functionality will be changed by next commits.
- MeshMakeData: Add fillBlockData() interface (so that caller can fill in stuff from eg. a MapBlock cache)
Perttu Ahola [Sat, 15 Apr 2017 15:21:23 +0000 (18:21 +0300)]
Include container.h in util/thread.h. util/thread.h doesn't compile without it
paramat [Wed, 5 Apr 2017 11:18:22 +0000 (12:18 +0100)]
Sneak: Add option for old move code
Temporary option for the old move code for specific old sneak behaviour.
Enabled by setting the added 'new move' physics override to false.
By default 'new move' is true.
Loic Blot [Mon, 17 Apr 2017 07:37:12 +0000 (09:37 +0200)]
Remove an unused variable in Android Build
Auke Kok [Mon, 17 Apr 2017 07:04:58 +0000 (00:04 -0700)]
Plug two minor Leaks (#5603)
* Resource leak: CHECK_FILE_ERR returns, without freeing chunk_name.
Found with static analysis.
* Resource leak: leaks `page` on error path.
Found with static analysis.
Loïc Blot [Sun, 16 Apr 2017 12:44:15 +0000 (14:44 +0200)]
Android progressbar fix (#5601)
* Fix progressbar for Android
Fixes #5599
Fixed #5403
* draw_load_screen: use texturesource
this permits to unify texture loading code
* scale progress bar
* Add gl version check for GL_OES_texture_npot. This fixed the texture on loading screen
* Remove two sanity checks pointed by @celeron55
* sfan5 comments + android ratio fixes
Nathanaël Courant [Sun, 16 Apr 2017 07:48:48 +0000 (00:48 -0700)]
Disable android leveldb by default (#5596)
1) Now leveldb is brick (thanks google)
2) By default, use SQLite3, this work perfectly and NOBODY not use LevelDB on Android :)
Loïc Blot [Sat, 15 Apr 2017 21:19:18 +0000 (23:19 +0200)]
Implement delayed server shutdown with cancelation (#4664)
SmallJoker [Sat, 15 Apr 2017 12:30:27 +0000 (14:30 +0200)]
Minimap: Do a double-typecast to fix compiling with MSVC
Loïc Blot [Sat, 15 Apr 2017 07:25:43 +0000 (09:25 +0200)]
Partial damage cheat fix: node damages server side (#4981)
* Damage cheat fix: server side
* Lava/Node damages overtime server side
* lava hurt interval is only for old protocol
Loic Blot [Fri, 14 Apr 2017 16:26:24 +0000 (18:26 +0200)]
NetworkPacket: don't copy push std::string and std::wstring
Loic Blot [Fri, 14 Apr 2017 13:56:40 +0000 (15:56 +0200)]
Fix wrong channel type in Client/Server CommandFactories
This is a u8 not a u16
Loïc Blot [Fri, 14 Apr 2017 13:34:01 +0000 (15:34 +0200)]
ClientIface::sendToAll: honor packet configuration (#5590)
Loic Blot [Fri, 14 Apr 2017 07:26:11 +0000 (09:26 +0200)]
Fix android build
bigfoot547 [Fri, 14 Apr 2017 07:04:41 +0000 (02:04 -0500)]
[CSM] Add function to set minimap shape (#5569)
* [CSM] Add function to set minimap shape
Also deprecates `toggle_shape`.
* Oh fish, I messed that one up!
* Fix Style
* Sorry, I missed something
I still had the `luamethod` call in there!
* Add getters
* Remove extra line
* Remove useless variable
Please review again @nerzhul . Thanks!
* Satisfy nerzhul
Dániel Juhász [Wed, 12 Apr 2017 23:24:00 +0000 (01:24 +0200)]
Only use palette if param_type2 is correct
Dániel Juhász [Thu, 13 Apr 2017 08:19:46 +0000 (10:19 +0200)]
Add documentation for map block format 27 (#5576)
Vincent Glize [Wed, 12 Apr 2017 21:05:01 +0000 (23:05 +0200)]
[CSM] Fix localplayer documentation (#5557)
numberZero [Wed, 12 Apr 2017 14:51:07 +0000 (18:51 +0400)]
Fix inability to change metadata using stack:to_table() (#5547)
Loic Blot [Wed, 12 Apr 2017 07:05:27 +0000 (09:05 +0200)]
Fix fips_cipher_abort warning and other duplicate macros
red-001 [Tue, 11 Apr 2017 21:35:25 +0000 (22:35 +0100)]
[CSM] Allow escaping chatcommands and add missing calls to gettext. (#5565)
t0ny2 [Tue, 11 Apr 2017 17:29:24 +0000 (18:29 +0100)]
Replace occurrence of luaL_reg in l_localplayer (#5566)
Related to commit
41c5483. Replace a final occurrence of luaL_reg in
src/script/lua_api/l_localplayer.cpp
paramat [Thu, 6 Apr 2017 14:58:12 +0000 (15:58 +0100)]
Sneak glitch: Detect ledge for 2-node climb-up
Re-creates the old sneak-jump behaviour in new code.
Enabled by the 'sneak glitch' physics override.
When a ledge is detected the jump speed modifier is set to the larger
of 'physics override jump' and 1.3 to allow a 2-node climb-up.
An unexpected side-effect is the simple sneak ladder working smoothly.
red-001 [Mon, 10 Apr 2017 19:14:00 +0000 (20:14 +0100)]
[CSM] Use more gettext (#5553)
red-001 [Mon, 10 Apr 2017 19:13:20 +0000 (20:13 +0100)]
[CSM] Move `.list_players` and `.disconnect` to builtin. (#5550)
Loïc Blot [Mon, 10 Apr 2017 07:40:06 +0000 (09:40 +0200)]
Clang-format fix for Android
Loïc Blot [Mon, 10 Apr 2017 07:17:53 +0000 (09:17 +0200)]
Clang-format styles fixes since previous commit
Loic Blot [Mon, 10 Apr 2017 06:05:03 +0000 (08:05 +0200)]
Clang format: fix LINT on old PR which doesn't have LINT enabled
number Zero [Thu, 12 Jan 2017 09:19:36 +0000 (12:19 +0300)]
Hard-coded undersampling.
Adds uniform undersampling for the 3D rendered scene. GUI elements
are not undersampled, resulting in better playability for users
with low-performance platforms with readable fonts and formspecs.
The undersampling setting can be set to 0 (disabled), 2, 3, 4 pixels
which translates into a resolution reduction of x4, x9 or x16, and
is significant.
Vincent Glize [Sat, 8 Apr 2017 10:26:45 +0000 (12:26 +0200)]
LocalPlayer api lua
Dániel Juhász [Fri, 10 Mar 2017 17:25:58 +0000 (18:25 +0100)]
Hardware coloring for itemstacks
Adds the possibility to colorize item stacks based on their metadata.
In the item/node definition you can specify palette (an image file)
and color (fallback color if the item has no palette or metadata).
Then you can add palette_index to the metadata.
Dropped itemstacks with different colors do not merge.
red-001 [Sat, 8 Apr 2017 18:03:57 +0000 (19:03 +0100)]
Move chat command handling code from C++ to Lua (#5528)
raymoo [Sat, 8 Apr 2017 08:42:59 +0000 (01:42 -0700)]
Document that write_json will error on unserializable types. (#5539)
Previously it was erroneously documented that it would save them as null.
Loïc Blot [Sat, 8 Apr 2017 08:19:07 +0000 (10:19 +0200)]
Prepare for Linux daily build packages (using Gitlab.com CI) (#5542)
* Prepare for Linux daily build packages (using Gitlab.com CI)
Loïc Blot [Sat, 8 Apr 2017 07:28:37 +0000 (09:28 +0200)]
Replace luaL_reg with luaL_Reg as recent LuaJIT dropped the Lua 5.0 compat (#5541)
We are bundling Lua5.1 which has same macro
Loic Blot [Sat, 8 Apr 2017 06:45:58 +0000 (08:45 +0200)]
code style fix on src/script/cpp_api/s_client.h
Vincent Glize [Sat, 8 Apr 2017 06:20:30 +0000 (08:20 +0200)]
[CSM] Add event on_connect player API lua (#5540)
* Add event on_connect player API lua
Loic Blot [Fri, 7 Apr 2017 21:56:02 +0000 (23:56 +0200)]
Fix cmake library default build problem since moving to lib/
Also make Lua library check a cmake module
Loic Blot [Fri, 7 Apr 2017 21:22:00 +0000 (23:22 +0200)]
Pass clang-format on 14 trivial header files fixes
Also remove them from whitelist
rubenwardy [Fri, 7 Apr 2017 18:06:50 +0000 (19:06 +0100)]
Fix signed/unsigned conversion warning
There was no bug here (as I checked for negativeness),
however it's good to get rid of warnings.
SmallJoker [Fri, 7 Apr 2017 15:59:27 +0000 (17:59 +0200)]
Cavegen: Fix non-constant array initializer error for MSVC
SmallJoker [Fri, 7 Apr 2017 15:10:26 +0000 (17:10 +0200)]
Settings: Update documentation (#5534)
Now documented (sorted a-z):
enable_console
enable_particles
creative_mode
hud_scaling
inventory_image_hack
keymap_console
keymap_zoom
shader_path
view_bobbing
Loic Blot [Fri, 7 Apr 2017 06:50:17 +0000 (08:50 +0200)]
Clang-format: fix some header files and remove them from whitelist
YuGiOhJCJ [Fri, 7 Apr 2017 05:29:43 +0000 (07:29 +0200)]
Add the REQUIRE_LUAJIT option (#5526)
adrido [Fri, 7 Apr 2017 05:14:39 +0000 (07:14 +0200)]
Windows: Skip cmd for release builds (#5416)
Auke Kok [Fri, 7 Apr 2017 05:04:40 +0000 (22:04 -0700)]
Fix "error: ‘playerSAO’ was not declared"
Cause:
351cc2e79a7d78f7ec97ff9b33e4f0bad4042b19
A rebase issue missed a rename from playerSAO to playersao.
Tested.
Ekdohibs [Fri, 24 Mar 2017 14:56:10 +0000 (15:56 +0100)]
Fix spacing
Ekdohibs [Wed, 22 Mar 2017 02:25:16 +0000 (03:25 +0100)]
Fix problems when overriding the hand:
- If the hand can dig a node the item wielded can't, allow to dig it anyway.
- Fix the API callbacks from setting the hand instead of the wielded item.
rubenwardy [Sun, 2 Apr 2017 22:00:34 +0000 (23:00 +0100)]
Add Joystick type detection and Xbox controller support
* Add joystick type detection (with joystick_type setting to override it)
* Fix multiple joysticks from interfering with each other by only reading from one (add joystick_id setting)
* Add support for Xbox controllers
presstabstart [Fri, 7 Apr 2017 03:32:50 +0000 (04:32 +0100)]
Fix multiple death messages (#5305)
Fix multiple death messages (#3565) and damage server logs after death.
orwell96 [Thu, 6 Apr 2017 22:03:29 +0000 (00:03 +0200)]
Show media download progress in percent on progress screen (#5498)
Loïc Blot [Thu, 6 Apr 2017 14:03:29 +0000 (16:03 +0200)]
LINT: Switch whitelist check from egrep to awk
Bonus: make CI happy with the last rules fix
red-001 [Thu, 6 Apr 2017 20:50:45 +0000 (21:50 +0100)]
[CSM] Add function to get the server protocol version. (#5529)
Loïc Blot [Thu, 6 Apr 2017 13:37:02 +0000 (15:37 +0200)]
Clang-format continuation indent fixes + .gitignore additions
* Proper support for continuation indents in clang format
* make src/wieldmesh.h proper and remove it from whitelist
* Add CLion default build directories in .gitignore
Loïc Blot [Thu, 6 Apr 2017 13:27:47 +0000 (15:27 +0200)]
Clang format brace style fix
Loïc Blot [Thu, 6 Apr 2017 08:01:09 +0000 (10:01 +0200)]
Fix clang-format binary selection
Also fix spaces to tabs