udhcpc[6]: allow discover_retries == 0 (infinite)

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

flashcp: remove unused variable opts

Signed-off-by: Manuel Zerpies <manuel.f.zerpies@ww.stud.uni-erlangen.de>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

lineedit: in !EDITING config, return -1 on fgets error

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

fix unsafe bb_perror_msg(filename) calls

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

scripts/kconfig/mconf: work on systems w/o SIGWINCH

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

libbb: correctness/size tweaks in signal-related helpers

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

top: do not touch stdin if -b

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

modprobe_small: make rmmod to NOT remove dependencies. Closes 5162

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

ash: trivial fixes for compile failures

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

top: fix build failure in !USE_TERMIOS case

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

ps: fix build failure in !DESKTOP case

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

top: implement scrolling up/down (_very_ useful)

function                                             old     new   delta
handle_input                                         494     564     +70
top_main                                             928     947     +19
display_topmem_process_list                          363     381     +18
display_process_list                                1442    1453     +11
clearmems                                             38      28     -10
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 4/1 up/down: 118/-10)           Total: 108 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

ushcpc: gracefully handle packets with CHECKSUM_PARTIAL

function                                             old     new   delta
udhcp_recv_raw_packet                                415     579    +164
change_listen_mode                                   317     370     +53
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/0 up/down: 217/0)             Total: 217 bytes

Signed-off-by: Alexey Froloff <raorn@raorn.name>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

telnet: convert Enter -> CR LF in line mode too

function                                             old     new   delta
handle_net_output                                     87      98     +11

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

telnet: shrink literal string size

   text    data     bss     dec     hex filename
 888483     497    7584  896564   dae34 busybox_old
 888450     497    7584  896531   dae13 busybox_unstripped

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

telnet: convert CR -> CR LF, not CR -> CR NUL when sending data to server

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

fbsplash: support non-RGB565 pixels in 16-bit mode

function                                             old     new   delta
fbsplash_main                                        953     989     +36
fb_pixel_value                                        80     110     +30

Signed-off-by: Linus Walleij <triad@df.lth.se>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

find: make -mindepth N -xdev correctly stop on mountpoints

function                                             old     new   delta
fileAction                                           153     193     +40

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

ash: fix "read -s" + ^C. Closes 5504

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

top: fix "last CPU" parsing

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

sysctl: implement -q

function                                             old     new   delta
packed_usage                                       29208   29223     +15
sysctl_act_recursive                                 605     598      -7
sysctl_main                                          233     222     -11

Signed-off-by: Joshua Kahlenberg <jbkberg@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

refactor correct_password.c to avoid one if

Signed-off-by: walter harms <wharms@bfs.de>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

build system: stop .eh_frame generation

From Rich Felker:

By default, modern GCC generates DWARF2 debug/unwind tables in the
.eh_frame section of the object files/binaries. This adds significant
bloat (as much as 15%) to the size of the busybox binary, including
the portion mapped/loaded into memory at runtime (possibly a big issue
for NOMMU targets), and the section is not strippable with the strip
command due to being part of the loaded program text.

I've since done some further checking - both testing and asking the
GCC developers about it - and it seems the solution is to add to the
CFLAGS -fno-unwind-tables and -fno-asynchronous-unwind-tables. If
debugging is disabled, this will prevent GCC from outputting DWARF2
tables entirely. But since busybox builds with -g by default, the
interesting case is what happens then. I originally thought these
options would break debugging, but they don't; instead, they tell GCC
to output the DWARF2 tables in the .debug_frame section instead of
the newish .eh_frame section (used for exception handling). With these
options added, busybox_unstripped is still fully debuggable, and the
final busybox binary loses the 15% bloat factor from the DWARF2
tables.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

wget: reorder fread and poll: poll only if fread returns EAGAIN. Closes 5426

function                                             old     new   delta
retrieve_file_data                                   451     427     -24

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

httpd_indexcgi.c: fix compile failure

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

Fix compile failure in ll_proto.c

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

blkid: add support for nilfs2

function                                             old     new   delta
volume_id_probe_nilfs                                  -      99     +99
fs2                                                   52      56      +4

Signed-off-by: Sven-Göran Bergh <svengbergh-busybox@yahoo.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

volume_id: code shrink

function                                             old     new   delta
volume_id_set_unicode16                              200     173     -27

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

blkid: add type display for btrfs

Signed-off-by: Sven-Göran Bergh <svengbergh-busybox@yahoo.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

ll_proto.c: code shrink

   text    data     bss     dec     hex filename
    762       0       0     762     2fa ll_proto.o.old
    526       0       0     526     20e ll_proto.o

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

style fixes, no code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

getty: tweak style, no code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

wget: try reading after poll timeout - stdio may have buffered data. Closes 5426

function                                             old     new   delta
retrieve_file_data                                   436     451     +15

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

getty: add commented-out extended error diagnostic

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

login: increase login name size limit from 32 to 64

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

udhcp[cd]: fix binding to network aliases. Closes 5432, 5438

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

lineedit: fix Alt-D when cursor==0

Signed-off-by: Cliff Frey <cliff@meraki.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

platform.h: disable ALIGNn macros for s390[x]

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

disable format security warnings

We pass strings to printf directly a lot.  Some distros enable some flags
in their gcc by default like -Wformat-security.  With these two things, we
end up with a lot of build warnings like so:
loginutils/chpasswd.c:42:3: warning: format not a string literal and
no format arguments [-Wformat-security]

But we don't care.  Our focus is first and foremost on size, so adding a
lot of dummy calls like:
- printf(some_constant_string);
+ printf("%s", some_constant_string);
is pointless bloat.

Disable this warning flag if the compiler supports it.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

udhcpc: make -O <numeric_opt> work. Closes 5402

function                                             old     new   delta
udhcpc_main                                         2642    2685     +43
udhcp_recv_raw_packet                                414     415      +1
d6_recv_raw_packet                                   248     249      +1
udhcpc6_main                                        2430    2413     -17
add_client_options                                   239     213     -26
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/2 up/down: 45/-43)              Total: 2 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

Simplify copyright/license notice that appears in the binary.

Existing copyright notice for binary would need to be longer to achieve
optimal accuracy.  This compromise punts to the source for full notices,
but does note the years of the copyrights and that there are many authors,
all licensing under GPLv2.

Signed-off-by: Bradley M. Kuhn <bkuhn@ebb.org>
Signed-off-by: Tony Sebro <tony@sfconservancy.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

Add yet another missing ALIGN2 on a global declaration.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

dhcpd: write lease file on exit

function                                             old     new   delta
udhcpd_main                                         1431    1403     -28

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

*: declare strings with ALIGN1, as appropriate

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

*: declare strings with ALIGN1, as appropriate

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

testsuite: make mkfs.minix test not fail spuriously on big endian

Signed-off-by: Yao Zhao <yao.zhao@windriver.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

sed: allow 'w' cmd to use two address form

function                                             old     new   delta
add_cmd                                             1101    1094      -7

Signed-off-by: Mimi Li <felloak@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

tftpd: fix -u USER to work with chroot. Closes 5348

function                                             old     new   delta
tftpd_main                                           546     568     +22
tftp_protocol                                       1844    1839      -5

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

awk: fix FS assignment behavior. Closes 5108

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

ftpd: free allocated string on error path

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

ftpd: fix MDTM's month value. Closes 5336

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

ash: add a comment about VEXPORT

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

fbset: respect rgba configuration lines in fb.modes

The fbset utility would not respect "rgba" config entries in
the fb.modes file such as this (for the ARM Integrator/CP):

mode "640x480-60-clcd"
    # D: 25.175 MHz, H: 31.469 kHz, V: 59.94 Hz
    geometry 640 480 640 480 16
    timings 39722 48 16 33 10 96 2
    rgba 5/10,5/5,5/0,1/15
endmode

This is important especially for this ARGB5551 device which
is hopeless to configure otherwise. I noticed this lacking
feature after the TI "fbtest" program managed to set up the
the colormode correctly.

Signed-off-by: Linus Walleij <triad@df.lth.se>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

acpid: add missing lid switch definition

This patch adds a missing LID0 switch definition.
Without it, closing the notebook lid is not detected by acpid.

Signed-off-by: Eric Martin <eric.martin@gmx.net>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

include sys/resource.h where needed

We use functions from sys/resource.h in misc applets, but don't include
the header.  This breaks building with newer glibc versions, so add the
include where needed.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

mount: support strictatime option. Closes 5240

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

awk: make -F STR interpret escape sequences. Closes 5126

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

dpkg: fix creation of .list files (were empty since b768aeb). Closes 5324

While at it, fix filename order and free the list of names.

function                                             old     new   delta
llist_rev                                              -      21     +21
get_header_tar                                      1733    1741      +8
unpack_package                                       587     585      -2
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 1/1 up/down: 29/-2)              Total: 27 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

trivial small speed optimization

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

mount: do not pass "comment=ANYTHING" option to kernel. Closes 5240

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

mount: undo recent breakage when mount flags were made unsigned

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

mount: fix the wrongly stored fs creation time

This bug made our ext2 images non-mountable by ext4 driver.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

mount: set up RO loop device if mount -o ro. Closes 4784

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

tweak help texts

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

adduser: install to /usr, not /, like all other similar tools

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

Move several applets to different install dir:

Moved to [/usr]/sbin:
addgroup, adduser, delgroup, deluser,
arping, chat, ether-wake, fdformat, ifplugd,
ip, ipaddr, iplink, iproute, iprule, iptunnel,
killall5, readahead, rtcwake, tftpd, add-shell, remove-shell, powertop.

Moved to /bin for /usr/bin: kbd_mode.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

tweak help text

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

build system: fix build of kconfig on Darwin

Of course busybox cannot be used on Darwin (Mac OS X), but it can be
cross-compiled for Linux there. Cross-compilation still requires kconfig
to be built as native host tool.

Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

wget: fix wget-supports--P testsuite failure. Closes 4940

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

config: do not refer to HTTPS for wget

Signed-off-by: Pierre Carrier <pierre@spotify.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

wget: make -c _not_ truncate the file

function                                             old     new   delta
retrieve_file_data                                   396     436     +40
reset_beg_range_to_zero                               52      45      -7

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

unzip: make options parsing more robust on getopt w/o gnu extensions

Also, code shrank:

function                                             old     new   delta
static.extn                                           15      10      -5
packed_usage                                       29231   29217     -14
unzip_main                                          2388    2291     -97
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-116)           Total: -116 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

Merge branch 'master' of git+ssh://busybox.net/var/lib/git/busybox

wget: correctly handle failure to -c (continue)

function                                             old     new   delta
reset_beg_range_to_zero                                -      52     +52
wget_main                                           2168    2189     +21

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

wget: add dummy --no-cache

function                                             old     new   delta
static.wget_longopts                                 155     166     +11
packed_usage                                       29259   29231     -28

Signed-off-by: Vladimir Dronnikov <dronnikov@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

ps: use separate get_uptime() and make it work on non-linux too

Create get_uptime() function in procps/ps.c, and use it rather than
relying on linux-specific sysinfo() inline.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

nanddump: make dumping read-only partitions work

Make dumping read-only partitions work by opening the device
O_RDONLY; otherwise the open() will fail with -EPERM.

Signed-off-by: Matt Reimer <mreimer@sdgsystems.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

modinfo: match more standard module fields and fix version field

Previously, -F version could match the srcversion= string.

before :
  ~ # modinfo -F version tiwlan_drv
  version:        6.1.2012.05.29
  version:        533BB7E5866E52F63B9ACCB
  version:        0x%x, oui=0x%x, 0x%x, 0x%x
  version:        0x%x

  ~ # modinfo tiwlan_drv
  filename:       tiwlan_drv.ko
  author:         Texas Instruments Inc - Retouched by CyanogenDefy
  license:        GPL
  vermagic:       2.6.32.9 preempt mod_unload ARMv7
  parm:           g_sdio_debug_level:debug level
  depends:

now :
  ~ # modinfo -F version tiwlan_drv
  version:        6.1.2012.05.29

  ~ # modinfo tiwlan_drv
  filename:       tiwlan_drv.ko
  license:        GPL
  author:         Texas Instruments Inc - Retouched by CyanogenDefy
  version:        6.1.2012.05.29
  srcversion:     533BB7E5866E52F63B9ACCB
  depends:
  uts_release:    2.6.32.9-g306944c
  vermagic:       2.6.32.9 preempt mod_unload ARMv7
  parm:           g_sdio_debug_level:debug level

This patch also add support for the old "-n" and some other helpers

Change-Id: Icb4e9ca513cbce46b075a6f038799a7a19fb7e22
Signed-off-by: Tanguy Pruvot <tanguy.pruvot@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

volume_id/ext: use common bb_e2fs_defs.h for ext2/3/4 constants and structs

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

su: do not change to home dir unless -l

Signed-off-by: Pascal Bellard <pascal.bellard@ads-lu.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

remove FEATURE_VI_OPTIMIZE_CURSOR from example config

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

rdate: code shrink

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

Add comments in keyboard escape sequences table

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

vi: save/restore screen upon invocation

function                                             old     new   delta
vi_main                                              253     273     +20

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

vi: nuke FEATURE_VI_OPTIMIZE_CURSOR

It is not Unicode safe, it is not saving much of I/O, and it's large:

function                                             old     new   delta
vi_main                                              255     253      -2
go_bottom_and_clear_to_eol                            28      26      -2
do_cmd                                              4194    4182     -12
show_status_line                                     388     374     -14
strncat                                               39       -     -39
__GI_strncat                                          39       -     -39
refresh                                              774     724     -50
place_cursor                                         276      83    -193
------------------------------------------------------------------------------
(add/remove: 0/3 grow/shrink: 0/6 up/down: 0/-351)           Total: -351 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

ntpd: on time step, kill all outstanding replies from other peers

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

testsuite: some more awk tests related to conditions

Signed-off-by: Tanguy Pruvot <tanguy.pruvot@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

rdate: code shrink

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

vi: do not set autoindent by default

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

libbb: add missing_syscalls.c: for now, only Android syscalls

Signed-off-by: Tias Guns <tias@ulyssis.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

android: some sensible defconfig changes

- no /usr
- no skip rootfs
- use /system/lib/modules

And for niceties:
- show usage
- have installer
- long opts
- verbose cp
- ls --color support
- bbconfig

Also adds lsof (new in 1.20.0)

Signed-off-by: Tias Guns <tias@ulyssis.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

platform.h: Android tweaks: ioprio defines, BB_ADDITIONAL_PATH

Signed-off-by: Tias Guns <tias@ulyssis.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

android: fix 'stat', ifdef S_TYPEIS* in coreutiles/stat.c

patch modified from 'BusyBox Patch V1.0 (Vitaly Greck)'
https://code.google.com/p/busybox-android/downloads/detail?name=patch_busybox

Signed-off-by: Tias Guns <tias@ulyssis.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

inetd: fix build failure in Android

Signed-off-by: Tias Guns <tias@ulyssis.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

brctl: fix build failure by s/strtotimeval/bb_strtotimeval/ (android has strtotimeval)

Signed-off-by: Tias Guns <tias@ulyssis.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

lpr: don't send 0-byte print jobs (compat)

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

tar: fix 256-bit encoded number decoding

Signed-off-by: Etienne Le Sueur <elesueur@vmware.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

ash: fix a bug in >${varexp} handling. Closes 5282

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

sed: yet another fix on top of zero length match code

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

man: fix handling of gzipped manpages

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>