oweals/busybox.git
22 years agoPatch from Thomas Gleixner <tglx@linutronix.de> to do
Eric Andersen [Thu, 12 Sep 2002 15:44:53 +0000 (15:44 -0000)]
Patch from Thomas Gleixner <tglx@linutronix.de> to do
automatic child reaping to avoid zombies

22 years agoApply vodz's last_patch53.gz (bb_asprintf.c) and last_patch54.gz
Manuel Novoa III [Thu, 12 Sep 2002 14:52:26 +0000 (14:52 -0000)]
Apply vodz's last_patch53.gz (bb_asprintf.c) and last_patch54.gz
(arith.c).

22 years agoFix for handling of "tftp -l -" from Jean Wolter <jw5@os.inf.tu-dresden.de>
Eric Andersen [Tue, 10 Sep 2002 06:03:31 +0000 (06:03 -0000)]
Fix for handling of "tftp -l -" from Jean Wolter <jw5@os.inf.tu-dresden.de>

22 years agoYipe. uid and gid were reversed.
Eric Andersen [Tue, 10 Sep 2002 05:23:29 +0000 (05:23 -0000)]
Yipe.  uid and gid were reversed.
 -Erik

22 years agoSome CML1 grammar fixes
Eric Andersen [Sun, 1 Sep 2002 06:45:55 +0000 (06:45 -0000)]
Some CML1 grammar fixes
 -Erik

22 years agoEliminate use of obsolete sys_errlist[]
Eric Andersen [Mon, 26 Aug 2002 21:36:32 +0000 (21:36 -0000)]
Eliminate use of obsolete sys_errlist[]
 -Erik

22 years agochmod on the NEW file
Glenn L McGrath [Mon, 26 Aug 2002 17:17:27 +0000 (17:17 -0000)]
chmod on the NEW file

22 years agoDont return an error if the directory already existed
Glenn L McGrath [Sat, 24 Aug 2002 20:11:38 +0000 (20:11 -0000)]
Dont return an error if the directory already existed

22 years agoFix warning
Glenn L McGrath [Sat, 24 Aug 2002 20:00:52 +0000 (20:00 -0000)]
Fix warning

22 years agoReorganise, make it just one function, remove -v option it didnt work properly anyway...
Glenn L McGrath [Sat, 24 Aug 2002 14:32:17 +0000 (14:32 -0000)]
Reorganise, make it just one function, remove -v option it didnt work properly anyway, dont setvbuf it doesnt make any difference in performance.

22 years agoRun through indent, use braces
Glenn L McGrath [Sat, 24 Aug 2002 10:30:36 +0000 (10:30 -0000)]
Run through indent, use braces

22 years agoRemove extrangeous backslashes that were probably introduced by
Aaron Lehmann [Fri, 23 Aug 2002 22:09:50 +0000 (22:09 -0000)]
Remove extrangeous backslashes that were probably introduced by
someone joining lines and forgetting to remove the backslash escaping
the newline.

22 years agoRewrite, its smaller
Glenn L McGrath [Fri, 23 Aug 2002 17:19:26 +0000 (17:19 -0000)]
Rewrite, its smaller

22 years agoRemove empty loops
Glenn L McGrath [Fri, 23 Aug 2002 14:36:59 +0000 (14:36 -0000)]
Remove empty loops

22 years agoUse static instead of extern, braces around if's, run through indent
Glenn L McGrath [Fri, 23 Aug 2002 14:31:28 +0000 (14:31 -0000)]
Use static instead of extern, braces around if's, run through indent

22 years agoApply vodz last_path_51-2
Glenn L McGrath [Fri, 23 Aug 2002 13:14:48 +0000 (13:14 -0000)]
Apply vodz last_path_51-2

22 years agoApply vodz last_patch51_2 and run through indent
Glenn L McGrath [Fri, 23 Aug 2002 12:04:23 +0000 (12:04 -0000)]
Apply vodz last_patch51_2 and run through indent

22 years agoDon't #ifdef __linux__. this is linux.
Aaron Lehmann [Fri, 23 Aug 2002 07:56:21 +0000 (07:56 -0000)]
Don't #ifdef __linux__. this is linux.

22 years agoansify
Aaron Lehmann [Fri, 23 Aug 2002 07:52:58 +0000 (07:52 -0000)]
ansify

22 years agoremove duplicate definition of G
Aaron Lehmann [Fri, 23 Aug 2002 07:51:01 +0000 (07:51 -0000)]
remove duplicate definition of G
caught by tinycc

22 years agofor some baffling reason tinycc insists that i change this 0 to NULL
Aaron Lehmann [Fri, 23 Aug 2002 07:45:26 +0000 (07:45 -0000)]
for some baffling reason tinycc insists that i change this 0 to NULL

22 years agomove some globals to bss
Aaron Lehmann [Fri, 23 Aug 2002 07:28:45 +0000 (07:28 -0000)]
move some globals to bss

22 years agoRun through indent, style
Glenn L McGrath [Fri, 23 Aug 2002 06:17:46 +0000 (06:17 -0000)]
Run through indent, style

22 years agoRun through indent, fix comments
Glenn L McGrath [Fri, 23 Aug 2002 06:05:11 +0000 (06:05 -0000)]
Run through indent, fix comments

22 years agoRun through indent, fix comments
Glenn L McGrath [Fri, 23 Aug 2002 05:58:38 +0000 (05:58 -0000)]
Run through indent, fix comments

22 years agoRun through indent, specify cast
Glenn L McGrath [Fri, 23 Aug 2002 03:37:07 +0000 (03:37 -0000)]
Run through indent, specify cast

22 years agoRun through indent
Glenn L McGrath [Fri, 23 Aug 2002 03:25:22 +0000 (03:25 -0000)]
Run through indent

22 years agoRemove duplicate definitions, run through indent
Glenn L McGrath [Thu, 22 Aug 2002 19:35:36 +0000 (19:35 -0000)]
Remove duplicate definitions, run through indent

22 years agoreplace some global const ints with defines
Glenn L McGrath [Thu, 22 Aug 2002 19:31:35 +0000 (19:31 -0000)]
replace some global const ints with defines

22 years agoSpecify cast
Glenn L McGrath [Thu, 22 Aug 2002 19:22:32 +0000 (19:22 -0000)]
Specify cast

22 years agoRemove duplicate variable definition
Glenn L McGrath [Thu, 22 Aug 2002 19:15:26 +0000 (19:15 -0000)]
Remove duplicate variable definition

22 years agoRun through indent, fix comments
Glenn L McGrath [Thu, 22 Aug 2002 18:41:20 +0000 (18:41 -0000)]
Run through indent, fix comments

22 years agoRun through indent, fix comment
Glenn L McGrath [Thu, 22 Aug 2002 18:24:43 +0000 (18:24 -0000)]
Run through indent, fix comment

22 years agoRun through indent, fix comments
Glenn L McGrath [Thu, 22 Aug 2002 18:22:10 +0000 (18:22 -0000)]
Run through indent, fix comments

22 years agoRun through indent, fix BB_ define
Glenn L McGrath [Thu, 22 Aug 2002 18:13:54 +0000 (18:13 -0000)]
Run through indent, fix BB_ define

22 years agoRun through ident, fix comments
Glenn L McGrath [Thu, 22 Aug 2002 17:47:09 +0000 (17:47 -0000)]
Run through ident, fix comments

22 years agodefine inline if needed for ANSI C compatability
Glenn L McGrath [Thu, 22 Aug 2002 15:59:18 +0000 (15:59 -0000)]
define inline if needed for ANSI C compatability

22 years agoRemove unwanted comments, run through indent
Glenn L McGrath [Thu, 22 Aug 2002 15:54:22 +0000 (15:54 -0000)]
Remove unwanted comments, run through indent

22 years agoRun through indent, use /* */ style comments, change extern to static
Glenn L McGrath [Thu, 22 Aug 2002 13:44:08 +0000 (13:44 -0000)]
Run through indent, use /* */ style comments, change extern to static

22 years agoRun through indent, use /* */ style comments
Glenn L McGrath [Thu, 22 Aug 2002 13:25:12 +0000 (13:25 -0000)]
Run through indent, use /* */ style comments

22 years agoRun through indent
Glenn L McGrath [Thu, 22 Aug 2002 13:21:26 +0000 (13:21 -0000)]
Run through indent

22 years agoRun through indent, use /* */ style comments instead of //
Glenn L McGrath [Thu, 22 Aug 2002 13:12:40 +0000 (13:12 -0000)]
Run through indent, use /* */ style comments instead of //

22 years agoRemove definition of is_octal and is_decimal, they arent used
Glenn L McGrath [Thu, 22 Aug 2002 12:55:26 +0000 (12:55 -0000)]
Remove definition of is_octal and is_decimal, they arent used

22 years agoHonour the USTAR prefix field, this enables a 155 byte path length plus the normal...
Glenn L McGrath [Thu, 22 Aug 2002 11:50:31 +0000 (11:50 -0000)]
Honour the USTAR prefix field, this enables a 155 byte path length plus the normal 100 byte filename.
The catch is gnu tar cannot create archives that use the prefix field, you need to use s-tar.

22 years agoudhcpc sample scripts
Glenn L McGrath [Wed, 21 Aug 2002 14:24:38 +0000 (14:24 -0000)]
udhcpc sample scripts

22 years agoInline functions with only one reference in mkfs_minix. I don't know
Aaron Lehmann [Wed, 21 Aug 2002 13:21:20 +0000 (13:21 -0000)]
Inline functions with only one reference in mkfs_minix. I don't know
why these efforts aren't making the binary smaller.

22 years agoTar inlining, #if 0 out unused function
Aaron Lehmann [Wed, 21 Aug 2002 13:11:34 +0000 (13:11 -0000)]
Tar inlining, #if 0 out unused function

22 years agovi inlining
Aaron Lehmann [Wed, 21 Aug 2002 13:02:24 +0000 (13:02 -0000)]
vi inlining

22 years agoCleanups. These SHOULD make the binary a lot smaller. But they don't.
Aaron Lehmann [Wed, 21 Aug 2002 12:44:54 +0000 (12:44 -0000)]
Cleanups. These SHOULD make the binary a lot smaller. But they don't.
CURSE GCC

22 years agoDisable debugging
Glenn L McGrath [Wed, 21 Aug 2002 11:44:31 +0000 (11:44 -0000)]
Disable debugging

22 years agoClean up udhcpd a bit. Constify. Staticize. Remove these functions and
Aaron Lehmann [Wed, 21 Aug 2002 11:21:19 +0000 (11:21 -0000)]
Clean up udhcpd a bit. Constify. Staticize. Remove these functions and
inline their contents: print_usage, pidfile_delete, and background.

22 years agoNew applet, udhcp client
Glenn L McGrath [Wed, 21 Aug 2002 10:27:58 +0000 (10:27 -0000)]
New applet, udhcp client

22 years agoFix dietlibc test condition
Glenn L McGrath [Thu, 15 Aug 2002 03:29:56 +0000 (03:29 -0000)]
Fix dietlibc test condition

22 years agoTry to be a bit more dietlibc friendly
Eric Andersen [Tue, 13 Aug 2002 09:57:44 +0000 (09:57 -0000)]
Try to be a bit more dietlibc friendly

22 years agoEnable support for the old tar header format, enable via menu's
Glenn L McGrath [Tue, 13 Aug 2002 05:06:43 +0000 (05:06 -0000)]
Enable support for the old tar header format, enable via menu's

22 years agominor fixes for fbset bloat
Aaron Lehmann [Tue, 13 Aug 2002 04:19:23 +0000 (04:19 -0000)]
minor fixes for fbset bloat

<mjn3>         printf("\tgeometry %u %u %u %u %u\n", v->xres, v->yres,
<mjn3>                    v->xres_virtual, v->yres_virtual, v->bits_per_pixel);
<mjn3>         printf("\ttimings %u %u %u %u %u %u %u\n", v->pixclock, v->left_margin,
<mjn3>                    v->right_margin, v->upper_margin, v->lower_margin, v->hsync_l
<mjn3> en,
<mjn3>                    v->vsync_len);
<mjn3>         printf("\taccel %s\n", (v->accel_flags > 0 ? "true" : "false"));
<mjn3>         printf("\trgba %u/%u,%u/%u,%u/%u,%u/%u\n", v->red.length,
<mjn3>                    v->red.offset, v->green.length, v->green.offset, v->blue.leng
<mjn3> th,
<mjn3>                    v->blue.offset, v->transp.length, v->transp.offset);
<mjn3>         printf("endmode\n\n");
<mjn3> whay have multiple printf calls when one would do?

<mjn3> and this:
<mjn3> static struct cmdoptions_t {
<mjn3>         char *name;
<mjn3>         unsigned char param_count;
<mjn3>         unsigned char code;
<mjn3> } g_cmdoptions[] = {
<mjn3>         {
<mjn3>         "-fb", 1, CMD_FB}, {
<mjn3> (repeated entries)
<mjn3> why isn't this constant?  what about struct packing?

inline the helper functions that are only referenced once.

22 years agoAdded Familiar Linux to the projects list
Robert Griebl [Fri, 9 Aug 2002 22:54:39 +0000 (22:54 -0000)]
Added Familiar Linux to the projects list

22 years agoPatch from Rusell Nelson to document the -C switch for syslogd
Robert Griebl [Wed, 7 Aug 2002 21:24:33 +0000 (21:24 -0000)]
Patch from Rusell Nelson to document the -C switch for syslogd

22 years agoAdded a help text for the -C option to syslogd
Robert Griebl [Wed, 7 Aug 2002 21:10:19 +0000 (21:10 -0000)]
Added a help text for the -C option to syslogd

22 years agoSomehow I applied an old patch for the last commit - this one works now:
Robert Griebl [Tue, 6 Aug 2002 23:13:31 +0000 (23:13 -0000)]
Somehow I applied an old patch for the last commit - this one works now:
- Added \CregexC support to sed (sed testsuite reported no errors, btw)

22 years agoAdded the \CregexpC syntax as an alternative for /regexp/ (like GNU sed)
Robert Griebl [Tue, 6 Aug 2002 21:07:17 +0000 (21:07 -0000)]
Added the \CregexpC syntax as an alternative for /regexp/ (like GNU sed)

22 years agoFix silly typo. addgroup was using /etc/shadow for /etc/gshadow.
Manuel Novoa III [Tue, 6 Aug 2002 20:39:23 +0000 (20:39 -0000)]
Fix silly typo.  addgroup was using /etc/shadow for /etc/gshadow.

22 years agoMove #define MAXLINE so this compiles without circ buffers.
Manuel Novoa III [Tue, 6 Aug 2002 20:12:56 +0000 (20:12 -0000)]
Move #define MAXLINE so this compiles without circ buffers.

22 years agoOops. Code things so it actually works this time around...
Eric Andersen [Mon, 5 Aug 2002 11:56:25 +0000 (11:56 -0000)]
Oops.  Code things so it actually works this time around...
 -Erik

22 years agoJoel Coltoff <joel@wmi.com> noticed that following a recent
Eric Andersen [Mon, 5 Aug 2002 11:14:30 +0000 (11:14 -0000)]
Joel Coltoff <joel@wmi.com> noticed that following a recent
change in uClibc that changed opening the /dev/log socket as
SOCK_STREAM to SOCK_DGRAM, busybox syslogd no longer worked
since it needed a matching change.  This fixes it so it
works once again.

22 years ago- updated a few copyright/left file headers
Robert Griebl [Mon, 5 Aug 2002 02:57:12 +0000 (02:57 -0000)]
- updated a few copyright/left file headers
- documented most of my 0.61 changes in the ChangeLog

22 years agoFixed a bug in xarg: string data was strcat'ed to a malloc'ed buffer - and
Robert Griebl [Sat, 3 Aug 2002 14:49:03 +0000 (14:49 -0000)]
Fixed a bug in xarg: string data was strcat'ed to a malloc'ed buffer - and
malloc does not clear memory by default (somehow this worked on x86, but
not on arm)

22 years agoRemove ckfree, and replace all references with free. Remove freefunc,
Aaron Lehmann [Fri, 2 Aug 2002 06:39:47 +0000 (06:39 -0000)]
Remove ckfree, and replace all references with free. Remove freefunc,
which is also equivilent to free. Remove some if(x)free(x)
redundancies.

22 years agoJoseph Chiu <josephc@idealab.com> found an off-by-one bug. oops!
Eric Andersen [Thu, 1 Aug 2002 01:31:17 +0000 (01:31 -0000)]
Joseph Chiu <josephc@idealab.com> found an off-by-one bug.  oops!

22 years agoApplied a patch from Philip Blundell <pb@nexus.co.uk>:
Robert Griebl [Wed, 31 Jul 2002 21:22:21 +0000 (21:22 -0000)]
Applied a patch from Philip Blundell <pb@nexus.co.uk>:
Added support for ":x" as an alias for ":wq" to vi

22 years agoA couple of small bugfixes from Marshall M. Midden <m4@brecis.com>
Eric Andersen [Wed, 31 Jul 2002 04:04:47 +0000 (04:04 -0000)]
A couple of small bugfixes from Marshall M. Midden <m4@brecis.com>

22 years agoBe more portable with 'find' for those that prefer programming
Eric Andersen [Wed, 31 Jul 2002 03:45:05 +0000 (03:45 -0000)]
Be more portable with 'find' for those that prefer programming
on *BSD, etc.  Formatting fixes, etc.

22 years agoFixed a timing bug which occured when bb ash is run in a rxvt on the
Robert Griebl [Tue, 30 Jul 2002 23:13:51 +0000 (23:13 -0000)]
Fixed a timing bug which occured when bb ash is run in a rxvt on the
HP iPAQ. Sometimes we get a SIGWINCH and want to print the prompt, although
the prompt is not yet initialised (0) .. so just don't print a prompt
as long as the prompt string is 0

22 years agoAdded the -I (isofmt) options to date, which comes in handy for scripts
Robert Griebl [Tue, 30 Jul 2002 23:11:00 +0000 (23:11 -0000)]
Added the -I (isofmt) options to date, which comes in handy for scripts
(this is a confiureable option)

22 years agoFixed a bug that I had introduced with the new "options" handling.
Robert Griebl [Mon, 29 Jul 2002 20:28:38 +0000 (20:28 -0000)]
Fixed a bug that I had introduced with the new "options" handling.

22 years agoKill a silly warning
Eric Andersen [Mon, 29 Jul 2002 08:00:16 +0000 (08:00 -0000)]
Kill a silly warning

22 years agoPatch from Tim Riker to allow tty* in inittab if the tty
Eric Andersen [Mon, 29 Jul 2002 06:39:58 +0000 (06:39 -0000)]
Patch from Tim Riker to allow tty* in inittab if the tty
actually exists -- serial console is not the issue...

22 years agomodprobe now also uses "options" from /etc/modules.conf
Robert Griebl [Fri, 26 Jul 2002 15:54:20 +0000 (15:54 -0000)]
modprobe now also uses "options" from /etc/modules.conf

22 years agoFix for bug #1255 -- support for mount -t <type>
Robert Griebl [Thu, 25 Jul 2002 14:17:19 +0000 (14:17 -0000)]
Fix for bug #1255 -- support for mount -t <type>

22 years agoAdd support for /etc/filesystem when searching for an "auto" filesystem
Robert Griebl [Wed, 24 Jul 2002 01:41:30 +0000 (01:41 -0000)]
Add support for /etc/filesystem when searching for an "auto" filesystem
This is bug #1246

22 years agoCommited patch from bug #1182
Robert Griebl [Wed, 24 Jul 2002 00:56:56 +0000 (00:56 -0000)]
Commited patch from bug #1182
Although ssrat@mailbag.com says this is not GNU behaviour, it really *is*
(man nslookup)

22 years agoPatch for bug #1183: Added a -xdev option to find (configurable)
Robert Griebl [Wed, 24 Jul 2002 00:34:48 +0000 (00:34 -0000)]
Patch for bug #1183: Added a -xdev option to find (configurable)

22 years agoFix indentation. Support killall -q, for pcmcia-cs
Eric Andersen [Tue, 23 Jul 2002 23:45:11 +0000 (23:45 -0000)]
Fix indentation.  Support killall -q, for pcmcia-cs
 -Erik

22 years agoAdded tar -cz support (creating gzipped tar files without a gzip pipe)
Robert Griebl [Tue, 23 Jul 2002 22:05:47 +0000 (22:05 -0000)]
Added tar -cz support (creating gzipped tar files without a gzip pipe)

22 years agoFixed two compiler warnings
Robert Griebl [Sun, 21 Jul 2002 17:33:27 +0000 (17:33 -0000)]
Fixed two compiler warnings

22 years agoInitial checkin of a very primitive hwclock replacement
Robert Griebl [Sun, 21 Jul 2002 16:50:49 +0000 (16:50 -0000)]
Initial checkin of a very primitive hwclock replacement

22 years agoApplied syslogd fix submitted by Bart Visscher:
Robert Griebl [Fri, 19 Jul 2002 20:52:21 +0000 (20:52 -0000)]
Applied syslogd fix submitted by Bart Visscher:
I am using BB 0.60.2 in a floppy distro, and the syslog (and logger) is
unable to log the "<" char.  This shows up in ppp logfiles.  [...]
#logger "<pcomp>" results in "comp>" arriving at the log.

22 years ago- Forgot to cvs add bb_asprintf.c (from vodz' patch #50)
Robert Griebl [Fri, 19 Jul 2002 20:27:11 +0000 (20:27 -0000)]
- Forgot to cvs add bb_asprintf.c (from vodz' patch #50)
- Applied Joel Coltoff's xconnect patch:
On both my host system and with mipsel-linux for my embedded systems
the function getservbyname() gives the port number already in host order.
In fact, this is how it was used by rdate in version 0.60.3. The snapshot
I have of the development tree from July 12, 2002 takes the port number
and stuffs it into htons() before it uses it. This causes bugs in rdate,
telnet and wget. This patch fixes that.

22 years agoApplied vodz' patches #49 and #50 (with a small correction in runshell.c)
Robert Griebl [Fri, 19 Jul 2002 00:05:54 +0000 (00:05 -0000)]
Applied vodz' patches #49 and #50 (with a small correction in runshell.c)

#49: I found one memory overflow and memory leak in "ln" applet.
Last patch reduced also 54 bytes. ;)

#50: I found bug in loginutils/Makefile.in.
New patch have also new function to libbb and
aplied this to applets and other cosmetic changes.

22 years agoAdded a compile time option to suppress the "Using fallback.." message
Robert Griebl [Thu, 18 Jul 2002 23:59:17 +0000 (23:59 -0000)]
Added a compile time option to suppress the "Using fallback.." message
if no busybox.conf file is existant.

22 years agoFix for the totally broken adduser applet (parts/ideas from vodz and tito)
Robert Griebl [Tue, 16 Jul 2002 23:50:05 +0000 (23:50 -0000)]
Fix for the totally broken adduser applet (parts/ideas from vodz and tito)

22 years agoDon't treat a non-existant/-readable config file as an empty config, but
Robert Griebl [Tue, 16 Jul 2002 21:53:59 +0000 (21:53 -0000)]
Don't treat a non-existant/-readable config file as an empty config, but
use the compiled in _BB_SUID_* flags (same as for parse errors)

22 years agoDoh!
Eric Andersen [Sun, 14 Jul 2002 15:39:05 +0000 (15:39 -0000)]
Doh!

22 years agoBetter clarify the CVS tree situation
Eric Andersen [Sat, 13 Jul 2002 06:24:58 +0000 (06:24 -0000)]
Better clarify the CVS tree situation
 -Erik

22 years agoTry to be more clear about the current two-CVS-trees
Eric Andersen [Sat, 13 Jul 2002 06:08:39 +0000 (06:08 -0000)]
Try to be more clear about the current two-CVS-trees
situation.
 -Erik

22 years agoAccept the --passive-ftp cmd.line option. We always use passive ftp mode,
Robert Griebl [Fri, 12 Jul 2002 00:04:46 +0000 (00:04 -0000)]
Accept the --passive-ftp cmd.line option. We always use passive ftp mode,
so it doesn't hurt (adds compatibility though)

22 years agoFixup warnings and undefined operations that show up in gcc-3.1
Eric Andersen [Thu, 11 Jul 2002 11:11:56 +0000 (11:11 -0000)]
Fixup warnings and undefined operations that show up in gcc-3.1
 -Erik

22 years agoBrad Campbell <brad@seme.com.au> notes that
Eric Andersen [Thu, 11 Jul 2002 10:40:43 +0000 (10:40 -0000)]
Brad Campbell <brad@seme.com.au> notes that
xconnect.c needs #include <netinet/in.h>
to compile if CONFIG_FEATURE_IPV6 is not defined

22 years agoSome minor bits of scrubbing
Eric Andersen [Mon, 8 Jul 2002 01:40:02 +0000 (01:40 -0000)]
Some minor bits of scrubbing

22 years agoPatch from Stewart Brodie <stewart.brodie@pace.co.uk> to fix ash:
Eric Andersen [Thu, 4 Jul 2002 00:19:46 +0000 (00:19 -0000)]
Patch from Stewart Brodie <stewart.brodie@pace.co.uk> to fix ash:

When alias support is not configured, ash believes that command parameters
that look like dd's "if=/dev/zero" are requests to set a temporary
environment variable whilst dd is running, even though it appears after the
command name.  This is caused by the re-use of the checkalias global variable
to indicate when both alias checking and environment variable checking.  The
failure to reset this flag is due to the reset action being performed only
inside the feature check CHECK_ASH_ALIAS.  Hence ash works as expected when
aliases are configured in, and fails when not.

Example script using 'date' with different settings of TZ:

# TZ=Europe/London
# export TZ
# date
Thu May 30 17:18:49 BST 2002
# TZ=America/New_York date
Thu May 30 12:19:10 EDT 2002
# date
Thu May 30 17:19:12 BST 2002
# date TZ=America/New_York
Thu May 30 12:19:30 EDT 2002    <----- wrong, should be BST time (or error!)
# date
Thu May 30 17:19:35 BST 2002

Attached is a patch against revision 1.52 of ash.c which moves the checks so
that checkalias is updated regardless of whether CONFIG_ASH_ALIAS is set.
With this patch applied, the command shown above which should generate an
error does generate an error.

I have tested this patch with the 'dd' command too and that now works
correctly.