oweals/cde.git
12 years agodtfile: Add missing prototypes
Marcin Cieslak [Tue, 18 Sep 2012 02:02:28 +0000 (04:02 +0200)]
dtfile: Add missing prototypes

Add missing prototypes and header files to the dtfile
code in order to move closer towards 64-bit compatibility.

Extract the following functions from Motif internal headers:

_XmGetWidgetExtData
_XmRecordEvent
_XmStringUngenerate
_XmTextFieldSetDestination
_XmGetActiveTopLevelMenu

Extract manually prototypes of the obsolete Motif interface:
_XmHighlightBorder
_XmUnhighlightBorder

Remove XmPrivate.h if extractprototype.awk fails

Make the following header files available via -I:
codelibs/boolean.h
codelibs/pathutils.h
codelibs/shellutils.h
and remove shellutils.h from dtwm directory.

12 years agoCDE-MAN.udb: add /usr/dt/man symlink for linux, like freebsd
Jon Trulson [Tue, 18 Sep 2012 00:26:14 +0000 (18:26 -0600)]
CDE-MAN.udb: add /usr/dt/man symlink for linux, like freebsd

12 years agoMerge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Jon Trulson [Tue, 18 Sep 2012 00:23:31 +0000 (18:23 -0600)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code

12 years agoImprove MANPATH control
Marcin Cieslak [Mon, 17 Sep 2012 10:45:40 +0000 (12:45 +0200)]
Improve MANPATH control

* Revert changes to programs/dtsearchpath/libCliSrv/UnixEnv.C
  introduced by c3cb5b8aa6997138dfa06da39142bf793baeae60
  that could have produced disappearing Application Manager
  icons on FreeBSD
* Introduce SearchPath:useSystemPath() virtual method to tell
  dtsearchpath to leave some environment variables alone.

  It is currently overriden for FreeBSD only if the MANPATH
  is empty (system default). Other operating systems
  might want to override it if they prefer to have distribution
  specific control of a search path in effect.

* Symlink /usr/dt/share/man to /usr/dt/man for FreeBSD
  This allows dtsearchpath to actually include /usr/dt/man
  in the MANPATH when MANPATH override is in effect.

12 years agodtstyle: Resolve 28 compiler warnings.
Peter Howkins [Mon, 17 Sep 2012 13:56:06 +0000 (14:56 +0100)]
dtstyle: Resolve 28 compiler warnings.

12 years agoBSD: Add /usr/local/bin to the default PATH on login
Marcin Cieslak [Mon, 10 Sep 2012 02:38:04 +0000 (04:38 +0200)]
BSD: Add /usr/local/bin to the default PATH on login

12 years agoFreeBSD: Don't set MANPATH, use OS configuration
Marcin Cieslak [Mon, 10 Sep 2012 02:21:16 +0000 (04:21 +0200)]
FreeBSD: Don't set MANPATH, use OS configuration

- make installer to set up man(1) paths using /usr/local/etc/man.d/*
- don't override empty/unset MANPATH with compiled in default

12 years agoDon't use fstat for readable pipe chars in dtexec.
Mike Stroyan [Sun, 9 Sep 2012 21:44:45 +0000 (15:44 -0600)]
Don't use fstat for readable pipe chars in dtexec.

The dtexec code assumes that fstat reports pipe's readable chars.
Linux always reports 0 for st_size of a pipe.
Instead read one character when select reports readable.
Note EOF when select says readable but read returns 0.

12 years agoFreeBSD: Fix dtlogin failsafe session
Marcin Cieslak [Fri, 7 Sep 2012 21:04:44 +0000 (23:04 +0200)]
FreeBSD: Fix dtlogin failsafe session

We need to have /usr/local as the proper
X11 prefix to start mwm and xterm

12 years agoadd HISTORY file 2.2.0b
Jon Trulson [Thu, 6 Sep 2012 19:33:58 +0000 (13:33 -0600)]
add HISTORY file

12 years agodtlogin: enable building on FreeBSD
Jon Trulson [Thu, 6 Sep 2012 18:36:14 +0000 (12:36 -0600)]
dtlogin: enable building on FreeBSD

12 years agoUpdate README file
Jon Trulson [Thu, 6 Sep 2012 18:12:15 +0000 (12:12 -0600)]
Update README file

12 years agoAllow building on FreeBSD
Marcin Cieslak [Thu, 6 Sep 2012 11:45:11 +0000 (13:45 +0200)]
Allow building on FreeBSD

- build shared libraries with major number only (libtt.so.2)
- don't build dtlogin and dtinfo

FreeBSD support for the installer:
- work around awk issue
- create post_install FreeBSD scripts
- install only cmsd on /etc/inetd.conf
  skip dtspc and ttdbserver for now

Note to users: please check
if you are affected by awk bug
in udbParseLib.awk if you can.

12 years agoUpdate CONTRIBUTORS file.
Jon Trulson [Thu, 6 Sep 2012 01:38:24 +0000 (19:38 -0600)]
Update CONTRIBUTORS file.

12 years agoFix for __va_copy on FreeBSD i386.
Ulrich Wilkens [Wed, 5 Sep 2012 14:49:35 +0000 (16:49 +0200)]
Fix for __va_copy on FreeBSD i386.

12 years agoFixes for dtlogin and dtcm on FreeBSD.
Ulrich Wilkens [Wed, 5 Sep 2012 14:26:28 +0000 (16:26 +0200)]
Fixes for dtlogin and dtcm on FreeBSD.

12 years agolinux.cf: add libtirpc support. Disabled by default.
Jon Trulson [Tue, 4 Sep 2012 01:50:10 +0000 (19:50 -0600)]
linux.cf: add libtirpc support.  Disabled by default.

Currently on Linux, you must run rpcbind in insecure mode (-i) in
order for ttsession to register with rpcbind (the portmapper).  This
is because, on most systems, libc contains an older sun-based rpc
library embedded within it.  The sun-rpc code does not know how to
authenticate with rpcbind when run as a non-privileged user.

Using libtirpc, ttsession can register with rpcbind without requiring
it to be run in insecure mode.  You must have the libtirpc-dev, or
equivalent package installed to use it.

If you want to try this:

- install libtirpc-dev or equivalent
- if your rpcbind process is already running in insecure mode (-i
  option), remove that option and restart it.
- edit config/host.def, (create if it doesn't exist) and add:

  #define HasTIRPCLib  YES

- rebuild CDE (make World).  It's probably a good idea to remove
  /usr/dt/* beforehand to avoid contamination.

Some linux systems seem to incorporate tirpc directly into libc (as
all of the BSD's do AFAIK) so this may not be needed.

I know that at least on Ubuntu systems defining HasTIRPCLib to YES is
required in order to run rpcbind without -i.

12 years agomessage catalogs: fix comment lines, also remove linux hack in merge.c
Jon Trulson [Mon, 3 Sep 2012 21:12:57 +0000 (15:12 -0600)]
message catalogs: fix comment lines, also remove linux hack in merge.c

According to the spec, blank lines in message catalogs or lines
beginning with '$ ' are valid comments.

However, there were many cases where lines in the message catalogs
contained just a single '$', without the required space after it.

Under linux, this caused 126766 error lines (in my builds) of the
form:

... unknown directive `': line ignored

This also causes gencat to exit with a non-0 exit code.  Even though
gencat says it ignores the line, it really doesn't.

An early porting change to programs/localized/util/merge.c was made to
ignore this return value on linux.  This hack has now been removed.

Build logs are a lot smaller and cleaner now.

12 years agolibDtSvc: Resolve 89 compiler warnings.
Peter Howkins [Sat, 1 Sep 2012 20:35:10 +0000 (21:35 +0100)]
libDtSvc: Resolve 89 compiler warnings.

12 years agolibDtSearch: Resolve 26 compiler warnings.
Peter Howkins [Sat, 1 Sep 2012 19:54:23 +0000 (20:54 +0100)]
libDtSearch: Resolve 26 compiler warnings.

12 years agodtpdmd: Resolving warnings.
Peter Howkins [Sat, 1 Sep 2012 19:37:02 +0000 (20:37 +0100)]
dtpdmd: Resolving warnings.

12 years agoMerge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Peter Howkins [Sat, 1 Sep 2012 17:30:13 +0000 (18:30 +0100)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code

12 years agoinstallCDE: remove \c from installing... Log lines
Jon Trulson [Sat, 1 Sep 2012 01:57:29 +0000 (19:57 -0600)]
installCDE: remove \c from installing... Log lines

12 years agolinux.cf: add some gcc system include paths to makedepend. Shaves about 5150 more...
Jon Trulson [Fri, 31 Aug 2012 22:31:26 +0000 (16:31 -0600)]
linux.cf: add some gcc system include paths to makedepend.  Shaves about 5150 more warnings off (makedepend) :)

This is on ubuntu.  You may wany to add additional -I... entries for
other linux systems, if the ones I added for i386 and x86_64 don't
help.

12 years agodtpdm: Resolve 4 compiler warnings
Peter Howkins [Fri, 31 Aug 2012 20:41:32 +0000 (21:41 +0100)]
dtpdm: Resolve 4 compiler warnings

12 years agobuild: linux.cf, remove the space in the -isystem include of the X11 headers
Peter Howkins [Fri, 31 Aug 2012 18:07:47 +0000 (19:07 +0100)]
build: linux.cf, remove the space in the -isystem include of the X11 headers

this was causing build failures on the make depend step.

12 years agobuild: on linux include the X11 and Xm headers with -isystem rather than -I,
Peter Howkins [Fri, 31 Aug 2012 17:35:20 +0000 (18:35 +0100)]
build: on linux include the X11 and Xm headers with -isystem rather than -I,
this means the compiler treats them as system headers and does not give you
excessive warnings from them. This is used because X11 does not like the
-ansi and -pedantic warnings that CDE is compiled with.

12 years agoinclude: remove includes:: XmPrivate.h from includes Imakefile
Jon Trulson [Fri, 31 Aug 2012 02:23:33 +0000 (20:23 -0600)]
include: remove includes:: XmPrivate.h from includes Imakefile

Having this dependancy in here is a problem.  Depending on how the src
is packaged, or, unpacked, an attempt could be made to regenerate this
file, which cannot succeed unless imports/motif is setup to point to a
compiled motif tree.

This file can be manually regenerated by removing XmPrivate.h, and then
doing a 'make XmPrivate.h' in the include/Xm dir.

12 years agodthelp: fix build failure introduced by commit 71f8af6943b9f0ea6d290c1497bf1b3a78be18c0
Jon Trulson [Fri, 31 Aug 2012 02:22:04 +0000 (20:22 -0600)]
dthelp: fix build failure introduced by commit 71f8af6943b9f0ea6d290c1497bf1b3a78be18c0

Tsk Tsk Peter :)

12 years agodtcm: fix typo introduced by commit ca9da25d44b258d8ca933808d24668cddd727449
Jon Trulson [Fri, 31 Aug 2012 02:19:23 +0000 (20:19 -0600)]
dtcm: fix typo introduced by commit ca9da25d44b258d8ca933808d24668cddd727449

12 years agoDtWidget: Improve portability of Motif interface
Marcin Cieslak [Thu, 30 Aug 2012 23:17:48 +0000 (01:17 +0200)]
DtWidget: Improve portability of Motif interface

- Add missing includes and prototypes
- Improve type compatibility
- Use <Xm/XmPrivate.h> for unofficial libXm headers

With this patch, dtpad no longer crashes on startup
on FreeBSD/amd64 because of a truncated 64-bit pointer.

12 years agoFix warnings in dtwm
Marcin Cieslak [Thu, 30 Aug 2012 23:17:47 +0000 (01:17 +0200)]
Fix warnings in dtwm

- Improve pointer/int compatibility
- Include unpublished Dt headers in Dt
- Use <Xm/XmPrivate.h> for unpublished Motif functions

There are still warnings left generated because
ElementValue.parsed_value should really be a union.

There are also some warnings left because of XtPointer
casting and some unused variables and functions.

12 years agoIntroduce <Xm/XmPrivate.h>
Marcin Cieslak [Thu, 30 Aug 2012 23:17:46 +0000 (01:17 +0200)]
Introduce <Xm/XmPrivate.h>

We need ANSI C prototypes of certain Motif
functions that are not published in the official
header files.

<Xm/XmPrivate.h> header file contains
the prototypes extracted from the Motif source.

To re-create <Xm/XmPrivate.h>:

1) Make sure you have sources of libXm
(lib/Xm directory of the Motif distribution)
accessible via imports/motif/lib/Xm

2) rm include/Xm/XmPrivate.h

3) make includes

12 years agodtpad: Resolve 6 compiler warnings.
Peter Howkins [Thu, 30 Aug 2012 21:40:55 +0000 (22:40 +0100)]
dtpad: Resolve 6 compiler warnings.

12 years agodtlogin: Resolve 7 compiler warnings.
Peter Howkins [Thu, 30 Aug 2012 21:30:36 +0000 (22:30 +0100)]
dtlogin: Resolve 7 compiler warnings.

12 years agodtlogin: Resolve all -Wformat-security warnings
Peter Howkins [Thu, 30 Aug 2012 21:19:49 +0000 (22:19 +0100)]
dtlogin: Resolve all -Wformat-security warnings

12 years agodtimsstart: Resolve 3 compiler warnings.
Peter Howkins [Thu, 30 Aug 2012 21:15:13 +0000 (22:15 +0100)]
dtimsstart: Resolve 3 compiler warnings.

12 years agoMerge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Peter Howkins [Thu, 30 Aug 2012 20:38:11 +0000 (21:38 +0100)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code

12 years agodthelp: Resolve 106 compiler warnings.
Peter Howkins [Thu, 30 Aug 2012 20:37:25 +0000 (21:37 +0100)]
dthelp: Resolve 106 compiler warnings.

12 years agoDefine AMD64Architecture for FreeBSD
Marcin Cieslak [Thu, 30 Aug 2012 20:27:15 +0000 (22:27 +0200)]
Define AMD64Architecture for FreeBSD

12 years agoRudimentary LSBBitOrder for FreeBSD
Marcin Cieslak [Thu, 30 Aug 2012 19:57:07 +0000 (21:57 +0200)]
Rudimentary LSBBitOrder for FreeBSD

12 years agoMerge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Jon Trulson [Thu, 30 Aug 2012 19:53:37 +0000 (13:53 -0600)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code

12 years agodthello: Resolve 5 compiler warnings.
Peter Howkins [Thu, 30 Aug 2012 18:57:56 +0000 (19:57 +0100)]
dthello: Resolve 5 compiler warnings.

12 years agodtfile: Remove 97 compiler warnings
Peter Howkins [Thu, 30 Aug 2012 18:54:01 +0000 (19:54 +0100)]
dtfile: Remove 97 compiler warnings

12 years agodthelp/text.c: use snprintf
Jon Trulson [Thu, 30 Aug 2012 18:44:50 +0000 (12:44 -0600)]
dthelp/text.c: use snprintf

12 years agodtfile: Resolve implicit imcompatible declaration warnings.
Peter Howkins [Thu, 30 Aug 2012 17:25:49 +0000 (18:25 +0100)]
dtfile: Resolve implicit imcompatible declaration warnings.

12 years agodtexec: On Linux use the variation of signal handlers that takes an int arg
Peter Howkins [Thu, 30 Aug 2012 17:18:20 +0000 (18:18 +0100)]
dtexec: On Linux use the variation of signal handlers that takes an int arg

Warning Prevention.

12 years agodtdspmsg: Warning prevention
Peter Howkins [Thu, 30 Aug 2012 17:14:15 +0000 (18:14 +0100)]
dtdspmsg: Warning prevention

12 years agodtcreate: warning prevention.
Peter Howkins [Thu, 30 Aug 2012 17:07:16 +0000 (18:07 +0100)]
dtcreate: warning prevention.

12 years agodsdm: Include ansi C headers to prevent implicit incompatible declaration warnings.
Peter Howkins [Thu, 30 Aug 2012 16:59:34 +0000 (17:59 +0100)]
dsdm: Include ansi C headers to prevent implicit incompatible declaration warnings.

12 years agodtaction: main() returns an int and -Wformat-security fixes
Peter Howkins [Thu, 30 Aug 2012 16:55:43 +0000 (17:55 +0100)]
dtaction: main() returns an int and -Wformat-security fixes

12 years agodticon: Fix some warnings related to mixing NULL, 0 and '\0' randomly.
Peter Howkins [Thu, 30 Aug 2012 16:48:26 +0000 (17:48 +0100)]
dticon: Fix some warnings related to mixing NULL, 0 and '\0' randomly.

12 years agodtcalc: Fix some warnings related to mixing NULL, 0 and '\0' randomly.
Peter Howkins [Thu, 30 Aug 2012 15:45:52 +0000 (16:45 +0100)]
dtcalc: Fix some warnings related to mixing NULL, 0 and '\0' randomly.

12 years agoTwo fixes for dtmail
Ulrich Wilkens [Thu, 30 Aug 2012 01:09:48 +0000 (03:09 +0200)]
Two fixes for dtmail

12 years agoCorrection of paths for BSDs
Ulrich Wilkens [Thu, 30 Aug 2012 00:12:16 +0000 (02:12 +0200)]
Correction of paths for BSDs

12 years agodtcm: Resolve all -Wformat-security warnings.
Peter Howkins [Wed, 29 Aug 2012 19:16:01 +0000 (20:16 +0100)]
dtcm: Resolve all -Wformat-security warnings.

12 years agodtsr: include stdlib.h to resolve 20 incompaible implicit declaration warnings.
Peter Howkins [Wed, 29 Aug 2012 17:25:32 +0000 (18:25 +0100)]
dtsr: include stdlib.h to resolve 20 incompaible implicit declaration warnings.

12 years agodtsr: Resolve all -Wformat-security warnings.
Peter Howkins [Wed, 29 Aug 2012 17:21:05 +0000 (18:21 +0100)]
dtsr: Resolve all -Wformat-security warnings.

12 years agoutil/dttypes: Resolve -Wformat-security warnings
Peter Howkins [Wed, 29 Aug 2012 17:02:22 +0000 (18:02 +0100)]
util/dttypes: Resolve -Wformat-security warnings

12 years agodtterm: Resolve -Wformat-security warnings
Peter Howkins [Wed, 29 Aug 2012 15:13:22 +0000 (16:13 +0100)]
dtterm: Resolve -Wformat-security warnings

12 years agolibDtTerm: Resolve all -Wformat-security warnings.
Peter Howkins [Mon, 27 Aug 2012 19:36:59 +0000 (20:36 +0100)]
libDtTerm: Resolve all -Wformat-security warnings.

12 years agoMerge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Peter Howkins [Mon, 27 Aug 2012 19:25:14 +0000 (20:25 +0100)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code

12 years agolibDtSearch: resolve -Wformat-secuirty warning
Peter Howkins [Mon, 27 Aug 2012 19:24:06 +0000 (20:24 +0100)]
libDtSearch: resolve -Wformat-secuirty warning

12 years agoAdd pax files generated by dtksh to .gitignore
Marcin Cieslak [Fri, 24 Aug 2012 08:24:53 +0000 (10:24 +0200)]
Add pax files generated by dtksh to .gitignore

It seems that after changing -O2 to -O for FreeBSD
pax started to build successfully. Interesting.

12 years agolibtt: Resolve all remaining format-security warnings.
Peter Howkins [Sun, 26 Aug 2012 21:19:27 +0000 (22:19 +0100)]
libtt: Resolve all remaining format-security warnings.

12 years agolibtt: Warning prevention
Peter Howkins [Sun, 26 Aug 2012 18:48:55 +0000 (19:48 +0100)]
libtt: Warning prevention

One missing stdlib include and one security warning about not
using varargs func correctly.

12 years agoAdd missing includes [for modern systems] to lndir.c
David Cantrell [Thu, 23 Aug 2012 20:58:20 +0000 (16:58 -0400)]
Add missing includes [for modern systems] to lndir.c

12 years agoFix udbParseLib.awk so it doesn't generate warnings with gawk.
David Cantrell [Thu, 23 Aug 2012 19:52:06 +0000 (15:52 -0400)]
Fix udbParseLib.awk so it doesn't generate warnings with gawk.

Tested this change with both gawk and nawk and it worked fine.  If
the extra escape character is present and gawk is used, you'll get
warnings from gawk telling you it's ignoring the escape sequence
and just treating it as the character to begin with.

12 years agoFreeBSD: Use -O instead of -O2
Marcin Cieslak [Thu, 23 Aug 2012 21:09:43 +0000 (23:09 +0200)]
FreeBSD: Use -O instead of -O2

12 years agoUse KORNSHELL variable instead of /bin/ksh
Marcin Cieslak [Thu, 23 Aug 2012 15:49:26 +0000 (17:49 +0200)]
Use KORNSHELL variable instead of /bin/ksh

This patch removes instances of hardcoded
invocation of /bin/ksh and allows to
replace it with, for, example,
/usr/local/bin/ksh93

Also "ksh93" is accepted whenever "ksh" is.

Tested using the following /bin/ksh:

----8<----
WHAT=`ps -o command= -p $PPID`
msg="Something tried to call /bin/ksh: $PPID: $WHAT"
print -u2 "$msg"
logger user.warn "$msg"
exit 99
----8<----
(Warning: first two lines are FreeBSD specific)

Scripts from Makefiles should now be executed either
with

$(KORNSHELL) korn-shell-script

or

$(SHELL) bourne-shell-script

therefore #!/bin/ksh has not been changed everywhere.

/usr/dt/bin/ scripts have been converted (e.g. Xsession)

Whenever possible Imake and CPP facilities have been used.

For C and C++ programs KORNSHELL needs to be defined to
"/path/to/your/ksh" (with quotes) so that it can make
a valid C constant.

Therefore, when adding KORNSHELL to Imakefile for C files,
you have to add

CXXEXTRA_DEFINES = -DKORNSHELL=\"$(KORNSHELL)\"

or similar (for example, see programs/dtprintinfo)

But for simple shell script substitution we usually change

 LOCAL_CPP_DEFINES = -DCDE_CONFIGURATION_TOP=$(CDE_CONFIGURATION_TOP) \
                     -DCDE_INSTALLATION_TOP=$(CDE_INSTALLATION_TOP) \
                     -DCDE_LOGFILES_TOP=$(CDE_LOGFILES_TOP)

to:

 LOCAL_CPP_DEFINES = -DCDE_CONFIGURATION_TOP=$(CDE_CONFIGURATION_TOP) \
                     -DCDE_INSTALLATION_TOP=$(CDE_INSTALLATION_TOP) \
                     -DCDE_LOGFILES_TOP=$(CDE_LOGFILES_TOP) \
                     -DKORNSHELL=$(KORNSHELL) \
                     -DXPROJECTROOT=X11ProjectRoot

since we don't want quotes for shell scripts.

12 years ago64bit: Fix crash in dtexec
Marcin Cieslak [Thu, 23 Aug 2012 14:40:38 +0000 (16:40 +0200)]
64bit: Fix crash in dtexec

No ANSI prototype for malloc() caused
the returned pointer to be truncated
to 32 bits.

12 years agoFreeBSD: scan /usr/local/lib/X11/fonts/ for fontpath
Marcin Cieslak [Thu, 23 Aug 2012 14:40:37 +0000 (16:40 +0200)]
FreeBSD: scan /usr/local/lib/X11/fonts/ for fontpath

12 years agoUse FreeBSD-specific invocation of /bin/ps
Marcin Cieslak [Thu, 23 Aug 2012 14:40:36 +0000 (16:40 +0200)]
Use FreeBSD-specific invocation of /bin/ps

12 years agoexamples/tt now runs on FreeBSD
Marcin Cieslak [Wed, 22 Aug 2012 20:49:19 +0000 (22:49 +0200)]
examples/tt now runs on FreeBSD

12 years agolibtt: resolve implicit delaration of free() and exit() warnings
Peter Howkins [Wed, 22 Aug 2012 11:39:25 +0000 (12:39 +0100)]
libtt: resolve implicit delaration of free() and exit() warnings

12 years agolib/DtHelp: Include <stdio.h> to prevent warnings about implicit declartion of free()
Peter Howkins [Wed, 22 Aug 2012 11:10:10 +0000 (12:10 +0100)]
lib/DtHelp: Include <stdio.h> to prevent warnings about implicit declartion of free()

12 years agolibcsa: Warning prevention
Peter Howkins [Wed, 22 Aug 2012 10:53:08 +0000 (11:53 +0100)]
libcsa: Warning prevention

Remove 'implicit declaration' warnings by included correct ANSI C headers.
Correct some format strings for long ints.

12 years agodtcalc: Resolve "format not a string literal and no format arguments [-Wformat-securi...
Peter Howkins [Wed, 22 Aug 2012 10:28:36 +0000 (11:28 +0100)]
dtcalc: Resolve "format not a string literal and no format arguments [-Wformat-security]" warnings.

Fix warnings related to secruity concerns on varargs functions. By specifying
"%s" on single string calls to sprintf() (and related) it's not possible to
have a % in the input string causing random data to be read off the stack.

12 years agodtcalc: Resolve "missing sentinel in function call [-Wformat]" warnings
Peter Howkins [Wed, 22 Aug 2012 09:44:33 +0000 (10:44 +0100)]
dtcalc: Resolve "missing sentinel in function call [-Wformat]" warnings

Caused by XtVaGetValues() and XtVaSetValues() variable arguments lists
needing to be terminated by NULL not 0.

12 years agoSimple compiler warning fixes in programs/dthelp.
David Cantrell [Wed, 22 Aug 2012 01:53:33 +0000 (21:53 -0400)]
Simple compiler warning fixes in programs/dthelp.

12 years agoUse mkstemp() and handle /usr/lib64 in imake.c
David Cantrell [Wed, 22 Aug 2012 01:51:56 +0000 (21:51 -0400)]
Use mkstemp() and handle /usr/lib64 in imake.c

tmpnam() usage replaced with mkstemp().  Find a suitable tmp directory
checking the TMPDIR environment variable first, then the P_tmpdir
macro and finally /tmp directly.

On 64-bit Linux platforms, check to see if libc.so exists in /usr/lib64.
If found, use it over /usr/lib/libc.so.

12 years agoFix basic compiler warnings in ccimake.c
David Cantrell [Wed, 22 Aug 2012 01:51:06 +0000 (21:51 -0400)]
Fix basic compiler warnings in ccimake.c

main() always returns an int.

12 years agoAccount for multilib Linux installations in imake.
David Cantrell [Tue, 21 Aug 2012 13:34:23 +0000 (09:34 -0400)]
Account for multilib Linux installations in imake.

The libc.so file is not always in /usr/lib.  On multilib systems, the
file we care about could be in /usr/lib64.  Likewise, common Linux
conventions call for 64-bit libraries to go in lib64 directories, so
check there first when on a Linux 64-bit system.

12 years agoInclude stdlib.h in cde/config/imake/ccimake.c
David Cantrell [Fri, 17 Aug 2012 19:41:00 +0000 (15:41 -0400)]
Include stdlib.h in cde/config/imake/ccimake.c

stdlib.h defines exit(3) on Linux systems.

12 years agoFix localized build on OpenBSD.
Pascal Stumpf [Sun, 19 Aug 2012 17:35:38 +0000 (19:35 +0200)]
Fix localized build on OpenBSD.

Use the same set of langs as on Linux and FreeBSD (no Japanese), don't
redefine a needed macro as no-op, and unset LC_CTYPE in the environment
when building cat files.

12 years agoAdd mkcatdefs and book.* to .gitignore
Marcin Cieslak [Sun, 19 Aug 2012 20:40:01 +0000 (22:40 +0200)]
Add mkcatdefs and book.* to .gitignore

12 years agoBuild dtksh on OpenBSD.
Pascal Stumpf [Sun, 19 Aug 2012 16:33:42 +0000 (18:33 +0200)]
Build dtksh on OpenBSD.

This needs ksh93 to bootstrap, available in the openbsd-wip for now as a port,
due to be committed some time soon ...

12 years agoOpenBSD still uses GNU iconv, so the second argument to iconv(3) is not const.
Pascal Stumpf [Sun, 19 Aug 2012 16:19:40 +0000 (18:19 +0200)]
OpenBSD still uses GNU iconv, so the second argument to iconv(3) is not const.

12 years agoFix dttypes for BSD systems
Ulrich Wilkens [Sun, 19 Aug 2012 14:04:03 +0000 (16:04 +0200)]
Fix dttypes for BSD systems

12 years agoFind correct system includes and libs on FreeBSD.
Ulrich Wilkens [Sun, 19 Aug 2012 00:32:18 +0000 (02:32 +0200)]
Find correct system includes and libs on FreeBSD.

12 years agoAdd mkcatdefs program and make the imake changes so it can be used.
Jon Trulson [Sat, 18 Aug 2012 02:11:11 +0000 (20:11 -0600)]
Add mkcatdefs program and make the imake changes so it can be used.

12 years agoBuild missing Xm.cat Mrm.cat Uil.cat for LANG=C
Marcin Cieslak [Thu, 16 Aug 2012 22:04:40 +0000 (00:04 +0200)]
Build missing Xm.cat Mrm.cat Uil.cat for LANG=C

We need to use mkcatdefs to build those.

mkcatdefs needs to be built from the open motif
source tree (localized/util/mkcatdefs.c)
and installed as:

cde/imports/motif/localized/util/mkcatdefs

12 years agodtcreate: Replace broken GetBaseName with basename
Frederic Koehler [Fri, 17 Aug 2012 04:06:25 +0000 (00:06 -0400)]
dtcreate: Replace broken GetBaseName with basename

GetBaseName causes segfaults, because when the pathname
ends in a "/" it returns NULL. This happens when trying
to give a valid filename to dtcreate for an icon.

12 years agodtcreate: Fix some memory management issues
Frederic Koehler [Fri, 17 Aug 2012 02:34:26 +0000 (22:34 -0400)]
dtcreate: Fix some memory management issues

ProcessExecString thought it was returning an array of size 3; however
in C arrays are second-class and there is no direct way to return an
array like this; GCC warning triggered because it was actually
just returning a pointer to local storage. Fixed using malloc.

Also fix some obviously wrong usages of sizeof, although they were
relatively harmless. A little other warning quieting using 0 instead of
NULL.

12 years agodtcreate: Fix another buffer overflow issue
Frederic Koehler [Fri, 17 Aug 2012 02:17:39 +0000 (22:17 -0400)]
dtcreate: Fix another buffer overflow issue

12 years agoMerge branch 'EnvControl-fixes'
Jon Trulson [Fri, 17 Aug 2012 12:01:19 +0000 (06:01 -0600)]
Merge branch 'EnvControl-fixes'

12 years agoMerge branch 'master' of https://git.code.sf.net/p/cdesktopenv/code
Peter Howkins [Fri, 17 Aug 2012 09:26:09 +0000 (10:26 +0100)]
Merge branch 'master' of https://git.code.sf.net/p/cdesktopenv/code

12 years agodtcreate: Fix major buffer overflow
Frederic Koehler [Fri, 17 Aug 2012 01:04:56 +0000 (21:04 -0400)]
dtcreate: Fix major buffer overflow

This code always buffer overflowed, because exactly 2 bytes
less than were used were allocated. This led to dtcreate
crashing when hitting "Find Set..."

12 years agoDtSvc:EnvControl: Use more modern and less dangerous methods of manipulating the...
Jon Trulson [Fri, 17 Aug 2012 00:26:50 +0000 (18:26 -0600)]
DtSvc:EnvControl: Use more modern and less dangerous methods of manipulating the env.

This should work for both linux and the BSD's... It should hopefully
solve the corrupted environment errors Marcin sees on fbsd 9 amd64.

12 years agonew dtlogin rc script for linux from David McBrayer <d9j0m.dev@gmail.com>
Jon Trulson [Thu, 16 Aug 2012 23:05:38 +0000 (17:05 -0600)]
new dtlogin rc script for linux from David McBrayer <d9j0m.dev@gmail.com>