"Vladimir N. Oleynik" [Mon, 20 Feb 2006 12:15:10 +0000 (12:15 -0000)]
remove #undef strlen, use #define strlen always but without xfunc/BB_STRLEN_IMPLEMENTATION
"Vladimir N. Oleynik" [Mon, 20 Feb 2006 10:44:02 +0000 (10:44 -0000)]
correction get(host/domain)name usage, revert 742 bug
Rob Landley [Mon, 20 Feb 2006 02:44:30 +0000 (02:44 -0000)]
svn 14077 was completely broken and apparently never tested.
Rob Landley [Mon, 20 Feb 2006 02:18:03 +0000 (02:18 -0000)]
The gentoo security guys found another way to segfault busybox's decompression
code: we can do a null dereference if one of our huffman tables has all zero
length codes. This fixes it. (Thanks solar.)
Mike Frysinger [Sun, 19 Feb 2006 23:03:31 +0000 (23:03 -0000)]
rfelker writes in Bug 742: make sure string is null terminated after calling gethostname
Mike Frysinger [Sun, 19 Feb 2006 22:59:12 +0000 (22:59 -0000)]
rfelker writes in Bug 740: s/u_char/unsigned char/
Mike Frysinger [Sun, 19 Feb 2006 22:47:51 +0000 (22:47 -0000)]
rfelker writes in Bug 738: sys/sysmacros.h is needed for makedev
Mike Frysinger [Sun, 19 Feb 2006 22:43:58 +0000 (22:43 -0000)]
rfelker writes in Bug 736: stty.c includes unneeded, obsolete header memory.h
Mike Frysinger [Sun, 19 Feb 2006 22:41:41 +0000 (22:41 -0000)]
rfelker writes in Bug 734: Nothing from err.h is used, but cal.c includes it, breaking compile on systems lacking this function.
Mike Frysinger [Sat, 18 Feb 2006 20:13:22 +0000 (20:13 -0000)]
kill all .depend files
Mike Frysinger [Sat, 18 Feb 2006 20:12:39 +0000 (20:12 -0000)]
hide bb_mkdep build
Mike Frysinger [Sat, 18 Feb 2006 06:14:31 +0000 (06:14 -0000)]
fix building on ppc64
"Vladimir N. Oleynik" [Fri, 17 Feb 2006 09:33:22 +0000 (09:33 -0000)]
type typo. Thanks, Devin Bayer
"Vladimir N. Oleynik" [Fri, 17 Feb 2006 09:05:41 +0000 (09:05 -0000)]
quick copy-paste typo
Rob Landley [Fri, 17 Feb 2006 05:19:40 +0000 (05:19 -0000)]
Fix for an integer overflow bug that could cause a segfault on certain
pathological archives.
(Unlikely to have security implications, the only way to trigger it basically
wound up doing memset(dbuf,x,2^31) and triggering an immediate segfault. The
test basically gives us a more polite error message.)
Thanks to Ned Ludd and the Gentoo security guys for finding this.
Rob Landley [Fri, 17 Feb 2006 05:12:03 +0000 (05:12 -0000)]
The tendency of vi to auto-indent can be really annoying at times.
Rob Landley [Fri, 17 Feb 2006 03:43:49 +0000 (03:43 -0000)]
More whitespace than you can possibly imagine...
Rob Landley [Fri, 17 Feb 2006 02:38:00 +0000 (02:38 -0000)]
Update Rogues Gallery.
"Vladimir N. Oleynik" [Thu, 16 Feb 2006 15:41:12 +0000 (15:41 -0000)]
forgoten new file for 14080 revison
"Vladimir N. Oleynik" [Thu, 16 Feb 2006 15:40:24 +0000 (15:40 -0000)]
moved BB_BANNER to applets/version.c file: make kernel like version,
removed depend loop: busybox.h depend with BB_BT, and all sources depend with busybox.h
"Vladimir N. Oleynik" [Thu, 16 Feb 2006 14:38:41 +0000 (14:38 -0000)]
removed #undef strlen, use builtins and prototuped strlen from xfunc file (only\!)
"Vladimir N. Oleynik" [Thu, 16 Feb 2006 14:28:17 +0000 (14:28 -0000)]
isolate and show busybox`s changes
Rob Landley [Thu, 16 Feb 2006 09:25:31 +0000 (09:25 -0000)]
Putting together OPTIONFLAGS, sed needs the global flag to handle multiple
options.
Rob Landley [Thu, 16 Feb 2006 09:00:57 +0000 (09:00 -0000)]
When setting an environment variable by piping something into grep, backquotes
can be useful. Also tweak an if case to be more portable.
Rob Landley [Thu, 16 Feb 2006 03:21:44 +0000 (03:21 -0000)]
Rogues gallery.
"Vladimir N. Oleynik" [Wed, 15 Feb 2006 17:15:56 +0000 (17:15 -0000)]
add last terminal line
"Vladimir N. Oleynik" [Wed, 15 Feb 2006 13:27:18 +0000 (13:27 -0000)]
demo (UN)USE_FEATURE... usage
"Vladimir N. Oleynik" [Wed, 15 Feb 2006 12:29:37 +0000 (12:29 -0000)]
full removed config.h, use bb_config.h only
Rob Landley [Tue, 14 Feb 2006 17:47:05 +0000 (17:47 -0000)]
Fix bug 674: sum's block count should always round up.
Rob Landley [Tue, 14 Feb 2006 16:05:32 +0000 (16:05 -0000)]
Patch from awk maintainer (Dmitry Zakhrov) to fix bugs 642, 663, and 667.
Bernhard Reutner-Fischer [Tue, 14 Feb 2006 10:43:40 +0000 (10:43 -0000)]
- commentary typos
"Vladimir N. Oleynik" [Tue, 14 Feb 2006 10:36:38 +0000 (10:36 -0000)]
restore change by Denis Vlasenko: file_to_buf must vary fast, best if inline
"Vladimir N. Oleynik" [Tue, 14 Feb 2006 10:17:09 +0000 (10:17 -0000)]
cleanups after changes by Denis Vlasenko. Size optimization
"Vladimir N. Oleynik" [Tue, 14 Feb 2006 09:23:25 +0000 (09:23 -0000)]
commentary typos. Thank by aldot
Rob Landley [Tue, 14 Feb 2006 08:29:48 +0000 (08:29 -0000)]
Rob Landley is busybox maintainer now. Eeek.
Rob Landley [Tue, 14 Feb 2006 07:33:45 +0000 (07:33 -0000)]
Fix off by one error. (I know I had a reason for doing that, but I have _no_
idea what it was...)
Rob Landley [Mon, 13 Feb 2006 22:04:27 +0000 (22:04 -0000)]
Cleanups from Denis Vlasenko.
Rob Landley [Mon, 13 Feb 2006 19:40:43 +0000 (19:40 -0000)]
Bug fix from Kim B. Heino, manifested via:
echo > foo && zip foo.zip foo && ./busybox unzip foo.zip
Rob Landley [Mon, 13 Feb 2006 19:16:41 +0000 (19:16 -0000)]
New USE() macros
For each CONFIG_SYMBOL, include/bb_config.h now has both ENABLE_SYMBOL
and USE_SYMBOL(x). ENABLE_SYMBOL is still always defined (1 or 0) so that
if(ENABLE) should optimize out when it's zero. The USE_SYMBOL(X) will only
splice in X if the symbol is defined, otherwise it'll be empty.
Thus we can convert this:
#ifdef CONFIG_ARGS
opt = bb_getopt_ulflags(argc, argv, "ab:c"
#ifdef CONFIG_THINGY
"d:"
#endif
, &bvalue
#ifdef CONFIG_THINGY
, &thingy
#endif
);
#endif
into this:
if (ENABLE_ARGS) {
opt = bb_getopt_ulflags(argc, argv, "ab:c" USE_THINGY("d:"), &bvalue
USE_THINGY(, &thingy));
}
And it should produce the same code.
Unlike the old versions in include/_usage.h, the new USE_SYMBOL(x) can handle
commas in its arguments (as shown above). (The _usage.h file is obsolete and
no longer generated.)
Nobody should need to include config.h directly anymore, bb_config.h should
define all the configuration stuff we need. Someday, the CONFIG_SYMBOL
versions should go away in favor of ENABLE_SYMBOL and USE_SYMBOL().
Thanks to vodz for the new version of bb_mkdep.c that works with function
macros.
Bernhard Reutner-Fischer [Sun, 12 Feb 2006 11:25:32 +0000 (11:25 -0000)]
- commentary typos
Rob Landley [Sun, 12 Feb 2006 00:45:39 +0000 (00:45 -0000)]
More random documentation.
Rob Landley [Fri, 10 Feb 2006 21:38:20 +0000 (21:38 -0000)]
Missed this in svn 13701.
Rob Landley [Fri, 10 Feb 2006 21:36:53 +0000 (21:36 -0000)]
Another item.
Rob Landley [Wed, 8 Feb 2006 20:06:57 +0000 (20:06 -0000)]
Fix umount so it works if there's no /etc/mtab or /proc/mounts, make
umount -a into a CONFIG_FEATURE (why not?), and zap the now obsolete
defconfig file (which was supposed to be part of the previous checkin).
Rob Landley [Wed, 8 Feb 2006 18:50:17 +0000 (18:50 -0000)]
Help text update and tweak to defconfig to remove two more things that
the "maximum sane configuration" shouldn't have. (Explicit MTAB support in
mount, which you should only need if you have no /proc, and FEATURE_CLEAN_UP,
which exists to humor valgrind and otherwise just bloats the code).
Rob Landley [Wed, 8 Feb 2006 18:34:21 +0000 (18:34 -0000)]
Convert some help text to english.
Mike Frysinger [Tue, 7 Feb 2006 06:10:45 +0000 (06:10 -0000)]
add back in path nulling after calling find_dev() since it is needed for now ...
Mike Frysinger [Tue, 7 Feb 2006 00:58:11 +0000 (00:58 -0000)]
Cristian Ionescu-Idbohrn writes:
force enough space padding so that applet names always end up on their own line
Mike Frysinger [Tue, 7 Feb 2006 00:51:07 +0000 (00:51 -0000)]
space out supported applet names so the config list doesnt wrap on an 80col terminal
Mike Frysinger [Mon, 6 Feb 2006 23:38:59 +0000 (23:38 -0000)]
fixup whitespace in awk help output
Rob Landley [Mon, 6 Feb 2006 02:49:45 +0000 (02:49 -0000)]
Bug 677: there are apparently still people using telnet.
Mike Frysinger [Mon, 6 Feb 2006 01:11:34 +0000 (01:11 -0000)]
get rid of warnings with applets that have no usage and get rid of pointless --- separator between applets
Mike Frysinger [Sun, 5 Feb 2006 22:15:39 +0000 (22:15 -0000)]
if the .pl script gets updated, force doc regen
Mike Frysinger [Sun, 5 Feb 2006 22:10:40 +0000 (22:10 -0000)]
Rob Sullivan writes: Here's a patch to autogenerate the list of applets in the Busybox documentation
Rob Landley [Sun, 5 Feb 2006 03:31:44 +0000 (03:31 -0000)]
Save a few bytes in error message.
Mike Frysinger [Fri, 3 Feb 2006 00:25:37 +0000 (00:25 -0000)]
cleanup style ... just because you use less spaces doesnt mean the resulting code is smaller
Mike Frysinger [Fri, 3 Feb 2006 00:19:42 +0000 (00:19 -0000)]
shrink the code a bit
Mike Frysinger [Fri, 3 Feb 2006 00:16:53 +0000 (00:16 -0000)]
gavinl writes in Bug 661:
if read() file return less than 1, we should close the fd and then goto end.
Mike Frysinger [Thu, 2 Feb 2006 23:14:57 +0000 (23:14 -0000)]
alphabetical order and fix mdev comments about echo>/sys vs echo>/proc/sys
Mike Frysinger [Thu, 2 Feb 2006 22:52:59 +0000 (22:52 -0000)]
fix mdev help output
"Vladimir N. Oleynik" [Thu, 2 Feb 2006 14:48:54 +0000 (14:48 -0000)]
destroy bug 679, use getopt_ulflags with new feature: usage option. Removed two strdup
Mike Frysinger [Thu, 2 Feb 2006 01:41:53 +0000 (01:41 -0000)]
make the build system puuuuuuuuuuurty
"Vladimir N. Oleynik" [Wed, 1 Feb 2006 14:47:52 +0000 (14:47 -0000)]
removed anoinig `unused' warnings
"Vladimir N. Oleynik" [Wed, 1 Feb 2006 12:56:19 +0000 (12:56 -0000)]
removed anoinig warnings
"Vladimir N. Oleynik" [Wed, 1 Feb 2006 12:41:35 +0000 (12:41 -0000)]
remode warning: const static mix
Bernhard Reutner-Fischer [Tue, 31 Jan 2006 17:57:48 +0000 (17:57 -0000)]
- bzero -> memset
text data bss dec hex filename
1652855 14444
1215616 2882915 2bfd63 busybox.oorig.gcc-3.3
1652823 14444
1215616 2882883 2bfd43 busybox.gcc-3.3
1603655 14412
1215552 2833619 2b3cd3 busybox.oorig.gcc-3.4
1603655 14412
1215552 2833619 2b3cd3 busybox.gcc-3.4
1609755 14508
1215744 2840007 2b55c7 busybox.oorig.gcc-4.0
1609755 14508
1215744 2840007 2b55c7 busybox.gcc-4.0
1590495 13516
1215392 2819403 2b054b busybox.oorig.gcc-4.1-HEAD
1590495 13516
1215392 2819403 2b054b busybox.gcc-4.1-HEAD
1589079 13036
1213248 2815363 2af583 busybox.oorig.gcc-4.2-HEAD
1589079 13036
1213248 2815363 2af583 busybox.gcc-4.2-HEAD
"Vladimir N. Oleynik" [Tue, 31 Jan 2006 14:25:52 +0000 (14:25 -0000)]
more better for me signed<->unsigned and the const keyword usage
"Vladimir N. Oleynik" [Tue, 31 Jan 2006 13:53:30 +0000 (13:53 -0000)]
add feature: support for running scripts through an interpreter. Thanks Florian Schirmer <jolt@tuxbox.org>
"Vladimir N. Oleynik" [Tue, 31 Jan 2006 12:36:51 +0000 (12:36 -0000)]
more obscure
"Vladimir N. Oleynik" [Tue, 31 Jan 2006 12:12:15 +0000 (12:12 -0000)]
avoid signed<->unsigned warning
"Vladimir N. Oleynik" [Tue, 31 Jan 2006 12:06:57 +0000 (12:06 -0000)]
avoid signed<->unsigned warning
"Vladimir N. Oleynik" [Tue, 31 Jan 2006 11:57:06 +0000 (11:57 -0000)]
removed unneed signed, avoid warning
Bernhard Reutner-Fischer [Tue, 31 Jan 2006 11:29:22 +0000 (11:29 -0000)]
- pass -static via CC rather than LD
"Vladimir N. Oleynik" [Tue, 31 Jan 2006 11:19:12 +0000 (11:19 -0000)]
more destroy potential overflow for x86_64.
"Vladimir N. Oleynik" [Tue, 31 Jan 2006 11:16:40 +0000 (11:16 -0000)]
destroy potential overflow for x86_64. Added ATTRIBUTE_UNUSED
Bernhard Reutner-Fischer [Tue, 31 Jan 2006 09:53:53 +0000 (09:53 -0000)]
- add and use ATTRIBUTE_ALIGNED(num_bytes)
- remove unused parameter pindex from fdisk.c, xbsd_initlabel()
"Vladimir N. Oleynik" [Tue, 31 Jan 2006 09:44:04 +0000 (09:44 -0000)]
changed strange mix signed<->unsigned
"Vladimir N. Oleynik" [Tue, 31 Jan 2006 09:35:45 +0000 (09:35 -0000)]
protect potential overflow for x86_64
"Vladimir N. Oleynik" [Tue, 31 Jan 2006 09:27:48 +0000 (09:27 -0000)]
quick analize signed->unsigned: protect overflow of map[char], getchar->EOF. Use ATTRIBUTE_UNUSE.
Bernhard Reutner-Fischer [Tue, 31 Jan 2006 08:17:13 +0000 (08:17 -0000)]
- fix typo i introduced yesterday.
Rob Landley [Tue, 31 Jan 2006 03:45:26 +0000 (03:45 -0000)]
Not on libbusybox.so: it's GPL, no API barrier, no stability promise.
Rob Landley [Tue, 31 Jan 2006 02:42:50 +0000 (02:42 -0000)]
Turn defconfig into what make allyesconfig is today. Turn allyesconfig
back into allyesconfig. (Memo: apparently SELINUX doesn't compile anymore.)
Make defconfig shouldn't switch on libbusybox.so, but allyesconfig does.
Eric Andersen [Mon, 30 Jan 2006 23:09:20 +0000 (23:09 -0000)]
hopefully the last of the annoying signed/unsigned and mixed type errors
Eric Andersen [Mon, 30 Jan 2006 22:48:39 +0000 (22:48 -0000)]
fix up yet more annoying signed/unsigned and mixed type errors
Eric Andersen [Mon, 30 Jan 2006 22:33:31 +0000 (22:33 -0000)]
make certain we dereference the pointer as a time_t, esp on x86_64
where it might otherwise not be dereferenced as such by default
Eric Andersen [Mon, 30 Jan 2006 22:30:41 +0000 (22:30 -0000)]
fix up annoying signed/unsigned and mixed type errors
Eric Andersen [Mon, 30 Jan 2006 19:48:23 +0000 (19:48 -0000)]
clean up yet more annoying signed/unsigned mismatches and fixup
yet more incorrect types
Eric Andersen [Mon, 30 Jan 2006 18:33:12 +0000 (18:33 -0000)]
passing around an int as a void* is a very bad idea
Eric Andersen [Mon, 30 Jan 2006 18:00:02 +0000 (18:00 -0000)]
sort out yet more type issues
Bernhard Reutner-Fischer [Mon, 30 Jan 2006 17:41:06 +0000 (17:41 -0000)]
- very minor tweak: save 1 byte.
statistics:
text data bss dec hex filename
867 0 12 879 36f fold.o.oorig.gcc-3.3
843 0 12 855 357 fold.o.oorig.gcc-3.4
780 0 12 792 318 fold.o.oorig.gcc-4.0
761 0 12 773 305 fold.o.oorig.gcc-4.1-HEAD
761 0 12 773 305 fold.o.oorig.gcc-4.2-HEAD
866 0 12 878 36e fold.o.gcc-3.3
842 0 12 854 356 fold.o.gcc-3.4
779 0 12 791 317 fold.o.gcc-4.0
760 0 12 772 304 fold.o.gcc-4.1-HEAD
760 0 12 772 304 fold.o.gcc-4.2-HEAD
Eric Andersen [Mon, 30 Jan 2006 17:30:22 +0000 (17:30 -0000)]
with 2.4 kernel headers, lo_file_name is char, but with 2.6
headers we get a u8 for lo_file_name, so always cast to (char *)
when treating it as such.
Eric Andersen [Mon, 30 Jan 2006 17:27:00 +0000 (17:27 -0000)]
fixup a few types to prevent gcc (rightfully) whining about mixing
signed and unsigned, unmatches pointer target types, etc
Bernhard Reutner-Fischer [Mon, 30 Jan 2006 17:17:14 +0000 (17:17 -0000)]
- add some ATTRIBUTE_UNUSED.
- use shorter boilerplate while at it.
Bernhard Reutner-Fischer [Mon, 30 Jan 2006 15:29:55 +0000 (15:29 -0000)]
- make linking against libcrypt optional by looking if pw_encrypt() or
correct_password() is configured. Fixes allnoconfig pulling in -lcrypt.
"Vladimir N. Oleynik" [Mon, 30 Jan 2006 14:02:06 +0000 (14:02 -0000)]
removed warning "comparison between signed and unsigned".
"Vladimir N. Oleynik" [Mon, 30 Jan 2006 13:58:34 +0000 (13:58 -0000)]
removed warning "comparison between signed and unsigned". Added ATTRIBUTE_UNUSED. My whitespace
"Vladimir N. Oleynik" [Mon, 30 Jan 2006 13:51:50 +0000 (13:51 -0000)]
removed warning "comparison between signed and unsigned". Added ATTRIBUTE_UNUSED. My whitespace
"Vladimir N. Oleynik" [Mon, 30 Jan 2006 13:47:19 +0000 (13:47 -0000)]
removed warning "comparison between signed and unsigned".
"Vladimir N. Oleynik" [Mon, 30 Jan 2006 13:41:53 +0000 (13:41 -0000)]
removed warning "comparison between signed and unsigned". Added ATTRIBUTE_UNUSED. Whitespace
"Vladimir N. Oleynik" [Mon, 30 Jan 2006 13:36:03 +0000 (13:36 -0000)]
removed warning "comparison between signed and unsigned". Change very very old code: use int instead short