Rob Landley [Mon, 8 May 2006 22:17:23 +0000 (22:17 -0000)]
Move sed over to the generic llist_t for append. Saves about 90 bytes.
Rob Landley [Mon, 8 May 2006 20:48:12 +0000 (20:48 -0000)]
Make bloatcheck work when building out of tree.
Bernhard Reutner-Fischer [Mon, 8 May 2006 20:20:32 +0000 (20:20 -0000)]
- fix build
Rob Landley [Mon, 8 May 2006 19:03:07 +0000 (19:03 -0000)]
Fiddling with llist to make memory management easier. Specifically, the
option to delete the contents of the list when we delete the list is a
good thing.
Rob Landley [Mon, 8 May 2006 18:30:33 +0000 (18:30 -0000)]
Tweak suggested by Matt Mackall when I submitted the bloat-o-meter changes
back to linux-kernel...
Rob Landley [Mon, 8 May 2006 18:18:02 +0000 (18:18 -0000)]
The changes svn 14960 made to Rules.mak broke building out of tree
(with O=directory), and reverting them fixes building out of tree. I'd be
happy to fix them up instead of reverting them if I had the foggiest idea
what they were trying to do, but I don't, and this at least gets building
out of tree working again...
Rob Landley [Mon, 8 May 2006 15:35:46 +0000 (15:35 -0000)]
The if() is cheaper than the extra function parameter. According to make
bloatcheck, this saves 112 bytes on x86...
Rob Landley [Mon, 8 May 2006 15:08:25 +0000 (15:08 -0000)]
Remove a link that leaked in from the pending llist_t changes.
Mike Frysinger [Mon, 8 May 2006 03:24:36 +0000 (03:24 -0000)]
re-enable udhcp in a few more places
Mike Frysinger [Mon, 8 May 2006 03:20:50 +0000 (03:20 -0000)]
add back in udhcp support
Rob Landley [Mon, 8 May 2006 02:53:23 +0000 (02:53 -0000)]
Shrink the code about 50 bytes, allocate less run-time memory, and add a
comment that null terminating the string we sscanf() shouldn't be required
since the kernel adds \n to the end of it and sscanf will stop there.
Rob Landley [Mon, 8 May 2006 02:22:24 +0000 (02:22 -0000)]
More busting on legacy mtab support in the help text.
Rob Landley [Sun, 7 May 2006 23:34:15 +0000 (23:34 -0000)]
Cleanup patch from tito.
Rob Landley [Sun, 7 May 2006 23:19:20 +0000 (23:19 -0000)]
The udhcp was deleted from busybox in 14634. Bolting an external project to
the side of the tree doesn't _COUNT_, and I will not ship it.
Udhcp was deleted shortly after I posted my philosophy for what should and
shouldn't go into busybox:
http://www.busybox.net/lists/busybox/2006-March/019484.html
I complained about the change t the time. I've complained repeatedly since.
But nobody felt like fixing it. External dependencies are something to be
minimized. I don't care about the ability for packages to build outside
busybox: something is either part of busybox, or it isn't. If I convert any
part of the external udhcp repository to use libbb, I've broken the external
package. Any random cleanups that touch that directory suddenly have to worry
about external dependencies that are NOT OUR PROBLEM. Therefore, that
directory is not and cannot be part of busybox. Wishful thinking isn't going
to change that. I will not ship something I can't maintain.
I'll try to get a new dhcp client and server in before the ship window closes,
but I have a half-dozen other projects pending. I'm sorry this happened, but
I'm not the one who removed it, and I'm not the one who ignored the project
maintainer's repeated complaints about the situation for the next month and a
half.
Rob Landley [Sun, 7 May 2006 21:10:06 +0000 (21:10 -0000)]
Patch to fix bug 868, and some related cleanup while I was in the area.
A tab is now taken as the end of filename if it's there, but if it isn't
(because the timestamp isn't there) we continue with the existing untruncated
line as the filename.
Rob Landley [Sun, 7 May 2006 20:58:55 +0000 (20:58 -0000)]
Script to easily get an assembly dump of a single function.
Rob Landley [Sun, 7 May 2006 20:20:34 +0000 (20:20 -0000)]
Remove bb_strlen() in favor of -fno-builtin-strlen. Saves as many bytes
as the old optimization did (actually does slightly better under gcc 4.0), and
simplifies the code.
Rob Landley [Sun, 7 May 2006 19:26:53 +0000 (19:26 -0000)]
Add "make bloatcheck" to run Matt Mackall's bloat-o-meter. Copy an old
busybox_unstripped to busybox_old, build a new version, and "make bloatcheck"
to see a detailed breakdown of the size difference.
Rob Landley [Sun, 7 May 2006 01:44:23 +0000 (01:44 -0000)]
Dennis Vlasenko pointed out that run_applet_by_name sets bb_applet_name already.
Mike Frysinger [Sat, 6 May 2006 05:30:46 +0000 (05:30 -0000)]
fix udhcp again
Mike Frysinger [Sat, 6 May 2006 05:27:19 +0000 (05:27 -0000)]
make sure script is executable
Rob Landley [Fri, 5 May 2006 22:22:30 +0000 (22:22 -0000)]
Add an "optional" line for FEATURE_READLINK_FOLLOW.
Rob Landley [Fri, 5 May 2006 21:07:41 +0000 (21:07 -0000)]
New test from Natanael Copa.
Mike Frysinger [Fri, 5 May 2006 20:33:07 +0000 (20:33 -0000)]
didnt mean to commit debug enable
Mike Frysinger [Fri, 5 May 2006 20:32:31 +0000 (20:32 -0000)]
use %p when printing pointers, not %x
Mike Frysinger [Fri, 5 May 2006 18:38:07 +0000 (18:38 -0000)]
fix Bug 659 as reported by Robin Getz
Rob Landley [Fri, 5 May 2006 18:20:42 +0000 (18:20 -0000)]
Busybox's udhcp was deleted a while ago. Bolting an external project onto the
tree doesn't change that.
Rob Landley [Fri, 5 May 2006 17:29:09 +0000 (17:29 -0000)]
Another patch from Garrett: remove bad block bitmap checking code. Everything
produced in the list ten years has some variant of internal error correction
(disks, cdrom, flash), so if it has user-visible bad blocks on it the
hardware has exhausted its remapping reserve and is dying, and you need to get
your data off pronto. (The one exception I can think of is floppies, and I
don't care.)
Rob Landley [Fri, 5 May 2006 16:54:40 +0000 (16:54 -0000)]
Migrate endianness macros.
Rob Landley [Fri, 5 May 2006 16:52:28 +0000 (16:52 -0000)]
Patch from Dennis Vlasenko resetting values that get reused.
Rob Landley [Fri, 5 May 2006 15:55:06 +0000 (15:55 -0000)]
Patch from Dennis Vlasenko simplifying the APPLET macros.
Rob Landley [Fri, 5 May 2006 15:01:38 +0000 (15:01 -0000)]
Patch from Jason Schoon to make mount -a not abort on the first failure.
Bernhard Reutner-Fischer [Fri, 5 May 2006 14:05:21 +0000 (14:05 -0000)]
- ignore missing helptext for options which are not selectable.
Bernhard Reutner-Fischer [Fri, 5 May 2006 11:55:53 +0000 (11:55 -0000)]
- add helptext for CONFIG_UNIX2DOS
Rob Landley [Thu, 4 May 2006 21:22:27 +0000 (21:22 -0000)]
Not quite compiler independent, but we've never tried to be gcc independent
anyway. This is at least less ugly than what was there before, and fixes
building all sources at once.
Rob Landley [Thu, 4 May 2006 20:56:43 +0000 (20:56 -0000)]
It was sitting there, in the patches directory, for years. It was delete it
or apply it. It's small, simple, evil, part of SUSv3, and we can switch it
off.
Rob Landley [Thu, 4 May 2006 19:57:34 +0000 (19:57 -0000)]
There aren't any bzip2 based RPMs. If people want to experiment with new
packaging formats, there's ipkg and such...
Rob Landley [Thu, 4 May 2006 19:52:28 +0000 (19:52 -0000)]
CONFIG->ENABLE migration.
Rob Landley [Thu, 4 May 2006 19:51:22 +0000 (19:51 -0000)]
Fix allbareconfig.
Bernhard Reutner-Fischer [Thu, 4 May 2006 11:38:33 +0000 (11:38 -0000)]
- add script to check for missing help entries of config options
Currently we have these errors:
./modutils/Config.in: No helptext for 'CONFIG_FEATURE_QUERY_MODULE_INTERFACE'
./networking/Config.in: No helptext for 'CONFIG_IPADDR'
./networking/Config.in: No helptext for 'CONFIG_IPLINK'
./networking/Config.in: No helptext for 'CONFIG_IPROUTE'
./networking/Config.in: No helptext for 'CONFIG_IPTUNNEL'
./coreutils/Config.in: No helptext for 'CONFIG_UNIX2DOS'
Rob Landley [Wed, 3 May 2006 21:58:45 +0000 (21:58 -0000)]
Big dead code elimination pass from Garrett.
Rob Landley [Wed, 3 May 2006 21:39:28 +0000 (21:39 -0000)]
Build break fix from Bernhard fischer, fixing fallout from svn 14974. (My bad.)
Rob Landley [Wed, 3 May 2006 21:23:15 +0000 (21:23 -0000)]
Whitespace and documentation cleanup from Dennis Vlasenko.
Rob Landley [Wed, 3 May 2006 20:22:03 +0000 (20:22 -0000)]
Patch from Rich Felker to make ls use libc's qsort.
Rob Landley [Wed, 3 May 2006 20:19:14 +0000 (20:19 -0000)]
Rich Felker writes:
mistake in a macro caused statement before declaration.
Rob Landley [Wed, 3 May 2006 20:05:18 +0000 (20:05 -0000)]
Patch from Garrett Kajmowicz to move a lot of #defines into the
header file.
Rob Landley [Wed, 3 May 2006 20:00:00 +0000 (20:00 -0000)]
Remove HDIO_GETGEO_BIG which is dead (removed from 2.6) and was pointless back
in 2.4 (it fetched the same hd_geometry struct only with uint cylinders instead
of ushort cylinders: nothing that big has ever accurately reported gemoetry,
it's all LBA.
Also stop declaring the hd_geometry struct static: it's two chars, a short, and
a long for a grand total of 8 bytes. That can go on the stack.
Rob Landley [Wed, 3 May 2006 18:28:06 +0000 (18:28 -0000)]
Use ATTRIBUTE_NORETURN as suggested by tito, plus a few in-passing cleanups.
Rob Landley [Tue, 2 May 2006 22:44:04 +0000 (22:44 -0000)]
Patch from Jason Schoon to add optional SIGUSR1 support to dd.
Rob Landley [Tue, 2 May 2006 21:39:04 +0000 (21:39 -0000)]
Minor tweaks: remove traces of old $COMMAND environment variable.
Rob Landley [Tue, 2 May 2006 19:46:52 +0000 (19:46 -0000)]
Patch from Shaun Jackman:
ls has an ugly bug. ls uses an array of pointers, the elements of
which are all in a linked list. To free the elements, instead of
freeing all the elements in the array, array[0..nelements], it frees
by iterating the linked list starting at array[0], which it assumes is
the head of the list. Unfortunately, ls also sorts the array! So,
array[0] is no longer the head, but somewhere in the middle of the
linked list. This patch fixes this bug, and also adds an
ENABLE_FEATURE_CLEAN_UP stanza.
Rob Landley [Mon, 1 May 2006 19:28:53 +0000 (19:28 -0000)]
Patch from tito removing obsolete code.
Rob Landley [Mon, 1 May 2006 05:26:01 +0000 (05:26 -0000)]
Notes on portability, and on when #include <linux/blah> is appropriate.
Rob Landley [Mon, 1 May 2006 00:53:40 +0000 (00:53 -0000)]
Fixup a build break if ENABLE_SHOW_USAGE switched off. (Fallout from the
compressed usage messages patch).
Rob Landley [Sat, 29 Apr 2006 20:08:40 +0000 (20:08 -0000)]
Patches from Denis Vlasenko to rework "current_name" handling and remove
print_current_name().
Rob Landley [Sat, 29 Apr 2006 20:05:17 +0000 (20:05 -0000)]
Patch from Denis Vlasenko:
* Do not initialize globals to 0, it is done automatically
* unsigned short -> uint16_t, unsigned int -> uint32_t
where appropriate (did it ever work on Alphas?)
* triple sync() is silly - removed
* check_zone_nr uses check_zone_nr2 now
* remove trailing periods from messages, uppercase first letter
Rob Landley [Sat, 29 Apr 2006 20:03:54 +0000 (20:03 -0000)]
Patch from Denis Vlasenko:
ix bug (inode_map and zone_map are char* pointers,
sizeof() on them gives 4 or 8)
Rob Landley [Sat, 29 Apr 2006 19:11:24 +0000 (19:11 -0000)]
Remove some unused code pointed out by Tito, plus a slightly more graceful
way of handling endianness.
Rob Landley [Sat, 29 Apr 2006 16:06:31 +0000 (16:06 -0000)]
Style fixes from Denis Vlasenko.
Rob Landley [Sat, 29 Apr 2006 16:03:40 +0000 (16:03 -0000)]
Another patch from Denis Vlasenko:
Make hdparm smaller:
* Make bb_ioctl return the status
* Replace ioctl with bb_ioctl in a few places
* Add bb_ioctl_alt, use where appropriate (four places)
* unsigned char args1[4+512] = {WIN_IDENTIFY,0,0,1,};
ate 0.5k of rodata, fix that
Rob Landley [Sat, 29 Apr 2006 15:49:18 +0000 (15:49 -0000)]
From Dennis Vlasenko, Make hdparm smaller:
* Use combined no_scsi_no_xt()
* Have common unsigned char args[4] = {WIN_SETFEATURES,0,0,0};
Rob Landley [Sat, 29 Apr 2006 15:23:33 +0000 (15:23 -0000)]
Cleanup to hdparm by tito.
Mike Frysinger [Sat, 29 Apr 2006 04:45:22 +0000 (04:45 -0000)]
termios.h is already included so dont include sys/termios.h as well
Mike Frysinger [Sat, 29 Apr 2006 04:44:08 +0000 (04:44 -0000)]
detect more obsolete headers
Mike Frysinger [Sat, 29 Apr 2006 04:43:50 +0000 (04:43 -0000)]
just include fcntl.h not sys/fcntl.h
Mike Frysinger [Sat, 29 Apr 2006 04:43:31 +0000 (04:43 -0000)]
just include fcntl.h not sys/fcntl.h
Mike Frysinger [Sat, 29 Apr 2006 04:21:10 +0000 (04:21 -0000)]
Rob Sullivan writes: rewrite the regex handling to improve stability
Mike Frysinger [Sat, 29 Apr 2006 04:19:10 +0000 (04:19 -0000)]
compile.h is incorrect; create a new do_link.h and use that for bb_mkdep and usage
Mike Frysinger [Sat, 29 Apr 2006 04:12:36 +0000 (04:12 -0000)]
use pretty output for scripts/bb_mkdep and scripts/usage
Bernhard Reutner-Fischer [Fri, 28 Apr 2006 20:02:29 +0000 (20:02 -0000)]
- rerun gcse pass after reload, enable whole-program iff we are not building
the lib (due to bug in gcc; see comment.)
I would have run the testsuite to check if everything is still behaving, but
unfortunately i cannot run the testsuite anymore: it just sits there and does
nothing even with a pristine checkout and an old gcc.
srcdir=/tmp/busybox/testsuite /tmp/busybox/testsuite/runtest
PASS: Applet order
FAIL: Common typos
PASS: Obsolete function usage
PASS: Obsolete function usage
<spins, ^C>
make[1]: *** [check] Interrupt
make: *** [check] Interrupt
I've just corrected that wrong double-printing.
Anyway. with gcc-4.1-HEAD from earlier today, we now have for
defconfig+ COMPILE_AT_ONCE:
880 -rwxr-xr-x 1 433 433 893476 Apr 28 21:41 busybox.oorig-4.0
860 -rwxr-xr-x 1 433 433 874560 Apr 28 21:36 busybox.oorig
844 -rwxr-xr-x 1 433 433 858752 Apr 28 21:49 busybox
text data bss dec hex filename
879920 11568
1039148 1930636 1d758c busybox.oorig-4.0
862802 10192
1038796 1911790 1d2bee busybox.oorig
848066 9100
1037536 1894702 1ce92e busybox
values for 4.0.2 just added for reference..
Bernhard Reutner-Fischer [Fri, 28 Apr 2006 19:53:48 +0000 (19:53 -0000)]
- print "Obsolet headers" instead of "Obsolete function usage" when checking
for obsolet includes.
Rob Landley [Fri, 28 Apr 2006 19:38:04 +0000 (19:38 -0000)]
More usage.h cleanups, with collateral changes to httpd. Specifically,
most of our CONFIG entries switch stuff on instead of off when enabled, so fix
the gratuitously reversed INETD thing.
Rob Landley [Fri, 28 Apr 2006 01:33:30 +0000 (01:33 -0000)]
Patch from tito to update output of hdparm.
Rob Landley [Thu, 27 Apr 2006 23:34:46 +0000 (23:34 -0000)]
Patch from Dennis Vlasenko to add the option to compress help text.
Rob Landley [Thu, 27 Apr 2006 22:36:32 +0000 (22:36 -0000)]
Re-wordwrap the new tests, and fix seq.c to pass them.
Bernhard Reutner-Fischer [Thu, 27 Apr 2006 13:46:56 +0000 (13:46 -0000)]
- add two regression tests for seq.
"seq two arguments equal, arbitrary negative step" fails but should pass..
Bernhard Reutner-Fischer [Wed, 26 Apr 2006 19:40:15 +0000 (19:40 -0000)]
- add note about crond
Bernhard Reutner-Fischer [Wed, 26 Apr 2006 10:10:25 +0000 (10:10 -0000)]
- patch from Denis Vlasenko to make sizes PHONY and to add objsizes which prints
the sizes of the individual object files.
Rob Landley [Tue, 25 Apr 2006 22:40:53 +0000 (22:40 -0000)]
Convert a chunk of usage.h to USE_ and SKIP_ (more to do there), and fix a
DEFALT typo in du while I was there.
Rob Landley [Tue, 25 Apr 2006 18:42:23 +0000 (18:42 -0000)]
Portability tweak from Shaun Jackman, don't include asm/page.h directly.
Rob Landley [Mon, 24 Apr 2006 23:13:46 +0000 (23:13 -0000)]
From Denis Vlasenko:
* CPU% = process[i].ticks/sum(process[i].ticks) * busy_cpu_ticks/total_cpu_ticks
* got rid of empty line under "Load average" line
and used last line - +2 visible processes
* do not do float conversion of loadavg, just read it as string from /proc
* fix display on small screens
* dropped unused .stime, .utime fields
* a few variables were renamed
* style fixes
Bernhard Reutner-Fischer [Mon, 24 Apr 2006 17:41:29 +0000 (17:41 -0000)]
- return ret so we return something meaningful.
Mike Frysinger [Fri, 21 Apr 2006 22:04:05 +0000 (22:04 -0000)]
Jason Schoon writes: Attached is a patch to display the usage message if fuser is called with no arguments, rather than doing no work and failing silently.
Mike Frysinger [Fri, 21 Apr 2006 21:59:22 +0000 (21:59 -0000)]
Jason Schoon writes: This makes the case where LFS is not defined, but fdisk is configured with large disk support use the pretty build rules.
Mike Frysinger [Fri, 21 Apr 2006 01:18:07 +0000 (01:18 -0000)]
2006-04-20 Shaun Jackman <sjackman@gmail.com>
* Makefile: Build a bFLT binary.
* Rules.mak: Ditto.
Ned Ludd [Fri, 21 Apr 2006 00:40:35 +0000 (00:40 -0000)]
- passwd doesnt use salt with md5 passwords; bug #604 thanks taviso
Mike Frysinger [Thu, 20 Apr 2006 04:00:11 +0000 (04:00 -0000)]
kill signed warnings
Rob Landley [Wed, 19 Apr 2006 22:22:06 +0000 (22:22 -0000)]
Patch from Jean Wolter:
it looks like the introduced support for character classes and
equivalence classes is not correct. The attached patch tries to fix
some symptoms and tries to make tr behave like gnu tr for the added
test cases. The patch
- removes if clauses with side effects
- fixes handling of buffer pointer (strcat added characters to the
buffer without increasing the buffer pointer)
- re-arranges character classes to match ASCII order
regards,
Jean
Rob Landley [Wed, 19 Apr 2006 20:32:27 +0000 (20:32 -0000)]
svn 14824 broke -funsigned-char and possibly building out of tree, because
$(srcdir) can't bind early since it's set to a different value in each subdir.
If it binds early, it's blank, hence an empty -I which eats the next option
as a directory to look for #include files in.
So CFLAGS has to bind late, but the check_gcc stuff should only get run once.
I added a "make V=2" mode to show when check_gcc gets run, and turned WARNINGS
into a CFLAGS line since it was always getting added anyway.
Rob Landley [Tue, 18 Apr 2006 20:57:28 +0000 (20:57 -0000)]
New applet cksum, from Rob Sullivan.
Rob Landley [Tue, 18 Apr 2006 20:42:39 +0000 (20:42 -0000)]
Remove some #if 0 code.
Rob Landley [Tue, 18 Apr 2006 20:41:51 +0000 (20:41 -0000)]
Simplify the GPL boilerplate.
Bernhard Reutner-Fischer [Tue, 18 Apr 2006 14:17:49 +0000 (14:17 -0000)]
- typo: s/derefernce/dereference/g
Thanks to P.J. Day.
Bernhard Reutner-Fischer [Tue, 18 Apr 2006 12:46:56 +0000 (12:46 -0000)]
- commentary typo and superfluous whitespace removal in weird messages.
Bernhard Reutner-Fischer [Tue, 18 Apr 2006 11:21:07 +0000 (11:21 -0000)]
- improve wording in some help texts a little bit.
Bernhard Reutner-Fischer [Tue, 18 Apr 2006 11:15:19 +0000 (11:15 -0000)]
- add typo s/deamon/daemon/g
Bernhard Reutner-Fischer [Tue, 18 Apr 2006 11:11:40 +0000 (11:11 -0000)]
- patch from P.J. Day to rely on the automatic indenting provided by depends.
Bernhard Reutner-Fischer [Tue, 18 Apr 2006 10:04:08 +0000 (10:04 -0000)]
- enable dumpleases applet again; bad rob
Bernhard Reutner-Fischer [Tue, 18 Apr 2006 08:44:19 +0000 (08:44 -0000)]
- add grep for typo s/algorithic/algorithmic/g
Bernhard Reutner-Fischer [Tue, 18 Apr 2006 08:24:13 +0000 (08:24 -0000)]
- BusyBox is under GPL.
in http://www.busybox.net/lists/busybox/2006-April/020364.html Denis Vlasenko
said when asked which license to use for these files:
"Sure. LGPL or GPL is fine with me."
Adjusting accordingly.