oweals/minetest.git
10 years agoIncrease indentation throughout file for clarity. Correct mistakes. Shorten lines...
paramat [Wed, 24 Dec 2014 00:07:54 +0000 (00:07 +0000)]
Increase indentation throughout file for clarity. Correct mistakes. Shorten lines. Make more consistent

Signed-off-by: Craig Robbins <kde.psych@gmail.com>
10 years agoState biome API heat and humidity noise parameters in positional format
paramat [Tue, 23 Dec 2014 23:36:16 +0000 (23:36 +0000)]
State biome API heat and humidity noise parameters in positional format

Signed-off-by: Craig Robbins <kde.psych@gmail.com>
10 years agoConf.example: Fix typo
paramat [Tue, 23 Dec 2014 20:13:32 +0000 (20:13 +0000)]
Conf.example: Fix typo

10 years agoUpdate MinGW toolchain downloads used by travis
sfan5 [Tue, 23 Dec 2014 16:20:26 +0000 (17:20 +0100)]
Update MinGW toolchain downloads used by travis

10 years agoSilence misc. warnings
kwolekr [Tue, 23 Dec 2014 06:02:33 +0000 (01:02 -0500)]
Silence misc. warnings

10 years agoMake limiting of the reflow liquids queue size optional
Craig Robbins [Mon, 22 Dec 2014 23:25:18 +0000 (09:25 +1000)]
Make limiting of the reflow liquids queue size optional

If liquid_queue_purge_time == 0 then disable the queue size limiting and make this the default setting
Additionally, liquid_loop_max now defaults to 100000

10 years agoUpdate mapgen stuff in minetest.conf
paramat [Sun, 21 Dec 2014 21:16:28 +0000 (21:16 +0000)]
Update mapgen stuff in minetest.conf

10 years agoTemporarily fix always bright wieldhand with shaders enabled
kwolekr [Tue, 23 Dec 2014 03:36:11 +0000 (22:36 -0500)]
Temporarily fix always bright wieldhand with shaders enabled

10 years agoRegenerate server_flags_creative.png from XCF
Kahrl [Sun, 21 Dec 2014 12:29:02 +0000 (13:29 +0100)]
Regenerate server_flags_creative.png from XCF

10 years agoFix weird (and wrong) comment in test.cpp
Kahrl [Sun, 21 Dec 2014 12:20:42 +0000 (13:20 +0100)]
Fix weird (and wrong) comment in test.cpp

10 years agolua_api.txt: improve noise documentation. Remove previous eased 3D noise format example
paramat [Wed, 17 Dec 2014 00:53:57 +0000 (00:53 +0000)]
lua_api.txt: improve noise documentation. Remove previous eased 3D noise format example

10 years agoRe-add hacky fix for underwater grass, to fix mgv7 user's biomes
paramat [Sat, 20 Dec 2014 05:25:13 +0000 (05:25 +0000)]
Re-add hacky fix for underwater grass, to fix mgv7 user's biomes

10 years agoChange TileSpec::frames to be std::vector not std::map
unknown [Thu, 18 Dec 2014 12:25:36 +0000 (23:25 +1100)]
Change TileSpec::frames to be std::vector not std::map

Signed-off-by: Craig Robbins <kde.psych@gmail.com>
10 years agoFix visual_scale for plantlike nodes (again)
Vanessa Ezekowitz [Fri, 19 Dec 2014 02:24:31 +0000 (12:24 +1000)]
Fix visual_scale for plantlike nodes (again)

fixes #1989

move the plant to the bottom of its node properly, without affecting its scale.  See isue #1989

10 years agoTemporarily set default biome in builtin
kwolekr [Thu, 18 Dec 2014 14:55:38 +0000 (09:55 -0500)]
Temporarily set default biome in builtin

This should probably be removed when minetest_game has proper biomes.
If I hear "the whole map is just stone!" again after this, I am going to detonate.

10 years agoFix visual_scale for NDT_PLANTLIKE being set too small
Craig Robbins [Thu, 18 Dec 2014 05:39:02 +0000 (15:39 +1000)]
Fix visual_scale for NDT_PLANTLIKE being set too small

10 years agoSuppress compiler warning
Craig Robbins [Thu, 18 Dec 2014 09:29:04 +0000 (19:29 +1000)]
Suppress compiler warning

10 years agoRemove manual biome noise translation
kwolekr [Wed, 17 Dec 2014 21:26:01 +0000 (16:26 -0500)]
Remove manual biome noise translation

10 years agoDo not allow the m_transforming_liquid queue to increase until all RAM is consumed
Craig Robbins [Wed, 17 Dec 2014 16:54:43 +0000 (02:54 +1000)]
Do not allow the m_transforming_liquid queue to increase until all RAM is consumed

10 years agoFix OSX packaging finally
Pavel Puchkin [Mon, 15 Dec 2014 15:32:08 +0000 (17:32 +0200)]
Fix OSX packaging finally

Signed-off-by: Craig Robbins <kde.psych@gmail.com>
10 years agoSet WM_CLASS window hint for Xorg
kwolekr [Mon, 15 Dec 2014 18:47:31 +0000 (13:47 -0500)]
Set WM_CLASS window hint for Xorg

10 years agoExpose mapgen chunksize in on_mapgen_init callbacks
kwolekr [Sun, 14 Dec 2014 23:46:19 +0000 (18:46 -0500)]
Expose mapgen chunksize in on_mapgen_init callbacks

10 years agoUpdate French translation
Calinou [Sun, 14 Dec 2014 16:35:24 +0000 (17:35 +0100)]
Update French translation

Signed-off-by: Craig Robbins <kde.psych@gmail.com>
10 years agoUpdate Spanish language.
Diego Martinez [Sat, 13 Dec 2014 17:25:17 +0000 (14:25 -0300)]
Update Spanish language.

Signed-off-by: Craig Robbins <kde.psych@gmail.com>
10 years agoFixes #1687 by extra semaphore retval handle code for OSX
Pavel Puchkin [Mon, 8 Dec 2014 09:41:29 +0000 (11:41 +0200)]
Fixes #1687 by extra semaphore retval handle code for OSX

See https://github.com/minetest/minetest/issues/1687#issuecomment-56830173

Signed-off-by: Craig Robbins <kde.psych@gmail.com>
10 years agoFix typo in lua_api.txt
Craig Robbins [Sun, 14 Dec 2014 15:09:17 +0000 (01:09 +1000)]
Fix typo in lua_api.txt

10 years agoNoise: Don't assume Noise is used for 2D unless gradientMap2D is actually called
kwolekr [Sun, 14 Dec 2014 05:18:31 +0000 (00:18 -0500)]
Noise: Don't assume Noise is used for 2D unless gradientMap2D is actually called

10 years agoFix background of creative icon (was black, now transparent)
Kahrl [Sun, 14 Dec 2014 04:09:43 +0000 (05:09 +0100)]
Fix background of creative icon (was black, now transparent)

10 years agoRevert "Update Russian translation"
Kahrl [Sat, 13 Dec 2014 14:23:32 +0000 (15:23 +0100)]
Revert "Update Russian translation"

This reverts commit e4e4324a30d6bcac5cc06c74e955e4941b14bd38.

Conflicts:
po/minetest.pot
po/*/minetest.po

10 years agoFix misleading error when exiting the client from the main menu
Craig Robbins [Sat, 13 Dec 2014 14:00:52 +0000 (00:00 +1000)]
Fix misleading error when exiting the client from the main menu

10 years agoProvide more info if a subgame is not valid/found
Craig Robbins [Sat, 13 Dec 2014 13:01:16 +0000 (23:01 +1000)]
Provide more info if a subgame is not valid/found

10 years agoUpdate german translation 1950/head
PilzAdam [Fri, 12 Dec 2014 23:40:15 +0000 (00:40 +0100)]
Update german translation

10 years agoLuaPerlinNoiseMap: Fix 3d noise safety check
kwolekr [Sat, 13 Dec 2014 03:58:19 +0000 (22:58 -0500)]
LuaPerlinNoiseMap: Fix 3d noise safety check

10 years agoFix segfault when dragging mouse out of mainmenu window (#1910)
Kahrl [Fri, 12 Dec 2014 23:39:07 +0000 (00:39 +0100)]
Fix segfault when dragging mouse out of mainmenu window (#1910)

10 years agoRemove vertlabels from main menu and relayout a bit
Kahrl [Sun, 7 Dec 2014 21:09:21 +0000 (22:09 +0100)]
Remove vertlabels from main menu and relayout a bit

10 years agoDisplay serverlist flags as icons
Kahrl [Sun, 30 Nov 2014 23:58:00 +0000 (00:58 +0100)]
Display serverlist flags as icons

10 years agoUpdate po files
ShadowNinja [Fri, 12 Dec 2014 22:20:53 +0000 (17:20 -0500)]
Update po files

10 years agoUpdate Russian translation
AntonBoch1244 [Tue, 5 Aug 2014 09:17:45 +0000 (13:17 +0400)]
Update Russian translation

10 years agoUpdate Italian translation
Enki [Wed, 14 May 2014 14:42:15 +0000 (16:42 +0200)]
Update Italian translation

10 years agoFix missing call to std::ostringstream::str
ShadowNinja [Fri, 12 Dec 2014 21:31:29 +0000 (16:31 -0500)]
Fix missing call to std::ostringstream::str

10 years agoFix MSVC compiling warnings and remove an unused texture
SmallJoker [Thu, 11 Dec 2014 19:12:28 +0000 (20:12 +0100)]
Fix MSVC compiling warnings and remove an unused texture

10 years agoLog: Silence errorstream during unittests
kwolekr [Fri, 12 Dec 2014 20:12:31 +0000 (15:12 -0500)]
Log: Silence errorstream during unittests

10 years agoUse std::string::empty() instead of size() where applicable
Anton [Fri, 12 Dec 2014 14:55:40 +0000 (19:55 +0500)]
Use std::string::empty() instead of size() where applicable

10 years agoAdd basic support for generating API documentation using Doxygen
Jürgen Doser [Wed, 30 Jan 2013 17:21:32 +0000 (18:21 +0100)]
Add basic support for generating API documentation using Doxygen

If CMake is run and Doxygen is found, add a make target called "doc",
which builds API documention in doc/html. This target is not included
in the default "all" target, you have to explicitly run "make doc" to
generate the documentation.

If graphviz is installed, in particular, if the "dot" binary is found,
doxygen is configured to generate various kinds of diagrams. Note that
due to this, the first run of doxygen can take a while.

10 years agoSettings: Fix invalid memory access when setting not found in working mem
kwolekr [Fri, 12 Dec 2014 19:39:36 +0000 (14:39 -0500)]
Settings: Fix invalid memory access when setting not found in working mem

10 years agoNodeResolver: Fix some comments and use const references for params
kwolekr [Fri, 12 Dec 2014 19:21:41 +0000 (14:21 -0500)]
NodeResolver: Fix some comments and use const references for params

10 years agoAdd minetest.clear_registered_decorations() and clear_registered_ores()
kwolekr [Fri, 12 Dec 2014 19:07:49 +0000 (14:07 -0500)]
Add minetest.clear_registered_decorations() and clear_registered_ores()

10 years agoAllow footstep sounds to play for liquid and ladder nodes, making swimming and climbi...
MirceaKitsune [Sun, 7 Dec 2014 21:47:52 +0000 (23:47 +0200)]
Allow footstep sounds to play for liquid and ladder nodes, making swimming and climbing sounds possible

10 years agoResponsive tooltip offset for Android.
Kodexky [Tue, 2 Dec 2014 03:32:41 +0000 (23:02 -0430)]
Responsive tooltip offset for Android.

Signed-off-by: Craig Robbins <kde.psych@gmail.com>
10 years agoFix typo in mapblock.h
Craig Robbins [Fri, 12 Dec 2014 08:06:36 +0000 (18:06 +1000)]
Fix typo in mapblock.h

10 years agoLuaPerlinNoiseMap: Prevent invalid memory access when attempting to generate 3d noise...
kwolekr [Fri, 12 Dec 2014 07:46:52 +0000 (02:46 -0500)]
LuaPerlinNoiseMap: Prevent invalid memory access when attempting to generate 3d noise with a buffer created for 2d

10 years agoMapgens: Rename m_emerge to prevent name collisions
kwolekr [Fri, 12 Dec 2014 07:38:39 +0000 (02:38 -0500)]
Mapgens: Rename m_emerge to prevent name collisions

10 years agoAdd support for NoiseParams in minetest.get_perlin() and add docs on NoiseParams...
kwolekr [Fri, 12 Dec 2014 07:02:26 +0000 (02:02 -0500)]
Add support for NoiseParams in minetest.get_perlin() and add docs on NoiseParams to lua_api.txt

10 years agoRevert "Adjust the values of dirs1 and dirs2 so that rotate_and_place orients texture...
Craig Robbins [Fri, 12 Dec 2014 06:21:29 +0000 (16:21 +1000)]
Revert "Adjust the values of dirs1 and dirs2 so that rotate_and_place orients textures correctly"

This reverts commit 9878e8de4fdf232ebb77b396766c339786c01218.

See: https://github.com/minetest/minetest/issues/1939 and IRC log for discussion

10 years agoSettings: Fail on invalid sequence and throw exception for LuaSettings
kwolekr [Fri, 12 Dec 2014 05:44:17 +0000 (00:44 -0500)]
Settings: Fail on invalid sequence and throw exception for LuaSettings

10 years agoSettings: Sanitize value for multiline terminator tokens
kwolekr [Fri, 12 Dec 2014 04:25:42 +0000 (23:25 -0500)]
Settings: Sanitize value for multiline terminator tokens

10 years agoFix undeclared globals in functions and shorten lines in misc_helpers.lua.
paramat [Fri, 12 Dec 2014 01:10:19 +0000 (01:10 +0000)]
Fix undeclared globals in functions and shorten lines in misc_helpers.lua.

10 years agoClean up Noise macros
kwolekr [Thu, 11 Dec 2014 07:53:10 +0000 (02:53 -0500)]
Clean up Noise macros

10 years agoNodeResolver: Fix cancelNode and cancelNodeList
kwolekr [Thu, 11 Dec 2014 05:41:54 +0000 (00:41 -0500)]
NodeResolver: Fix cancelNode and cancelNodeList

10 years agoNoise: Automatically transform noise maps if needed
kwolekr [Thu, 11 Dec 2014 04:35:37 +0000 (23:35 -0500)]
Noise: Automatically transform noise maps if needed

10 years agoMove get_schematic and read_schematic to l_mapgen.cpp
kwolekr [Wed, 10 Dec 2014 06:49:57 +0000 (01:49 -0500)]
Move get_schematic and read_schematic to l_mapgen.cpp

10 years agoBiome API: Reduce heat and humidity persistences to 0.5
paramat [Wed, 10 Dec 2014 06:25:03 +0000 (06:25 +0000)]
Biome API: Reduce heat and humidity persistences to 0.5

10 years agoAdd support for lacunarity in legacy NoiseParams string format
kwolekr [Wed, 10 Dec 2014 06:31:21 +0000 (01:31 -0500)]
Add support for lacunarity in legacy NoiseParams string format

10 years agoAdd paste command (Ctrl-V) in GUIChatConsole
Kahrl [Fri, 19 Sep 2014 20:26:38 +0000 (22:26 +0200)]
Add paste command (Ctrl-V) in GUIChatConsole

10 years agoRemove get_noiseparams function. read_noiseparams should be used from now on
kwolekr [Wed, 10 Dec 2014 05:56:44 +0000 (00:56 -0500)]
Remove get_noiseparams function. read_noiseparams should be used from now on

10 years agoNoise: Create a deep copy of NoiseParams
kwolekr [Wed, 10 Dec 2014 05:37:09 +0000 (00:37 -0500)]
Noise: Create a deep copy of NoiseParams

10 years agoSettings: Sanitize setting name everywhere, not just LuaSettings
kwolekr [Wed, 10 Dec 2014 04:52:13 +0000 (23:52 -0500)]
Settings: Sanitize setting name everywhere, not just LuaSettings

10 years agoRename and repurpose minetest.set_noiseparam_defaults to set_noiseparams
kwolekr [Wed, 10 Dec 2014 04:44:04 +0000 (23:44 -0500)]
Rename and repurpose minetest.set_noiseparam_defaults to set_noiseparams

10 years agoSettings: Make setting entry group and values mutually exclusive
kwolekr [Wed, 10 Dec 2014 04:22:38 +0000 (23:22 -0500)]
Settings: Make setting entry group and values mutually exclusive

This greatly reduces the complexity of Settings code.
Additionally, several memory leaks were fixed.

10 years agoRewrite fs:GetDirListing(file) by kahrl
SmallJoker [Tue, 9 Dec 2014 16:58:12 +0000 (02:58 +1000)]
Rewrite fs:GetDirListing(file) by kahrl

10 years agoIgnore .name directories and files
SmallJoker [Sun, 7 Dec 2014 10:14:52 +0000 (11:14 +0100)]
Ignore .name directories and files

Signed-off-by: Craig Robbins <kde.psych@gmail.com>
10 years agoIncrease performance of getLight() by at least 2x
Craig Robbins [Tue, 9 Dec 2014 14:45:07 +0000 (00:45 +1000)]
Increase performance of getLight() by at least 2x

Leads to the following increases:
getSmoothLight() approx.     40% increase
getTileInfo() approx.        25% increase
MapBlockMesh::MapBlockMesh() 25-30%

10 years agoFix builds failing on BSD-like (such as OSX) due to an irrlicht bug (temporary fix)
Pavel Puchkin [Tue, 9 Dec 2014 10:40:09 +0000 (20:40 +1000)]
Fix builds failing on BSD-like (such as OSX) due to an irrlicht bug (temporary fix)

Details:
- https://sourceforge.net/p/irrlicht/bugs/433/
- https://github.com/minetest/minetest/issues/1687#issuecomment-61368769
- https://forum.minetest.net/viewtopic.php?f=42&t=9190&start=125#p159364

In case when "settings.h" is included from "emerge.cpp" or
"environment.cpp", u64 type has "unsigned long" length because
previously <stdint> was included. When "settings.h" is included from
"settings.cpp", u64 has "unsigned long long" length because no <stdint>
was included previously. This leads to different signatures of "setU64" method
and linker cannot find appropriate symbol.

The best fix of this bug should be done in the Irrlicht, but as hotfix I
think this is OK and better than types changing.

Previously this bug didn't appear because there was no "settings.cpp" file and
implementation of all methods was done in the header file.

10 years agoNoise: Update Noise::resizeNoiseBuf to account for lacunarity not equal to 2
kwolekr [Tue, 9 Dec 2014 05:48:00 +0000 (00:48 -0500)]
Noise: Update Noise::resizeNoiseBuf to account for lacunarity not equal to 2

10 years agoBiomes: Make biome heat and humidity noise parameters user-configurable
kwolekr [Tue, 9 Dec 2014 05:37:48 +0000 (00:37 -0500)]
Biomes: Make biome heat and humidity noise parameters user-configurable

10 years agoFix compiler warning (signed vs. unsigned)
Craig Robbins [Mon, 8 Dec 2014 12:50:39 +0000 (22:50 +1000)]
Fix compiler warning (signed vs. unsigned)

10 years agoOptimize noise implementations
kwolekr [Mon, 8 Dec 2014 08:25:14 +0000 (03:25 -0500)]
Optimize noise implementations

10 years agoFix struct vs. class in forward declarations
Kahrl [Mon, 8 Dec 2014 08:06:31 +0000 (09:06 +0100)]
Fix struct vs. class in forward declarations

10 years agoFix lighting artifacts (Issue #1887).
RealBadAngel [Mon, 8 Dec 2014 01:34:29 +0000 (02:34 +0100)]
Fix lighting artifacts (Issue #1887).

10 years agoAlways escape user provided data in mainmenu fields
Kahrl [Mon, 8 Dec 2014 06:47:51 +0000 (07:47 +0100)]
Always escape user provided data in mainmenu fields

10 years agoAdd flags and lacunarity as new noise parameters
kwolekr [Mon, 8 Dec 2014 02:57:12 +0000 (21:57 -0500)]
Add flags and lacunarity as new noise parameters

Add 'absolute value' option to noise map functions
Extend persistence modulation to 3D noise
Extend 'eased' option to noise2d_perlin* functions
Some noise.cpp formatting fixups

10 years agoDisable loading .mtl files. Theyre not used anyway.
RealBadAngel [Sun, 7 Dec 2014 22:25:51 +0000 (23:25 +0100)]
Disable loading .mtl files. Theyre not used anyway.

10 years agoMake directional fog colors respect tonemap
MirceaKitsune [Wed, 30 Apr 2014 13:38:26 +0000 (16:38 +0300)]
Make directional fog colors respect tonemap

10 years agoFix f6 debug/profiler display
Craig Robbins [Sun, 7 Dec 2014 11:01:42 +0000 (21:01 +1000)]
Fix f6 debug/profiler display

After fonts were re-engineered the height of the f6 debug/profiler display would only display about 2-3 lines of text.

10 years agoIncrease third person view distance
Calinou [Sun, 26 Oct 2014 10:26:36 +0000 (11:26 +0100)]
Increase third person view distance

Signed-off-by: Craig Robbins <kde.psych@gmail.com>
10 years agoAdd space between client names in status text (client)
Muhammad Rifqi Priyo Susanto [Sun, 7 Dec 2014 11:30:21 +0000 (21:30 +1000)]
Add space between client names in status text (client)

Before:
Server: version=0.4.10, uptime=190.5, max_lag=0.001, clients={user1,user2,user3,user4,user5,foobar,userplayedminetestthismorning}

After:
Server: version=0.4.10, uptime=190.5, max_lag=0.001, clients={user1, user2, user3, user4, user5, foobar, userplayedminetestthismorning}

10 years agoRestore finalColorBlend implementation in shaders.
RealBadAngel [Sat, 6 Dec 2014 21:13:31 +0000 (22:13 +0100)]
Restore finalColorBlend implementation in shaders.

10 years agoFix regression (increase/decrease viewing range with +/- keys)
Craig Robbins [Sun, 7 Dec 2014 08:21:13 +0000 (18:21 +1000)]
Fix regression (increase/decrease viewing range with +/- keys)

10 years agoMapgen V5: Fix use of uninitialized value in ctor
kwolekr [Sun, 7 Dec 2014 06:19:42 +0000 (01:19 -0500)]
Mapgen V5: Fix use of uninitialized value in ctor

10 years agoSchematics: Fix minetest.place_schematic() when defined by a Lua table
kwolekr [Sat, 6 Dec 2014 23:39:05 +0000 (18:39 -0500)]
Schematics: Fix minetest.place_schematic() when defined by a Lua table

10 years agoAdd minetest.clear_registered_biomes() api
kwolekr [Sat, 6 Dec 2014 23:08:08 +0000 (18:08 -0500)]
Add minetest.clear_registered_biomes() api

10 years agoIgnore some mouse events sent from scrollbar to GUITable
Kahrl [Sat, 6 Dec 2014 21:45:20 +0000 (22:45 +0100)]
Ignore some mouse events sent from scrollbar to GUITable

Fixes #1567, #1806.

10 years agoClose settings files and save them correctly
SmallJoker [Sat, 6 Dec 2014 16:26:22 +0000 (17:26 +0100)]
Close settings files and save them correctly

10 years agoAdd workaround for failing clang build
sfan5 [Sat, 6 Dec 2014 18:36:40 +0000 (19:36 +0100)]
Add workaround for failing clang build

10 years agoBuild for win32 & win64 on Travis too
sfan5 [Fri, 5 Dec 2014 14:54:19 +0000 (15:54 +0100)]
Build for win32 & win64 on Travis too

10 years agoRewrite generate notification mechanism
kwolekr [Sat, 6 Dec 2014 09:18:04 +0000 (04:18 -0500)]
Rewrite generate notification mechanism

Add support for notify-on-decoration
Clean up mapgen constructors
Clean up mapgen.cpp code style somewhat
Remove trailing whitespace from some files

10 years agoPerformance of main client loop up to 2x faster In places, up to 3 times faster
Craig Robbins [Sat, 6 Dec 2014 14:37:37 +0000 (00:37 +1000)]
Performance of main client loop up to 2x faster In places, up to 3 times faster

NOTE 1: This does not mean a 2x increase in framerate. Increase in fps may be up to 1-2fps
NOTE 2: This local 'caching' of settings is not optimal and an alternative solution will be worked on after 0.4.11 is released

10 years agoAdd Lua helper functions vector.apply(v) math.sign(x, tolerance)
SmallJoker [Fri, 5 Dec 2014 22:18:52 +0000 (23:18 +0100)]
Add Lua helper functions vector.apply(v) math.sign(x, tolerance)

10 years agoAdd name of node 'pointed at' to debug
Craig Robbins [Thu, 20 Nov 2014 07:25:01 +0000 (17:25 +1000)]
Add name of node 'pointed at' to debug

This is "Add name of node pointed at to debug #1677" by @rubenwardy updated to work with game.cpp after it was refactored.

10 years agoFix MSVC build
SmallJoker [Fri, 5 Dec 2014 06:09:49 +0000 (16:09 +1000)]
Fix MSVC build

Note: The unit test was technically incorrect for all platforms but passes due to implicit casting