Dr. Stephen Henson [Tue, 26 Jun 2001 12:04:12 +0000 (12:04 +0000)]
Handle empty X509_NAME in printing routines.
Bodo Möller [Tue, 26 Jun 2001 09:48:56 +0000 (09:48 +0000)]
DSA verification should insist that r and s are in the allowed range.
Bodo Möller [Tue, 26 Jun 2001 09:48:17 +0000 (09:48 +0000)]
DSA verification should insist that r and s are in the allowed range.
Richard Levitte [Mon, 25 Jun 2001 14:23:36 +0000 (14:23 +0000)]
Make better use of load_cert, load_certs and load_key.
Richard Levitte [Mon, 25 Jun 2001 14:12:45 +0000 (14:12 +0000)]
Make get_ip() a bit more strict in it's parsing of IP addresses, and
at the same time a bit more accepting with host names.
Richard Levitte [Mon, 25 Jun 2001 14:00:47 +0000 (14:00 +0000)]
Make better use of load_cert, load_certs and load_key.
Bodo Möller [Mon, 25 Jun 2001 10:09:55 +0000 (10:09 +0000)]
Translate into valid C (don't call functions with wrong prototypes).
Richard Levitte [Mon, 25 Jun 2001 08:35:59 +0000 (08:35 +0000)]
Call apps_shutdown() to take down what apps_startup() set up.
Richard Levitte [Sun, 24 Jun 2001 07:00:41 +0000 (07:00 +0000)]
Make sure we don't return 0 on error.
Dr. Stephen Henson [Sat, 23 Jun 2001 23:07:34 +0000 (23:07 +0000)]
In {RSA,DSA,DH}_new_method(x) need to increase the reference
count of the ENGINE is x is not NULL since it will be freed
in {RSA,DSA,DH}_free().
Richard Levitte [Sat, 23 Jun 2001 16:46:14 +0000 (16:46 +0000)]
Use the new UI features, among others the new boolean input.
NOTE: Boolean input hasn't been very well tested yet, so this part may
fail miserably.
Richard Levitte [Sat, 23 Jun 2001 16:44:15 +0000 (16:44 +0000)]
Including stdio.h before setting _XOPEN_SOURCE and
_XOPEN_SOURCE_EXTENDED wasn't very smart...
Richard Levitte [Sat, 23 Jun 2001 16:43:03 +0000 (16:43 +0000)]
make update
Richard Levitte [Sat, 23 Jun 2001 16:37:32 +0000 (16:37 +0000)]
Use apps_shutdown() in all applications, in case someone decides not
to go the monolith way (does anyone do that these days?).
NOTE: a few applications are missing in this commit. I've a few more
changes in them that I haven't tested yet.
Richard Levitte [Sat, 23 Jun 2001 16:31:41 +0000 (16:31 +0000)]
apps_startup() needs a corresponding apps_shutdown().
Richard Levitte [Sat, 23 Jun 2001 16:30:14 +0000 (16:30 +0000)]
Make use of new features in UI's. Among others, the application
password callbak doesn't need to check for sizes any more.
Richard Levitte [Sat, 23 Jun 2001 16:28:21 +0000 (16:28 +0000)]
Oops, applies to 0.9.7 only.
Richard Levitte [Sat, 23 Jun 2001 16:27:37 +0000 (16:27 +0000)]
Document recent changes.
Richard Levitte [Sat, 23 Jun 2001 16:25:56 +0000 (16:25 +0000)]
Do not loop i the OpenSSL UI method any more. Instead, letthe
application do that.
NOTE: there's no requirement for other UI_METHODs to avoid this kind
of loop. For example, a GUI UI_METHOD would probably check the
lengths of the answers from within instead of being constantly
redisplayed for everything that is wrong.
Richard Levitte [Sat, 23 Jun 2001 16:23:17 +0000 (16:23 +0000)]
make update
Richard Levitte [Sat, 23 Jun 2001 16:22:48 +0000 (16:22 +0000)]
Implement boolean (yes/no or OK/Cancel, ...) input.
Implement UI controls. Current controls are the possibility to output
the OpenSSL error stack on the same channel from within UI_process()
and to check if the same user interface can be redone without being
rebuilt (this is often more a question of philosophy than
technicalities).
Richard Levitte [Sat, 23 Jun 2001 15:06:17 +0000 (15:06 +0000)]
New error printing function that gives the possibility to print the
errors through an arbitrary function.
Richard Levitte [Sat, 23 Jun 2001 15:04:51 +0000 (15:04 +0000)]
Include the UI error strings.
Richard Levitte [Sat, 23 Jun 2001 14:51:53 +0000 (14:51 +0000)]
For the UI functions that return an int, 0 or any positive number is a
success return, any negative number is a failure. Make sure we check
the return value with that in mind.
Dr. Stephen Henson [Sat, 23 Jun 2001 12:50:06 +0000 (12:50 +0000)]
Fix hwcrhk_insert_card.
Dr. Stephen Henson [Sat, 23 Jun 2001 12:48:46 +0000 (12:48 +0000)]
Fix UI leak in apps.
Dr. Stephen Henson [Sat, 23 Jun 2001 11:51:16 +0000 (11:51 +0000)]
In UI_dup_*() function, use the duped string, not the original.
Dr. Stephen Henson [Sat, 23 Jun 2001 11:49:33 +0000 (11:49 +0000)]
Update my config entry to allow use of DSOs.
Andy Polyakov [Fri, 22 Jun 2001 19:17:42 +0000 (19:17 +0000)]
This fixes "Spurious test failures on IRIX?" reported in April. Apparently
I was wrong in conclusions about when addition starts overflowing in combaX
routines.
Dr. Stephen Henson [Thu, 21 Jun 2001 12:19:10 +0000 (12:19 +0000)]
Fix memory leak when RAND is used: need to cleanup
RANDs ENGINE reference in ENGINE_cleanup().
Richard Levitte [Wed, 20 Jun 2001 15:11:15 +0000 (15:11 +0000)]
Update my status.
Richard Levitte [Wed, 20 Jun 2001 15:00:08 +0000 (15:00 +0000)]
Since there is a way to create UI_METHODs, implement a destructor as
well.
This probably requires reference counters and locks as well. To be
implemented later.
Richard Levitte [Wed, 20 Jun 2001 06:35:46 +0000 (06:35 +0000)]
Modify "openssl engine" to handle and display internal control
commands appropriately.
Dr. Stephen Henson [Tue, 19 Jun 2001 22:30:40 +0000 (22:30 +0000)]
Change all calls to low level digest routines in the library and
applications to use EVP. Add missing calls to HMAC_cleanup() and
don't assume HMAC_CTX can be copied using memcpy().
Note: this is almost identical to the patch submitted to openssl-dev
by Verdon Walker <VWalker@novell.com> except some redundant
EVP_add_digest_()/EVP_cleanup() calls were removed and some changes
made to avoid compiler warnings.
Dr. Stephen Henson [Tue, 19 Jun 2001 17:13:48 +0000 (17:13 +0000)]
Fix memory leaks.
Richard Levitte [Tue, 19 Jun 2001 16:40:36 +0000 (16:40 +0000)]
cp is only used when DSA is built.
Richard Levitte [Tue, 19 Jun 2001 16:34:53 +0000 (16:34 +0000)]
Do a proof of concept. "openssl genrsa" will make the name of the
file part of the password prompt unless it's standard input...
More will be added...
Richard Levitte [Tue, 19 Jun 2001 16:26:30 +0000 (16:26 +0000)]
Change the common application routines to use a UI_METHOD for password
prompting, even when done through the callback.
Richard Levitte [Tue, 19 Jun 2001 16:12:18 +0000 (16:12 +0000)]
- Add the possibility to control engines through control names but
with arbitrary arguments instead of just a string.
- Change the key loaders to take a UI_METHOD instead of a callback
function pointer. NOTE: this breaks binary compatibility with
earlier versions of OpenSSL [engine].
- Addapt the nCipher code for these new conditions and add a card
insertion callback.
Richard Levitte [Tue, 19 Jun 2001 15:54:47 +0000 (15:54 +0000)]
The default flag should be for default passwords only. Otherwise,
someone having a default that is not a password will be confused.
Richard Levitte [Tue, 19 Jun 2001 15:52:00 +0000 (15:52 +0000)]
Enhance the user interface with better support for dialog box
prompting, application-defined prompts, the possibility to use
defaults (for example default passwords from somewhere else) and
interrupts/cancelations.
Dr. Stephen Henson [Tue, 19 Jun 2001 00:23:47 +0000 (00:23 +0000)]
make apps compile again
Dr. Stephen Henson [Tue, 19 Jun 2001 00:09:20 +0000 (00:09 +0000)]
Don't set *pointer if add_lock_callback used.
Dr. Stephen Henson [Tue, 19 Jun 2001 00:04:57 +0000 (00:04 +0000)]
Don't set pointer if add_lock_callback used.
Richard Levitte [Mon, 18 Jun 2001 06:30:12 +0000 (06:30 +0000)]
One feature wasn't quite commited yet
Richard Levitte [Mon, 18 Jun 2001 06:22:33 +0000 (06:22 +0000)]
Provide an application-common setup function for engines and use it
everywhere.
Ben Laurie [Sun, 17 Jun 2001 14:42:57 +0000 (14:42 +0000)]
Fix a memory leak (there's another around here somewhere, though).
PR:
Ben Laurie [Sat, 16 Jun 2001 21:51:26 +0000 (21:51 +0000)]
Delete a redundant line.
Bodo Möller [Fri, 15 Jun 2001 18:06:06 +0000 (18:06 +0000)]
pay attention to blocksize before attempting decryption
Bodo Möller [Fri, 15 Jun 2001 18:05:09 +0000 (18:05 +0000)]
pay attention to blocksize before attempting decryption
Bodo Möller [Mon, 11 Jun 2001 15:21:33 +0000 (15:21 +0000)]
For MSDOS, the tty filename still is "con", not "/dev/tty" ...
Andy Polyakov [Mon, 11 Jun 2001 12:47:52 +0000 (12:47 +0000)]
Get rid of "possible WAW dependency" warnings.
Submitted by:
Reviewed by:
PR:
Bodo Möller [Mon, 11 Jun 2001 09:55:54 +0000 (09:55 +0000)]
even use of default engines leaks memory
Bodo Möller [Mon, 11 Jun 2001 09:55:20 +0000 (09:55 +0000)]
Add directory name to the entry on /crypto/ui/.
Bodo Möller [Mon, 11 Jun 2001 09:54:28 +0000 (09:54 +0000)]
Earlier OpenSSL versions printed prompts to stderr.
In the new crypto/ui/, this was changed into tty (which is usually
/dev/tty), i.e. the FILE * used for reading passwords from the user.
However stdio buffering for read/write streams is not without pitfalls
(passwords would be echoed on some systems).
To avoid problems, split tty into tty_in and tty_out (which are
opened separately).
Dr. Stephen Henson [Mon, 11 Jun 2001 00:48:09 +0000 (00:48 +0000)]
Make update
Dr. Stephen Henson [Mon, 11 Jun 2001 00:45:33 +0000 (00:45 +0000)]
Initialize UI ex_data.
Dr. Stephen Henson [Mon, 11 Jun 2001 00:43:20 +0000 (00:43 +0000)]
Add support for MS CSP Name PKCS#12 attribute.
Ulf Möller [Fri, 8 Jun 2001 14:17:12 +0000 (14:17 +0000)]
as in head
Ulf Möller [Fri, 8 Jun 2001 14:16:39 +0000 (14:16 +0000)]
more error codes fixed
Lutz Jänicke [Thu, 7 Jun 2001 17:22:01 +0000 (17:22 +0000)]
ERR_peek_error() returns "unsigned long".
Lutz Jänicke [Thu, 7 Jun 2001 17:20:50 +0000 (17:20 +0000)]
ERR_peek_error() returns "unsigned long".
Richard Levitte [Thu, 7 Jun 2001 04:45:55 +0000 (04:45 +0000)]
Use memmove() instead of memcpy() on areas that may overlap.
Spotted by Nalin Dahyabhai <nalin@redhat.com>
Richard Levitte [Thu, 7 Jun 2001 04:42:34 +0000 (04:42 +0000)]
Use memmove() instead of memcpy() on areas that may overlap.
Spotted by Nalin Dahyabhai <nalin@redhat.com>
Richard Levitte [Wed, 6 Jun 2001 23:12:41 +0000 (23:12 +0000)]
Don't forget to initialise.
Bodo Möller [Wed, 6 Jun 2001 21:44:48 +0000 (21:44 +0000)]
OAEP fix
Bodo Möller [Wed, 6 Jun 2001 21:44:28 +0000 (21:44 +0000)]
OAEP fix
Bodo Möller [Wed, 6 Jun 2001 18:48:57 +0000 (18:48 +0000)]
when checking OAEP, signal just a single kind of 'decoding error'
Bodo Möller [Wed, 6 Jun 2001 18:48:49 +0000 (18:48 +0000)]
when checking OAEP, signal just a single kind of 'decoding error'
Ulf Möller [Wed, 6 Jun 2001 17:24:03 +0000 (17:24 +0000)]
as in head
Ulf Möller [Wed, 6 Jun 2001 17:23:23 +0000 (17:23 +0000)]
move check to avoid memory leak.
Ulf Möller [Wed, 6 Jun 2001 17:17:53 +0000 (17:17 +0000)]
make sure we don't write to seed[-1]
Ulf Möller [Wed, 6 Jun 2001 17:15:47 +0000 (17:15 +0000)]
make sure we don't write to seed[-1]
Richard Levitte [Tue, 5 Jun 2001 20:32:36 +0000 (20:32 +0000)]
'make update'
Richard Levitte [Tue, 5 Jun 2001 20:29:26 +0000 (20:29 +0000)]
Defining __USE_XOPEN_EXTENDED was the wrong thing. Instead, define
_XOPEN_SOURCE.
Richard Levitte [Tue, 5 Jun 2001 19:05:52 +0000 (19:05 +0000)]
A good use of the UI interface is as a password callback replacement
(for new functions...). One might still want to be able to pass down
a user-data pointer to be used by the UI. However, ex_data doesn't
quite cut it, since that means the appropriate index to it might need
to be shared between parts that aren't really related in that sense,
and would require the currently hidden (static) index holders to be
uncovered. Not a good thing. Therefore, add the possibility to add a
user-data pointer to a UI.
Richard Levitte [Tue, 5 Jun 2001 04:41:57 +0000 (04:41 +0000)]
Small detail about AIX forgotten...
Richard Levitte [Mon, 4 Jun 2001 16:34:39 +0000 (16:34 +0000)]
Accept digits in symbol names. Spotted by Brian Havard <brianh@kheldar.apana.org.au>
Richard Levitte [Mon, 4 Jun 2001 16:34:31 +0000 (16:34 +0000)]
Accept digits in symbol names. Spotted by Brian Havard <brianh@kheldar.apana.org.au>
Richard Levitte [Mon, 4 Jun 2001 16:23:15 +0000 (16:23 +0000)]
More info on SRP.
Richard Levitte [Mon, 4 Jun 2001 06:51:43 +0000 (06:51 +0000)]
Added more info in SRP.
Richard Levitte [Fri, 1 Jun 2001 15:30:13 +0000 (15:30 +0000)]
Confusion between algorithms resolved.
Richard Levitte [Fri, 1 Jun 2001 15:29:32 +0000 (15:29 +0000)]
nCipher callbacks shall return 0 on success, something else otherwise.
Richard Levitte [Fri, 1 Jun 2001 15:21:01 +0000 (15:21 +0000)]
Stop mishandling the type number in dynlock locking
Bodo Möller [Fri, 1 Jun 2001 09:43:23 +0000 (09:43 +0000)]
Fix Bleichenbacher PKCS #1 1.5 countermeasure.
(The attack against SSL 3.1 and TLS 1.0 is impractical anyway,
otherwise this would be a security relevant patch.)
Bodo Möller [Fri, 1 Jun 2001 09:41:25 +0000 (09:41 +0000)]
Fix Bleichenbacher PKCS #1 1.5 countermeasure.
(The attack against SSL 3.1 and TLS 1.0 is impractical anyway,
otherwise this would be a security relevant patch.)
Bodo Möller [Fri, 1 Jun 2001 08:39:02 +0000 (08:39 +0000)]
increase DEFAULT_BUFFER_SIZE (4K instead of just 1K)
Bodo Möller [Fri, 1 Jun 2001 08:38:29 +0000 (08:38 +0000)]
increase DEFAULT_BUFFER_SIZE (4K instead of just 1K)
Richard Levitte [Fri, 1 Jun 2001 05:36:44 +0000 (05:36 +0000)]
From revision 1.25, 2001/05/31 22:25:30 by levitte
Don't decrement the reference counter twice when destroying dynamic
links.
Richard Levitte [Thu, 31 May 2001 22:25:30 +0000 (22:25 +0000)]
Don't decrement the reference counter twice when destroying dynamic
links.
Geoff Thorpe [Thu, 31 May 2001 19:01:08 +0000 (19:01 +0000)]
Fix a memory leak in 'sk_dup' in the case a realloc() fails. Also, tidy up
a bit of weird code in sk_new.
Andy Polyakov [Wed, 30 May 2001 22:01:33 +0000 (22:01 +0000)]
Get rid of RAW dependency warnings.
Submitted by:
Reviewed by:
PR:
Richard Levitte [Wed, 30 May 2001 15:29:28 +0000 (15:29 +0000)]
Extend all the loading functions to take an engine pointer, a pass
string (some engines may have certificates protected by a PIN!) and
a description to put into error messages.
Also, have our own password callback that we can send both a password
and some prompt info to. The default password callback in EVP assumes
that the passed parameter is a password, which isn't always the right
thing, and the ENGINE code (at least the nCipher one) makes other
assumptions...
Also, in spite of having the functions to load keys, some utilities
did the loading all by themselves... That's changed too.
Richard Levitte [Wed, 30 May 2001 14:59:14 +0000 (14:59 +0000)]
A wish was expressed.
Lutz Jänicke [Tue, 29 May 2001 13:52:21 +0000 (13:52 +0000)]
Don't forget responsible person so that its clear who is to blame.
Andy Polyakov [Mon, 28 May 2001 20:02:51 +0000 (20:02 +0000)]
Assembler support for IA-64. See the source code commentary for further
details (performance numbers and accompanying discussions:-). Note that
the code is not engaged in ./Configure yet. I'll add it later this week
along with updates for .spec file.
Submitted by:
Reviewed by:
PR:
Richard Levitte [Sat, 26 May 2001 16:58:34 +0000 (16:58 +0000)]
Document the latest change in ENGINEs.
Richard Levitte [Fri, 25 May 2001 21:08:56 +0000 (21:08 +0000)]
We had the password callback for ENGINEs pretty much wrong. And
passwords that were given to the key loading functions were completely
ignored, at least in the ncipher code, and then we made the assumption
that the callback wanted a prompt as user argument.
All that is now changed, and the application author is forced to give
a callback function of type pem_callback_cb and possibly an argument
for it, just as for all other functions that want to generate password
prompting.
NOTE: this change creates binary and source incompatibilities with
previous versions of OpenSSL [engine]. It's worth it this time, to
get it right (or at least better and with a chance that it'll work).
Dr. Stephen Henson [Thu, 24 May 2001 23:00:46 +0000 (23:00 +0000)]
Add missing variable length cipher flag for Blowfish.
Only use trust settings if either trust or reject settings
are present, otherwise use compatibility mode. This stops
root CAs being rejected if they have alias of keyid set.
Dr. Stephen Henson [Thu, 24 May 2001 22:58:35 +0000 (22:58 +0000)]
Add missing variable length cipher flag for Blowfish.
Only use trust settings if either trust or reject settings
are present, otherwise use compatibility mode. This stops
root CAs being rejected if they have alias of keyid set.