oweals/openssl.git
20 years agoCorrect minor spelling error.
Richard Levitte [Sun, 21 Mar 2004 23:03:55 +0000 (23:03 +0000)]
Correct minor spelling error.
PR: 845

20 years agoChange \t to real tab in echo argument.
Richard Levitte [Sun, 21 Mar 2004 22:50:24 +0000 (22:50 +0000)]
Change \t to real tab in echo argument.
PR: 847

20 years agoRemove a warning for conversion double->long. This has impacts on Windows.
Richard Levitte [Sun, 21 Mar 2004 22:39:59 +0000 (22:39 +0000)]
Remove a warning for conversion double->long.  This has impacts on Windows.
PR: 849

20 years agoMake sure fd is defined where it should.
Richard Levitte [Sun, 21 Mar 2004 22:36:30 +0000 (22:36 +0000)]
Make sure fd is defined where it should.
PR: 849

20 years agoMerge from HEAD:
Richard Levitte [Fri, 19 Mar 2004 00:20:12 +0000 (00:20 +0000)]
Merge from HEAD:

2003-04-03 22:03  levitte

* apps/apps.c (1.70): Don't try to free NULL values...

Notified by "Steven Reddie" <smr@essemer.com.au>

20 years agoAfter tagging
Mark J. Cox [Wed, 17 Mar 2004 12:03:38 +0000 (12:03 +0000)]
After tagging

20 years agoFix null-pointer assignment in do_change_cipher_spec() revealed
Mark J. Cox [Wed, 17 Mar 2004 12:01:19 +0000 (12:01 +0000)]
Fix null-pointer assignment in do_change_cipher_spec() revealed
by using the Codenomicon TLS Test Tool (CAN-2004-0079)
Fix flaw in SSL/TLS handshaking when using Kerberos ciphersuites
(CAN-2004-0112)
Ready for 0.9.7d build

Submitted by: Steven Henson
Reviewed by: Joe Orton
Approved by: Mark Cox

20 years agoAvoid warnings.
Dr. Stephen Henson [Tue, 16 Mar 2004 13:50:18 +0000 (13:50 +0000)]
Avoid warnings.

20 years agoAs in 0.9.8-dev, make sure we use unsigned constants, or some
Richard Levitte [Mon, 15 Mar 2004 23:06:59 +0000 (23:06 +0000)]
As in 0.9.8-dev, make sure we use unsigned constants, or some
compilers may complain.

20 years agoFix typo in "IRIX 6.x shared build fix-up."
Andy Polyakov [Fri, 12 Mar 2004 21:33:04 +0000 (21:33 +0000)]
Fix typo in "IRIX 6.x shared build fix-up."

20 years agoIRIX 6.x shared build fix-up.
Andy Polyakov [Fri, 12 Mar 2004 21:24:45 +0000 (21:24 +0000)]
IRIX 6.x shared build fix-up.

20 years agoIncorporate crlNumber functionality from 0.9.8 except it is commented out
Dr. Stephen Henson [Mon, 8 Mar 2004 13:07:07 +0000 (13:07 +0000)]
Incorporate crlNumber functionality from 0.9.8 except it is commented out
in openssl.cnf .

20 years agoIncorporate the following changes from 0.9.8-dev:
Richard Levitte [Mon, 8 Mar 2004 02:53:46 +0000 (02:53 +0000)]
Incorporate the following changes from 0.9.8-dev:

2003-04-04 17:10  levitte

* apps/: apps.c (1.72), apps.h (1.56), ca.c (1.135), x509.c (1.82):
  Convert save_serial() to work like save_index(), and add a
  rotate_serial() that works like rotate_index().

2003-04-03 20:07  levitte

* apps/: apps.c (1.69), ca.c (1.130): Conditionalise all debug
  strings.

2003-04-03 18:33  levitte

* apps/apps.c (1.68), apps/apps.h (1.55), apps/ca.c (1.129),
  apps/ocsp.c (1.31), apps/openssl.cnf (1.24), apps/x509.c (1.80),
  CHANGES (1.1139): Make it possible to have multiple active
  certificates with the same subject.

20 years agoCleanup ASN1 OID module when it exits.
Dr. Stephen Henson [Fri, 5 Mar 2004 23:47:39 +0000 (23:47 +0000)]
Cleanup ASN1 OID module when it exits.

20 years agoCall autoconfig code in pkcs7 utility.
Dr. Stephen Henson [Fri, 5 Mar 2004 23:45:08 +0000 (23:45 +0000)]
Call autoconfig code in pkcs7 utility.

20 years agoMemory leak fix.
Dr. Stephen Henson [Fri, 5 Mar 2004 23:39:12 +0000 (23:39 +0000)]
Memory leak fix.

20 years agoVarious X509 fixes. Disable broken certificate workarounds
Dr. Stephen Henson [Fri, 5 Mar 2004 17:16:06 +0000 (17:16 +0000)]
Various X509 fixes. Disable broken certificate workarounds
when X509_V_FLAG_X509_STRICT is set. Check for CRLSign in
CRL issuer certificates. Reject CRLs with unhandled (any)
critical extensions.

20 years ago-passin argument to rsautl
Dr. Stephen Henson [Thu, 4 Mar 2004 21:58:13 +0000 (21:58 +0000)]
-passin argument to rsautl

20 years agoTypos.
Dr. Stephen Henson [Thu, 4 Mar 2004 21:41:59 +0000 (21:41 +0000)]
Typos.

Reported by: Jose Castejon-Amenedo <Jose.Castejon-Amenedo@hp.com>

20 years agoMake our page with pointers to binary distributions visible in the FAQ
Richard Levitte [Thu, 4 Mar 2004 07:48:00 +0000 (07:48 +0000)]
Make our page with pointers to binary distributions visible in the FAQ

20 years agoMore configuration docs.
Dr. Stephen Henson [Tue, 2 Mar 2004 12:46:30 +0000 (12:46 +0000)]
More configuration docs.

20 years agoDocumentation of the KISS autoconfig functions.
Dr. Stephen Henson [Tue, 2 Mar 2004 01:00:24 +0000 (01:00 +0000)]
Documentation of the KISS autoconfig functions.

20 years agoMore autoconfig docs.
Dr. Stephen Henson [Mon, 1 Mar 2004 19:15:54 +0000 (19:15 +0000)]
More autoconfig docs.

20 years agoAvoid a memory leak in OCSP_parse_url().
Richard Levitte [Mon, 1 Mar 2004 14:58:25 +0000 (14:58 +0000)]
Avoid a memory leak in OCSP_parse_url().
Notified by Paul Siegel <psiegel@corestreet.com>

20 years agoFix from head.
Dr. Stephen Henson [Mon, 1 Mar 2004 13:23:41 +0000 (13:23 +0000)]
Fix from head.

20 years agoInitial docs for the OpenSSL library configuration via openssl.cnf
Dr. Stephen Henson [Mon, 1 Mar 2004 01:04:58 +0000 (01:04 +0000)]
Initial docs for the OpenSSL library configuration via openssl.cnf

20 years agoAES is spelled AES, not ASE. Oops...
Richard Levitte [Fri, 27 Feb 2004 02:24:54 +0000 (02:24 +0000)]
AES is spelled AES, not ASE.  Oops...

20 years agoMake sure the given EVP_PKEY is updated in the PEM_STRING_PKCS8INF case also.
Richard Levitte [Thu, 26 Feb 2004 22:07:47 +0000 (22:07 +0000)]
Make sure the given EVP_PKEY is updated in the PEM_STRING_PKCS8INF case also.
PR: 833

20 years agoDocument the AES options for 'openssl smime'.
Richard Levitte [Thu, 26 Feb 2004 21:44:43 +0000 (21:44 +0000)]
Document the AES options for 'openssl smime'.
PR: 834

20 years agoUse an OCTET STRING for the encoding of an OCSP nonce value.
Dr. Stephen Henson [Thu, 19 Feb 2004 18:17:35 +0000 (18:17 +0000)]
Use an OCTET STRING for the encoding of an OCSP nonce value.

The old raw format can't be handled by some implementations
and updates to RFC2560 will make the OCTET STRING mandatory.

20 years agoFix handling of -offset and -length in asn1parse tool.
Dr. Stephen Henson [Sun, 8 Feb 2004 13:30:33 +0000 (13:30 +0000)]
Fix handling of -offset and -length in asn1parse tool.

If -offset exceeds -length of data available exit with an error.

Don't read past end of total data available when -offset supplied.

If -length exceeds total available truncate it.

20 years agoTypo in crypto/bn/asm/x86_64.c, bn_div_words().
Andy Polyakov [Sat, 7 Feb 2004 09:46:47 +0000 (09:46 +0000)]
Typo in crypto/bn/asm/x86_64.c, bn_div_words().
PR: 821

20 years agoAdd flag to avoid continuous
Dr. Stephen Henson [Sun, 1 Feb 2004 13:37:56 +0000 (13:37 +0000)]
Add flag to avoid continuous
memory allocate when calling EVP_MD_CTX_copy_ex().

Without this HMAC is several times slower than
< 0.9.7.

20 years agomake update
Richard Levitte [Thu, 29 Jan 2004 10:23:54 +0000 (10:23 +0000)]
make update

20 years agoHave the declarations match the definitions.
Richard Levitte [Thu, 29 Jan 2004 09:41:01 +0000 (09:41 +0000)]
Have the declarations match the definitions.

20 years agoTypo
Richard Levitte [Thu, 29 Jan 2004 02:55:47 +0000 (02:55 +0000)]
Typo

20 years agoMake n unsigned, to avoid signed vs. unsigned conflicts.
Richard Levitte [Thu, 29 Jan 2004 00:05:54 +0000 (00:05 +0000)]
Make n unsigned, to avoid signed vs. unsigned conflicts.

20 years ago-Wstrict-prototypes is too much for 0.9.7-stable (there are tons of
Richard Levitte [Thu, 29 Jan 2004 00:03:05 +0000 (00:03 +0000)]
-Wstrict-prototypes is too much for 0.9.7-stable (there are tons of
non-strict prototypes, all right?  Kind of shadows the few other
warnings so I keep missing them :-)).

20 years ago0.9.7-stable is in freeze. That means we do bug fixes only, not new
Richard Levitte [Wed, 28 Jan 2004 23:31:20 +0000 (23:31 +0000)]
0.9.7-stable is in freeze.  That means we do bug fixes only, not new
functionality.  Therefore, I'm backing out most of the "CFB DES
sync-up with FIPS branch" commit (I'm keeping the corrections of
DES_cfb_encrypt()).

20 years agoUnsigned vs. signed problem removed
Richard Levitte [Wed, 28 Jan 2004 08:48:15 +0000 (08:48 +0000)]
Unsigned vs. signed problem removed

20 years agoCFB DES sync-up with FIPS branch.
Andy Polyakov [Tue, 27 Jan 2004 21:46:19 +0000 (21:46 +0000)]
CFB DES sync-up with FIPS branch.

20 years agoAvoid signed vs. unsigned warnings (which are treated like errors on
Richard Levitte [Tue, 27 Jan 2004 01:16:09 +0000 (01:16 +0000)]
Avoid signed vs. unsigned warnings (which are treated like errors on
Windows).

20 years agoS_IFBLK and S_IFCHR may not exist in some places (like Windows), so
Richard Levitte [Mon, 26 Jan 2004 23:46:03 +0000 (23:46 +0000)]
S_IFBLK and S_IFCHR may not exist in some places (like Windows), so
let's check for those macros, and if they aren't defined, let's assume
there aren't Unixly devices on this platform.

20 years agoTypo...
Richard Levitte [Thu, 22 Jan 2004 22:36:48 +0000 (22:36 +0000)]
Typo...

20 years agoReplace expired certificate.
Dr. Stephen Henson [Wed, 21 Jan 2004 13:04:58 +0000 (13:04 +0000)]
Replace expired certificate.

20 years agoTABLE update for hpux64-paric2-gcc, addenum for HPUX64 gcc build update.
Andy Polyakov [Wed, 21 Jan 2004 10:07:23 +0000 (10:07 +0000)]
TABLE update for hpux64-paric2-gcc, addenum for HPUX64 gcc build update.

20 years agoProper support for HP-UX64 gcc build.
Andy Polyakov [Wed, 21 Jan 2004 09:58:18 +0000 (09:58 +0000)]
Proper support for HP-UX64 gcc build.
PR: 772

20 years agoSHA-1 assembler tune-up for Intel P4
Andy Polyakov [Wed, 21 Jan 2004 08:19:36 +0000 (08:19 +0000)]
SHA-1 assembler tune-up for Intel P4

20 years agoAdding a slash between the directoryt and the file is a problem with
Richard Levitte [Sat, 10 Jan 2004 18:04:36 +0000 (18:04 +0000)]
Adding a slash between the directoryt and the file is a problem with
VMS.  The C RTL can handle it well if the "directory" is a logical
name with no colon, therefore ending being 'logname/file'.  However,
if the given logical names actually has a colon, or if you use a full
VMS-syntax directory, you end up with 'logname:/file' or
'dev:[dir1.dir2]/file', and that isn't handled in any good way.

So, on VMS, we need to check if the directory string ends with a
separator (one of ':', ']' or '>' (< and > can be used instead [ and
])), and handle that by not inserting anything between the directory
spec and the file name.  In all other cases, it's assumed the
directory spec is a logical name, so we need to place a colon between
it and the file.

Notified by Kevin Greaney <kevin.greaney@hp.com>.

20 years agoCover all DSA setups when running tests
Lutz Jänicke [Thu, 8 Jan 2004 07:46:12 +0000 (07:46 +0000)]
Cover all DSA setups when running tests
PR: #748
Submitted by: Kirill Kochetkov <kochet@ixbt.com>

20 years agoUpdates to s_time manual page
Lutz Jänicke [Thu, 8 Jan 2004 07:39:33 +0000 (07:39 +0000)]
Updates to s_time manual page
PR: #570
Submitted by: Martin Witzel <MWITZEL@de.ibm.com>

20 years agoOne more change to merge from -dev.
Lutz Jänicke [Sun, 4 Jan 2004 19:03:51 +0000 (19:03 +0000)]
One more change to merge from -dev.

20 years agoAdd s_time manual page
Lutz Jänicke [Sun, 4 Jan 2004 19:00:17 +0000 (19:00 +0000)]
Add s_time manual page
Submitted by: "Martin Witzel" <MWITZEL@de.ibm.com>

PR: #570

20 years agoThis commit was manufactured by cvs2svn to create branch
cvs2svn [Sun, 4 Jan 2004 18:59:15 +0000 (18:59 +0000)]
This commit was manufactured by cvs2svn to create branch
'OpenSSL_0_9_7-stable'.

20 years agoAdd s_time manual page
Lutz Jänicke [Sun, 4 Jan 2004 18:59:14 +0000 (18:59 +0000)]
Add s_time manual page
Submitted by: "Martin Witzel" <MWITZEL@de.ibm.com>

PR: #570

20 years agoUpdate URI
Lutz Jänicke [Sun, 4 Jan 2004 18:06:51 +0000 (18:06 +0000)]
Update URI
Submitted by: Gertjan van Oosten <gertjan@West.NL>

PR: #804

20 years agoUpdate URI
Lutz Jänicke [Sun, 4 Jan 2004 18:05:50 +0000 (18:05 +0000)]
Update URI
Submitted by: Gertjan van Oosten <gertjan@West.NL>

PR: #804

20 years agounintptr_t and <inttypes.h> are not strictly portable with respect to
Lutz Jänicke [Sun, 4 Jan 2004 17:54:02 +0000 (17:54 +0000)]
unintptr_t and <inttypes.h> are not strictly portable with respect to
ANSI C 89.
Undo change to maintain compatibility.

20 years agounintptr_t and <inttypes.h> are not strictly portable with respect to
Lutz Jänicke [Sun, 4 Jan 2004 17:53:21 +0000 (17:53 +0000)]
unintptr_t and <inttypes.h> are not strictly portable with respect to
ANSI C 89.
Undo change to maintain compatibility.

20 years agoFix Perl problems on sparc64.
Richard Levitte [Sat, 27 Dec 2003 16:13:18 +0000 (16:13 +0000)]
Fix Perl problems on sparc64.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoFix Perl problems on sparc64.
Richard Levitte [Sat, 27 Dec 2003 16:13:16 +0000 (16:13 +0000)]
Fix Perl problems on sparc64.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoAvoid including cryptlib.h, it's not really needed.
Richard Levitte [Sat, 27 Dec 2003 16:10:30 +0000 (16:10 +0000)]
Avoid including cryptlib.h, it's not really needed.
Check if IDEA is being built or not.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoAvoid including cryptlib.h, it's not really needed.
Richard Levitte [Sat, 27 Dec 2003 16:09:59 +0000 (16:09 +0000)]
Avoid including cryptlib.h, it's not really needed.
Check if IDEA is being built or not.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoOnly use environment variables if uid and gid are the same as euid and egid.
Richard Levitte [Sat, 27 Dec 2003 16:07:20 +0000 (16:07 +0000)]
Only use environment variables if uid and gid are the same as euid and egid.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoOnly use environment variables if uid and gid are the same as euid and egid.
Richard Levitte [Sat, 27 Dec 2003 16:07:18 +0000 (16:07 +0000)]
Only use environment variables if uid and gid are the same as euid and egid.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoCheck if a random "file" is really a device file, and treat it
Richard Levitte [Sat, 27 Dec 2003 16:02:22 +0000 (16:02 +0000)]
Check if a random "file" is really a device file, and treat it
specially if it is.
Add a few OpenBSD-specific cases.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoCheck if a random "file" is really a device file, and treat it
Richard Levitte [Sat, 27 Dec 2003 16:01:52 +0000 (16:01 +0000)]
Check if a random "file" is really a device file, and treat it
specially if it is.
Add a few OpenBSD-specific cases.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoCorrect documentation typos.
Richard Levitte [Sat, 27 Dec 2003 15:05:26 +0000 (15:05 +0000)]
Correct documentation typos.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoCorrect documentation typos.
Richard Levitte [Sat, 27 Dec 2003 15:04:54 +0000 (15:04 +0000)]
Correct documentation typos.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoOpenBSD-internal changes.
Richard Levitte [Sat, 27 Dec 2003 15:02:56 +0000 (15:02 +0000)]
OpenBSD-internal changes.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoOpenBSD-internal changes.
Richard Levitte [Sat, 27 Dec 2003 15:02:54 +0000 (15:02 +0000)]
OpenBSD-internal changes.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoUse sh explicitely to run point.sh
Richard Levitte [Sat, 27 Dec 2003 15:00:24 +0000 (15:00 +0000)]
Use sh explicitely to run point.sh
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoUse sh explicitely to run point.sh
Richard Levitte [Sat, 27 Dec 2003 14:59:07 +0000 (14:59 +0000)]
Use sh explicitely to run point.sh
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoInclude strings.h so strcasecmp() and strncasecmp() get properly declared.
Richard Levitte [Sat, 27 Dec 2003 14:54:48 +0000 (14:54 +0000)]
Include strings.h so strcasecmp() and strncasecmp() get properly declared.

20 years agoUse BUF_strlcpy() instead of strcpy().
Richard Levitte [Sat, 27 Dec 2003 14:40:57 +0000 (14:40 +0000)]
Use BUF_strlcpy() instead of strcpy().
Use BUF_strlcat() instead of strcat().
Use BIO_snprintf() instead of sprintf().
In some cases, keep better track of buffer lengths.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoUse BUF_strlcpy() instead of strcpy().
Richard Levitte [Sat, 27 Dec 2003 14:40:17 +0000 (14:40 +0000)]
Use BUF_strlcpy() instead of strcpy().
Use BUF_strlcat() instead of strcat().
Use BIO_snprintf() instead of sprintf().
In some cases, keep better track of buffer lengths.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoAdd a newline at the end of the last line.
Richard Levitte [Sat, 27 Dec 2003 14:26:15 +0000 (14:26 +0000)]
Add a newline at the end of the last line.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoAdd a newline at the end of the last line.
Richard Levitte [Sat, 27 Dec 2003 14:26:14 +0000 (14:26 +0000)]
Add a newline at the end of the last line.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>

20 years agoChange 'exp' to something else, as 'exp' is predefined by GNU C. This
Richard Levitte [Sat, 27 Dec 2003 14:24:20 +0000 (14:24 +0000)]
Change 'exp' to something else, as 'exp' is predefined by GNU C.  This
was already done in HEAD, but not in this branch (I wonder why...).

20 years agoTypos.
Dr. Stephen Henson [Sat, 20 Dec 2003 22:49:05 +0000 (22:49 +0000)]
Typos.

20 years agoTypos.
Dr. Stephen Henson [Sat, 20 Dec 2003 22:48:21 +0000 (22:48 +0000)]
Typos.

20 years agoTo figure out if we're going outside the buffer, use the size of the buffer,
Richard Levitte [Thu, 11 Dec 2003 18:01:06 +0000 (18:01 +0000)]
To figure out if we're going outside the buffer, use the size of the buffer,
not the size of the integer used to index in said buffer.

PR: 794
Notified by: Rhett Garber <rhett_garber@hp.com>

20 years agoTo figure out if we're going outside the buffer, use the size of the buffer,
Richard Levitte [Thu, 11 Dec 2003 18:01:03 +0000 (18:01 +0000)]
To figure out if we're going outside the buffer, use the size of the buffer,
not the size of the integer used to index in said buffer.

PR: 794
Notified by: Rhett Garber <rhett_garber@hp.com>

20 years agoDocument that you need to include x509.h (to get [i2d|d2i]_RSA_PUBKEY()).
Richard Levitte [Wed, 10 Dec 2003 14:31:57 +0000 (14:31 +0000)]
Document that you need to include x509.h (to get [i2d|d2i]_RSA_PUBKEY()).
Correct the typo PUKEY...

20 years agoDocument that you need to include x509.h (to get [i2d|d2i]_RSA_PUBKEY()).
Richard Levitte [Wed, 10 Dec 2003 14:31:55 +0000 (14:31 +0000)]
Document that you need to include x509.h (to get [i2d|d2i]_RSA_PUBKEY()).
Correct the typo PUKEY...

20 years agoDocument that you need to include x509.h (to get [i2d|d2i]_DSA_PUBKEY()).
Richard Levitte [Wed, 10 Dec 2003 13:57:52 +0000 (13:57 +0000)]
Document that you need to include x509.h (to get [i2d|d2i]_DSA_PUBKEY()).
Correct the typo PUKEY...

20 years agoDocument that you need to include x509.h (to get [i2d|d2i]_DSA_PUBKEY()).
Richard Levitte [Wed, 10 Dec 2003 13:57:51 +0000 (13:57 +0000)]
Document that you need to include x509.h (to get [i2d|d2i]_DSA_PUBKEY()).
Correct the typo PUKEY...

20 years agoAdd "dif" variable to clean up the loop implementations.
Ulf Möller [Sat, 6 Dec 2003 11:55:46 +0000 (11:55 +0000)]
Add "dif" variable to clean up the loop implementations.

Submitted by: Nils Larsch

20 years agoSkip a curve with generator of non-prime order.
Ulf Möller [Sat, 6 Dec 2003 11:41:22 +0000 (11:41 +0000)]
Skip a curve with generator of non-prime order.

Submitted by: Nils Larsch

20 years agoAvoid segfault if ret==0.
Ulf Möller [Sat, 6 Dec 2003 11:39:37 +0000 (11:39 +0000)]
Avoid segfault if ret==0.

Submitted by: Nils Larsch

21 years agoRestructure make targets to allow parallel make.
Lutz Jänicke [Wed, 3 Dec 2003 16:29:41 +0000 (16:29 +0000)]
Restructure make targets to allow parallel make.
Submitted by: Witold Filipczyk <witekfl@poczta.gazeta.pl>

PR: #513

21 years agoRestructure make targets to allow parallel make.
Lutz Jänicke [Wed, 3 Dec 2003 16:29:16 +0000 (16:29 +0000)]
Restructure make targets to allow parallel make.
Submitted by: Witold Filipczyk <witekfl@poczta.gazeta.pl>

PR: #513

21 years agoIncremental cleanups to bn_lib.c.
Geoff Thorpe [Tue, 2 Dec 2003 20:01:30 +0000 (20:01 +0000)]
Incremental cleanups to bn_lib.c.
- Add missing bn_check_top() calls and relocate some others
- Use BN_is_zero() where appropriate
- Remove assert()s that bn_check_top() is already covering
- Simplify the code in places (esp. bn_expand2())
- Only keep ambiguous zero handling if BN_STRICT isn't defined
- Remove some white-space and make some other aesthetic tweaks

21 years agoUse the BN_is_odd() macro in place of code that (inconsistently) does much
Geoff Thorpe [Tue, 2 Dec 2003 03:28:24 +0000 (03:28 +0000)]
Use the BN_is_odd() macro in place of code that (inconsistently) does much
the same thing.

Also, I have some stuff on the back-burner related to some BN_CTX notes
from Peter Gutmann about his cryptlib hacks to the bignum code. The BN_CTX
comments are there to remind me of some relevant points in the code.

21 years agoBN_FLG_FREE is of extremely dubious usefulness, and is only referred to
Geoff Thorpe [Tue, 2 Dec 2003 03:16:56 +0000 (03:16 +0000)]
BN_FLG_FREE is of extremely dubious usefulness, and is only referred to
once in the source (where it is set for the benefit of no other code
whatsoever). I've deprecated the declaration in the header and likewise
made the use of the flag conditional in bn_lib.c. Note, this change also
NULLs the 'd' pointer in a BIGNUM when it is reset but not deallocated.

21 years agoDeclare the static BIGNUM "BN_value_one()" more carefully.
Geoff Thorpe [Mon, 1 Dec 2003 23:13:17 +0000 (23:13 +0000)]
Declare the static BIGNUM "BN_value_one()" more carefully.

21 years agoAdd missing bn_check_top()s to bn_kron.c, remove some miscellaneous
Geoff Thorpe [Mon, 1 Dec 2003 23:11:45 +0000 (23:11 +0000)]
Add missing bn_check_top()s to bn_kron.c, remove some miscellaneous
white-space, and include extra headers to satisfy debugging builds.

21 years agoAdd missing bn_check_top()s to bn_gf2m.c and remove some miscellaneous
Geoff Thorpe [Mon, 1 Dec 2003 23:10:21 +0000 (23:10 +0000)]
Add missing bn_check_top()s to bn_gf2m.c and remove some miscellaneous
white-space.

21 years agoThe bn_set_max() macro is only "used" by the bn_set_[low|high]() macros
Geoff Thorpe [Mon, 1 Dec 2003 22:11:08 +0000 (22:11 +0000)]
The bn_set_max() macro is only "used" by the bn_set_[low|high]() macros
which, in turn, are used nowhere at all. This is a good thing because
bn_set_max() would currently generate code that wouldn't compile (BIGNUM
has no 'max' element).

The only apparent use for bn_set_[low|high] would be for implementing
windowing algorithms, and all of openssl's seem to use bn_***_words()
helpers instead (including the BN_div() that Nils fixed recently, which had
been using independently-coded versions of what these unused macros are
intended for). I'm therefore consigning these macros to cvs oblivion in the
name of readability.

21 years agobn_fix_top() exists for compatibility's sake and is mapped to
Geoff Thorpe [Mon, 1 Dec 2003 21:59:40 +0000 (21:59 +0000)]
bn_fix_top() exists for compatibility's sake and is mapped to
bn_correct_top() or bn_check_top() depending on debug settings. For
internal source, all bn_fix_top()s should be converted one way or the other
depending on whether the use of bn_correct_top() is justified.

For BN_div_recp(), these cases should not require correction if the other
bignum functions are doing their jobs properly, so convert to
bn_check_top().