Ralf Friedl [Tue, 9 Aug 2011 02:49:27 +0000 (04:49 +0200)]
df: more compatible -P behavior
In coreutils df, one of the effects of the option -P is to output
everything in one line. This makes it much easier for a script to parse
the output of df.
This patch adds the same behavior to busybox df.
function old new delta
df_main 853 863 +10
Signed-off-by: Ralf Friedl <Ralf.Friedl@online.de>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Thomas Petazzoni [Tue, 9 Aug 2011 02:41:00 +0000 (04:41 +0200)]
zcip.script: fix $ip environment variable
The environment variable containing the IP address allocated by zcip
is "ip" and not "IP".
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Tito Ragusa [Tue, 9 Aug 2011 02:37:50 +0000 (04:37 +0200)]
users: new applet.
Signed-off-by: Tito Ragusa <farmatito@tiscali.it>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Pere Orga [Tue, 9 Aug 2011 02:09:17 +0000 (04:09 +0200)]
uptime: add config flag to allow displaying the number of users currently logged on
Signed-off-by: Pere Orga <gotrunks@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Tue, 9 Aug 2011 02:05:13 +0000 (04:05 +0200)]
die_if_bad_username: tighten up a bit
function old new delta
die_if_bad_username 77 97 +20
Based on patches from Tito.
The changes are:
better comments
we disallow '@' now - in practice such usernames will be unusable
use of the portable filename character set plus '$'
don't use isalnum as it allows non-ASCII letters in legacy 8-bit locales (pointed out by Rich Felker)
enforce maximum length of LOGIN_NAME_MAX (including NUL)
don't allow '$', '.', and '-' as first char
don't print the illegal char in error message as if it is a wide char it will be unreadable
print the position of the illegal character
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 1 Aug 2011 16:16:43 +0000 (18:16 +0200)]
hush: fix remaining known two bugs with IFS expansion. Closes 4027.
function old new delta
expand_vars_to_list 1054 1140 +86
parse_stream 2425 2479 +54
expand_on_ifs 258 310 +52
builtin_umask 133 132 -1
done_word 820 779 -41
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/2 up/down: 192/-42) Total: 150 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 1 Aug 2011 12:06:20 +0000 (14:06 +0200)]
hush: partially fix wrong expansion on $IFS (bug 4027).
In the added testcase, before patch we failed 8 out of 9 tests,
now we fail only 2 (4th and 5th).
function old new delta
expand_on_ifs 225 258 +33
expand_vars_to_list 1038 1054 +16
o_save_ptr_helper 115 119 +4
builtin_umask 132 133 +1
o_addQstr 165 161 -4
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 4/1 up/down: 54/-4) Total: 50 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Ian Wienand [Fri, 29 Jul 2011 06:33:47 +0000 (08:33 +0200)]
tar: ignore file size (assume 0) for hardlinks
Signed-off-by: Ian Wienand <ianw@vmware.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Tue, 26 Jul 2011 11:42:12 +0000 (13:42 +0200)]
*: work around sysinfo.h versus linux/*.h problems
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 25 Jul 2011 14:35:44 +0000 (16:35 +0200)]
tcpudp: simplify help text
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 25 Jul 2011 13:23:52 +0000 (15:23 +0200)]
less: add a TODO comment
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 25 Jul 2011 13:18:20 +0000 (15:18 +0200)]
less: optionally query terminal size via "ESC [ 6 n". Closes bug 2659.
+7 bytes is not selected, +100 if selected.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 25 Jul 2011 09:05:43 +0000 (11:05 +0200)]
libbb.h: do not use homegrown struct sysinfo.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 23 Jul 2011 15:41:00 +0000 (17:41 +0200)]
android_defconfig: remove some extra cflags. untested
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Daniel Fandrich [Tue, 19 Jul 2011 06:10:05 +0000 (08:10 +0200)]
add defconfig files for Android, Cygwin and FreeBSD
Also added an example script to show how to compile BusyBox against
Android's bionic.
Signed-off-by: Daniel Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Fri, 15 Jul 2011 06:37:36 +0000 (08:37 +0200)]
dc: fix a case where we can run off malloced space
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Kevin Cernekee [Wed, 13 Jul 2011 07:30:36 +0000 (09:30 +0200)]
cttyhack: fail gracefully if the device node is missing
Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Kevin Cernekee [Wed, 13 Jul 2011 07:26:58 +0000 (09:26 +0200)]
cttyhack: check sysfs for the name of the active console
Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Wed, 13 Jul 2011 07:06:32 +0000 (09:06 +0200)]
fdisk: reinstate a short sleep between sync() and ioctl(BLKRRPART)
While at it, simplify code a bit.
function old new delta
write_table 201 198 -3
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 11 Jul 2011 05:36:59 +0000 (07:36 +0200)]
libbb/lineedit: implement optional Ctrl-R history search
function old new delta
read_line_input 3433 3957 +524
load_string 77 90 +13
input_tab 1086 1069 -17
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/1 up/down: 537/-17) Total: 520 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Lauri Kasanen [Fri, 8 Jul 2011 08:56:58 +0000 (10:56 +0200)]
bloat-o-meter: don't require that pythin is in /usr/bin.
Signed-off-by: Lauri Kasanen <curaga@operamail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Fri, 8 Jul 2011 06:53:16 +0000 (08:53 +0200)]
make configs/* files have _defconfig suffix
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Fri, 8 Jul 2011 06:49:40 +0000 (08:49 +0200)]
more tweak for bionic
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Fri, 8 Jul 2011 06:37:57 +0000 (08:37 +0200)]
usleep: do not check for usleep error, it should never fail
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Fri, 8 Jul 2011 06:34:28 +0000 (08:34 +0200)]
a few tweaks for bionic
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Daniel Fandrich [Fri, 8 Jul 2011 05:59:16 +0000 (07:59 +0200)]
Support configuring Busybox from _defconfig files
The existing test .config files are moved to configs/ and renamed
to *_defconfig. 'make xyz_defconfig' will enable the
configuration in that specific file.
Signed-off-by: Daniel Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Fri, 8 Jul 2011 04:40:25 +0000 (06:40 +0200)]
hwclock: use locale-specific date output format
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Fri, 8 Jul 2011 04:23:08 +0000 (06:23 +0200)]
halt: perror_msg_and_die needs bb_ prefix
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Dan Fandrich [Fri, 8 Jul 2011 03:47:49 +0000 (05:47 +0200)]
typo fixes
Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Fri, 8 Jul 2011 02:41:38 +0000 (04:41 +0200)]
platform.h: tweaks for cygwin
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 4 Jul 2011 02:34:57 +0000 (04:34 +0200)]
hwclock: better help text
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Lauri Kasanen [Sun, 3 Jul 2011 23:49:59 +0000 (01:49 +0200)]
md5/shaNsum: make -c support a list of files
function old new delta
md5_sha1_sum_main 455 473 +18
Signed-off-by: Lauri Kasanen <curaga@operamail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sun, 3 Jul 2011 01:19:43 +0000 (03:19 +0200)]
vi: tweak regex.h include
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 2 Jul 2011 23:46:02 +0000 (01:46 +0200)]
halt/reboot: better message if /sbin/telinit is not found
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Dan Fandrich [Thu, 30 Jun 2011 00:59:17 +0000 (02:59 +0200)]
Use the _unlocked stdio macros only when they're all available
Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Thu, 30 Jun 2011 00:44:27 +0000 (02:44 +0200)]
libbb.h: tweak _unlocked hack
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Dan Fandrich [Wed, 29 Jun 2011 06:03:27 +0000 (23:03 -0700)]
Use the built-in getline on more systems that don't have it
Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Timo Teras [Wed, 29 Jun 2011 00:19:58 +0000 (02:19 +0200)]
platform.c: provide getline implementation
Signed-off-by: Timo Teras <timo.teras@iki.fi>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Walter Harms [Mon, 27 Jun 2011 00:59:37 +0000 (02:59 +0200)]
vi: fix regex search, make it selectable in config
function old new delta
char_search 134 214 +80
find_pair 187 169 -18
mycmp 37 - -37
Signed-off-by: Walter Harms <wharms@bfs.de>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Wed, 22 Jun 2011 14:42:36 +0000 (16:42 +0200)]
id: correct getgroups usage
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Wed, 22 Jun 2011 02:17:49 +0000 (04:17 +0200)]
groups: make it NOEXEC
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Tue, 21 Jun 2011 15:12:52 +0000 (17:12 +0200)]
ls: fix HAVE_STRVERSCMP check; add check for older uclibc versions
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Tito Ragusa [Tue, 21 Jun 2011 15:11:40 +0000 (17:11 +0200)]
groups: new applet
Signed-off-by: Tito Ragusa <farmatito@tiscali.it>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Tue, 21 Jun 2011 14:38:29 +0000 (16:38 +0200)]
Add HAVE_STRVERSCMP, guard the only usage of strverscmp with #ifdef
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Dan Fandrich [Mon, 20 Jun 2011 08:22:18 +0000 (10:22 +0200)]
setserial: added missing \n in help text
Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 20 Jun 2011 08:06:28 +0000 (10:06 +0200)]
libbb: use _unlocked variants of stdio I/O.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Timo Teras [Mon, 20 Jun 2011 07:49:56 +0000 (09:49 +0200)]
parse_config: use getline. BIG speedup with glibc (~40%).
function old new delta
config_read 559 604 +45
getline - 23 +23
config_close 29 49 +20
find_pair 169 187 +18
showmode 330 338 +8
hash_find 233 234 +1
builtin_umask 133 132 -1
lzo1x_optimize 1434 1429 -5
test_main 253 247 -6
buffer_fill_and_print 196 179 -17
create_J 1849 1826 -23
config_free_data 37 - -37
------------------------------------------------------------------------------
(add/remove: 3/1 grow/shrink: 5/5 up/down: 138/-89) Total: 26 bytes
Signed-off-by: Timo Teras <timo.teras@iki.fi>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Timo Teras [Mon, 20 Jun 2011 07:38:13 +0000 (09:38 +0200)]
modprobe: use hash table. speeds up significantly if modprobe.dep is large
function old new delta
helper_get_module 106 157 +51
config_file_action 413 431 +18
modprobe_main 690 706 +16
do_modprobe 580 588 +8
add_probe 81 83 +2
load_modules_dep 192 190 -2
get_or_add_modentry 10 - -10
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 5/1 up/down: 95/-12) Total: 83 bytes
Signed-off-by: Timo Teras <timo.teras@iki.fi>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 18 Jun 2011 23:40:31 +0000 (01:40 +0200)]
diff: disable debug code; remove unsupported --dry-run from help text
function old new delta
packed_usage 28623 28602 -21
do_line 121 91 -30
patch_main 2086 1923 -163
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-214) Total: -214 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 18 Jun 2011 13:51:16 +0000 (15:51 +0200)]
libbb/read_cmdline: prepend {comm} if different from argv0. Closes 3835.
function old new delta
read_cmdline 114 233 +119
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 18 Jun 2011 13:49:47 +0000 (15:49 +0200)]
procps: remove PSSCAN_STAT define, users were using it incorrectly
Also contains small cleanups ps.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 18 Jun 2011 07:29:21 +0000 (09:29 +0200)]
fix false positive in parse test
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 18 Jun 2011 07:23:09 +0000 (09:23 +0200)]
parse_config: make test applet easier to enable; fix its code
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Fri, 17 Jun 2011 01:37:43 +0000 (03:37 +0200)]
libbb: split bb_get_chunk_from_file and bb_get_chunk_with_continuation
This also moves bb_get_chunk_with_continuation into its sole user,
parse_config.c.
This allows to optimize both functions separately,
they need to be optimized for speed.
(this need was highlighted by slow modprobe caused in part by slow
bb_get_chunk_with_continuation in config parser).
function old new delta
bb_get_chunk_from_file 7 130 +123
config_read 457 558 +101
bb_get_chunk_with_continuation 194 - -194
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 2/0 up/down: 224/-194) Total: 30 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Bernhard Reutner-Fischer [Wed, 15 Jun 2011 07:38:43 +0000 (09:38 +0200)]
inetd: check if RPC is available
It would be better to have FEATURE_HAVE_RPC be user-selectable and
depend mount.nfs and inetd-rpc on it instead of the current, backward,
way.
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Denys Vlasenko [Mon, 13 Jun 2011 00:24:18 +0000 (02:24 +0200)]
ls: fix comment about -p (it's compatible now)
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 13 Jun 2011 00:13:42 +0000 (02:13 +0200)]
ls: make -v and -X actually work as intended
function old new delta
strverscmp - 236 +236
sortcmp 186 254 +68
static.result_type - 60 +60
static.next_state 12 16 +4
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sun, 12 Jun 2011 15:15:16 +0000 (17:15 +0200)]
iplink: tweak includes to work on android
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Wade Berrier [Wed, 8 Jun 2011 21:46:55 +0000 (15:46 -0600)]
pkill/pgrep: support extended regular expressions
Done by enabling the REG_EXTENDED and REG_NOSUB regex flags,
which also increases compatibility with the procps versions.
Signed-off-by: Wade Berrier <wade_berrier@appsig.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Daniel Fandrich [Thu, 9 Jun 2011 22:44:44 +0000 (15:44 -0700)]
Replaced __u32 etc. with standard uint32_t style types
Signed-off-by: Daniel Fandrich <dfandrich@intrinsyc.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Dan Fandrich [Fri, 10 Jun 2011 03:17:59 +0000 (05:17 +0200)]
*: simplify Ethernet header includes
Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Tue, 7 Jun 2011 08:01:58 +0000 (10:01 +0200)]
build system: delete generated files on "make mrproper"
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 6 Jun 2011 02:21:39 +0000 (04:21 +0200)]
fbset: apply modelines. Closes 3823
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sun, 5 Jun 2011 13:07:31 +0000 (15:07 +0200)]
fix breakage caused by 'remove "Options:" string from help texts' commit
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sun, 5 Jun 2011 01:58:28 +0000 (03:58 +0200)]
*: remove "Options:" string from help texts
function old new delta
packed_usage 28706 28623 -83
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Maksym Kryzhanovskyy [Sun, 5 Jun 2011 01:37:14 +0000 (03:37 +0200)]
iostat: code shrink
function old new delta
iostat_main 2048 2400 +352
is_partition 48 - -48
print_stats_dev_struct 350 - -350
Signed-off-by: Maksym Kryzhanovskyy <xmaks@email.cz>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 4 Jun 2011 03:07:16 +0000 (05:07 +0200)]
udhcpc: allow -O OPT take numeric params
function old new delta
udhcpc_main 2623 2654 +31
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Fri, 3 Jun 2011 19:39:42 +0000 (21:39 +0200)]
appletlib.c: do not use PAGE_SIZE for malloc tweaking
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Dan Fandrich [Fri, 3 Jun 2011 18:51:58 +0000 (20:51 +0200)]
platform.h: support for build under Android
Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Dan Fandrich [Fri, 3 Jun 2011 18:28:14 +0000 (20:28 +0200)]
only compile obscure.c when needed
Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Dan Fandrich [Fri, 3 Jun 2011 18:25:17 +0000 (20:25 +0200)]
replace nonstandard unsigned typedefs
Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Wed, 1 Jun 2011 10:47:07 +0000 (12:47 +0200)]
hush: better comment. No code changes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Tue, 31 May 2011 15:35:45 +0000 (17:35 +0200)]
hush: fix a corner case of empty "do \n done" structure
The structure is:
while cmd; do
done
bash doesn't accept it at all. We were accepting it but execution
was buggy.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Bernhard Reutner-Fischer [Mon, 30 May 2011 21:00:47 +0000 (23:00 +0200)]
makedevs: fix help-text
pull
http://git.buildroot.net/buildroot/commit/?id=
99ead3c2ead605d6504b9abad111778dc2a93ae6
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Denys Vlasenko [Sun, 29 May 2011 02:24:13 +0000 (04:24 +0200)]
fix !ENABLE_FEATURE_GETOPT_LONG build. Closes 3775
When compiling with !ENABLE_FEATURE_GETOPT_LONG, busybox still tries
to include getopt.h which is not available; for example with uClibc
when !UCLIBC_HAS_GETOPT_LONG. getopt.h is only required
for the _long set of functions.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sun, 29 May 2011 00:03:38 +0000 (02:03 +0200)]
fuser: fix inverted access() check. Closes 3799.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Peter Korsgaard [Thu, 26 May 2011 15:51:37 +0000 (17:51 +0200)]
setconsole: open console for writing rather than reading
The console passed to TIOCCONS has to be writable, otherwise future
console writes will fail.
This presumably used to work, but in current kernels (see
drivers/tty/tty_io.c:redirected_tty_write) console writes are sent to
vfs_write(device), which checks if the device is writable. A quick look
in the linux git history doesn't show any recent changes to either tty_io
or vfs_write.
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Thu, 26 May 2011 07:00:23 +0000 (09:00 +0200)]
nmeter: trim help text
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Wed, 25 May 2011 09:58:56 +0000 (11:58 +0200)]
syslogd,klogd: better help text
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Maksym Kryzhanovskyy [Mon, 23 May 2011 01:39:48 +0000 (03:39 +0200)]
fuser: code shrink
function old new delta
scan_proc_net_or_maps - 427 +427
scan_recursive - 380 +380
search_dev_inode 74 71 -3
add_pid 39 - -39
scan_link 46 - -46
scan_dir_links 76 - -76
scan_pid_maps 222 - -222
fuser_main 871 297 -574
------------------------------------------------------------------------------
(add/remove: 2/4 grow/shrink: 0/2 up/down: 807/-960) Total: -153 bytes
Signed-off-by: Maksym Kryzhanovskyy <xmaks@email.cz>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 23 May 2011 01:39:08 +0000 (03:39 +0200)]
libbb.h: small reordering
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sun, 22 May 2011 22:40:54 +0000 (00:40 +0200)]
find: cater for libc w/o FNM_CASEFOLD
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Bogdan Harjoc [Sun, 22 May 2011 01:50:21 +0000 (03:50 +0200)]
find: implement -ipath
Signed-off-by: Bogdan Harjoc <harjoc@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sun, 22 May 2011 01:46:33 +0000 (03:46 +0200)]
reformime: do not require \r\n
function old new delta
parse 958 1063 +105
packed_usage 28691 28712 +21
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 21 May 2011 19:32:40 +0000 (21:32 +0200)]
adduser: better logic for choosing addgroup -g/--gid
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 21 May 2011 17:57:58 +0000 (19:57 +0200)]
adduser: prefer to call addgroup --gid, not non-std addgroup -g
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 21 May 2011 17:15:55 +0000 (19:15 +0200)]
od: code shrink
function old new delta
od_main 2147 2132 -15
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 21 May 2011 16:47:51 +0000 (18:47 +0200)]
od: another fix for --strings
function old new delta
od_main 2139 2147 +8
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 21 May 2011 16:38:59 +0000 (18:38 +0200)]
od: fix -S NUM to not print chars >0x80
function old new delta
write_block 433 431 -2
print_ascii 217 215 -2
check_and_close 104 96 -8
od_main 2164 2139 -25
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 21 May 2011 16:38:40 +0000 (18:38 +0200)]
od: code shrink
function old new delta
exit_code - 1 +1
open_next_file 73 72 -1
limit_bytes_to_format 1 - -1
ioerror 1 - -1
flag_pseudo_start 1 - -1
flag_dump_strings 1 - -1
od_main 2275 2164 -111
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Sat, 21 May 2011 15:43:06 +0000 (17:43 +0200)]
od: code shrink, fix "od --traditional FILE"
function old new delta
parse_old_offset 107 125 +18
packed_usage 28715 28691 -24
od_main 2312 2275 -37
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Alexey Fomenko [Fri, 20 May 2011 02:26:29 +0000 (04:26 +0200)]
lineedit: fix rare SEGV; mark a few FIXMEs
Signed-off-by: Alexey Fomenko <ext-alexey.fomenko@nokia.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Cristian Ionescu-Idbohrn [Fri, 20 May 2011 01:52:36 +0000 (03:52 +0200)]
warning removal
Signed-off-by: Cristian Ionescu-Idbohrn <cii@axis.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Thu, 19 May 2011 22:30:04 +0000 (00:30 +0200)]
tail: optimize "tail -c HUGENUM REGULAR_FILE". Closes 3763.
function old new delta
tail_main 1541 1547 +6
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Wed, 18 May 2011 10:11:19 +0000 (12:11 +0200)]
top: display sort indicator in memory display
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 16 May 2011 12:30:26 +0000 (14:30 +0200)]
busybox.conf: code shrink
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 16 May 2011 11:53:19 +0000 (13:53 +0200)]
busybox.conf: USER.GROUP is _optional_
function old new delta
main 785 809 +24
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 16 May 2011 11:19:25 +0000 (13:19 +0200)]
main: make busybox.conf mode handling less obscure
function old new delta
static.mode_mask - 20 +20
main 782 785 +3
static.mode_chars 15 13 -2
run_applet_no_and_exit 450 441 -9
mode_mask 24 - -24
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 1/2 up/down: 41/-53) Total: -12 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko [Mon, 16 May 2011 10:21:31 +0000 (12:21 +0200)]
main: free suid_config list after use
function old new delta
run_applet_no_and_exit 438 450 +12
ifupdown_main 2147 2149 +2
writeFileToTarball 1325 1326 +1
pidof_main 244 245 +1
last_main 896 897 +1
grep_main 779 780 +1
find_list_entry2 121 122 +1
tar_main 835 833 -2
llist_unlink 28 26 -2
llist_rev 23 21 -2
main 791 782 -9
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 7/4 up/down: 19/-15) Total: 4 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Cristian Ionescu-Idbohrn [Mon, 16 May 2011 01:53:43 +0000 (03:53 +0200)]
vi.c: remove warning: variable 'sp' set but not used
Signed-off-by: Cristian Ionescu-Idbohrn <cii@axis.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
projects / oweals / busybox.git / log