From: Leon M. George Date: Thu, 30 Apr 2020 08:26:36 +0000 (+0200) Subject: mac80211: fix use of local variable X-Git-Tag: v1.5.2-20200803~1 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=feac660813b09f1a9e26fcdf7be4987d2a89fac7;p=librecmc%2Flibrecmc.git mac80211: fix use of local variable mac80211_get_addr is called from mac80211_generate_mac, where the local variable initialisation id="${macidx:-0}" suggests that macidx is not always defined. Probably, idx was supposed to be used instead of $(($macidx + 1)). Fixes: 4d99db168cf7 ("mac80211: try to get interface addresses from wiphy sysfs 'addresses' if no mask is set") Signed-off-by: Leon M. George (cherry picked from commit 8f95220bcb554b1b668114e5264ebce4028c5f93) --- diff --git a/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh b/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh index 634aadcee9..36aebbb2cc 100644 --- a/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh +++ b/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh @@ -352,7 +352,7 @@ mac80211_get_addr() { local phy="$1" local idx="$(($2 + 1))" - head -n $(($macidx + 1)) /sys/class/ieee80211/${phy}/addresses | tail -n1 + head -n $idx /sys/class/ieee80211/${phy}/addresses | tail -n1 } mac80211_generate_mac() {