From: Tim <t4im@users.noreply.github.com>
Date: Tue, 5 Jul 2016 17:30:33 +0000 (+0200)
Subject: Bucket: Prevent crashing when placing liquid against a buildable node into an unknown... 
X-Git-Tag: 0.4.15~145
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=fe450b4144cfe93136849ea2c9713cce3dd21aa6;p=oweals%2Fminetest_game.git

Bucket: Prevent crashing when placing liquid against a buildable node into an unknown node
---

diff --git a/mods/bucket/init.lua b/mods/bucket/init.lua
index 2d2690fe..521a4463 100644
--- a/mods/bucket/init.lua
+++ b/mods/bucket/init.lua
@@ -88,10 +88,11 @@ function bucket.register_liquid(source, flowing, itemname, inventory_image, name
 					-- check if the node above can be replaced
 					lpos = pointed_thing.above
 					local node = minetest.get_node_or_nil(lpos)
-					if not node
-					or not minetest.registered_nodes[node.name].buildable_to then
+					local above_ndef = node and minetest.registered_nodes[node.name]
+
+					if not above_ndef or not above_ndef.buildable_to then
 						-- do not remove the bucket with the liquid
-						return
+						return itemstack
 					end
 				end