From: Matt Caswell <matt@openssl.org>
Date: Tue, 26 Apr 2016 17:28:03 +0000 (+0100)
Subject: Free an X509_CRL in an error path
X-Git-Tag: OpenSSL_1_1_0-pre6~622
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=fe2b7dfdf446088d5c1cc9dc9d49d131cc4ef7f9;p=oweals%2Fopenssl.git

Free an X509_CRL in an error path

Reviewed-by: Richard Levitte <levitte@openssl.org>
---

diff --git a/apps/apps.c b/apps/apps.c
index a3e1794c31..fca3775b77 100644
--- a/apps/apps.c
+++ b/apps/apps.c
@@ -1984,8 +1984,10 @@ static STACK_OF(X509_CRL) *crls_http_cb(X509_STORE_CTX *ctx, X509_NAME *nm)
     crldp = X509_get_ext_d2i(x, NID_crl_distribution_points, NULL, NULL);
     crl = load_crl_crldp(crldp);
     sk_DIST_POINT_pop_free(crldp, DIST_POINT_free);
-    if (!crl)
+    if (!crl) {
+        sk_X509_CRL_free(crls);
         return NULL;
+    }
     sk_X509_CRL_push(crls, crl);
     /* Try to download delta CRL */
     crldp = X509_get_ext_d2i(x, NID_freshest_crl, NULL, NULL);