From: Rich Felker Date: Mon, 23 Jan 2012 23:32:40 +0000 (-0500) Subject: fix broken copy relocations from dynamic linker cleanup X-Git-Tag: v0.8.5~48 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=fd7015d0c23edb9ae655e5ce3677f980f0cb1143;p=oweals%2Fmusl.git fix broken copy relocations from dynamic linker cleanup this issue affected programs which use global variables exported by non-libc libraries. --- diff --git a/src/ldso/dynlink.c b/src/ldso/dynlink.c index df54230c..28b86bf7 100644 --- a/src/ldso/dynlink.c +++ b/src/ldso/dynlink.c @@ -563,10 +563,13 @@ void *__dynlink(int argc, char **argv) ehdr->e_phentsize, ehdr->e_phnum); /* Load preload/needed libraries, add their symbols to the global - * namespace, and perform all remaining relocations. */ + * namespace, and perform all remaining relocations. The main + * program must be relocated LAST since it may contain copy + * relocations which depend on libraries' relocations. */ if (env_preload) load_preload(env_preload); load_deps(app); make_global(app); + reloc_all(app->next); reloc_all(app); /* Switch to runtime mode: any further failures in the dynamic