From: Jo-Philipp Wich <jow@openwrt.org>
Date: Mon, 18 Nov 2013 12:51:47 +0000 (+0000)
Subject: Clean up dead code
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=fa3386a7054aa9541decd68c8cf8de1e0d6f8832;p=oweals%2Ffirewall3.git

Clean up dead code
---

diff --git a/redirects.c b/redirects.c
index 81e93e3..18666a3 100644
--- a/redirects.c
+++ b/redirects.c
@@ -427,34 +427,6 @@ set_target_nat(struct fw3_ipt_rule *r, struct fw3_redirect *redir)
 		set_snat_dnat(r, redir->target, &redir->ip_dest, &redir->port_dest);
 }
 
-//static void
-//append_chain_filter(struct fw3_ipt_rule *r, struct fw3_redirect *redir)
-//{
-//	if (redir->target == FW3_FLAG_DNAT)
-//	{
-//		if (redir->local)
-//			fw3_ipt_rule_append(r, "zone_%s_input", redir->src.name);
-//		else
-//			fw3_ipt_rule_append(r, "zone_%s_forward", redir->src.name);
-//	}
-//	else
-//	{
-//		if (redir->src.set && !redir->src.any)
-//			fw3_ipt_rule_append(r, "zone_%s_forward", redir->src.name);
-//		else
-//			fw3_ipt_rule_append(r, "delegate_forward");
-//	}
-//}
-//
-//static void
-//set_target_filter(struct fw3_ipt_rule *r, struct fw3_redirect *redir)
-//{
-//	if (redir->local)
-//		fw3_ipt_rule_extra(r, "-m conntrack --ctstate DNAT");
-//
-//	fw3_ipt_rule_target(r, "ACCEPT");
-//}
-
 static void
 set_comment(struct fw3_ipt_rule *r, const char *name, int num, bool ref)
 {
@@ -510,25 +482,6 @@ print_redirect(struct fw3_ipt_handle *h, struct fw3_state *state,
 		append_chain_nat(r, redir);
 		break;
 
-	case FW3_TABLE_FILTER:
-		//src = &redir->ip_src;
-		//dst = &redir->ip_redir;
-		//spt = &redir->port_src;
-		//dpt = &redir->port_redir;
-		//
-		//r = fw3_ipt_rule_create(h, proto, NULL, NULL, src, dst);
-		//fw3_ipt_rule_sport_dport(r, spt, dpt);
-		//fw3_ipt_rule_mac(r, mac);
-		//fw3_ipt_rule_ipset(r, &redir->ipset);
-		//fw3_ipt_rule_limit(r, &redir->limit);
-		//fw3_ipt_rule_time(r, &redir->time);
-		//fw3_ipt_rule_mark(r, &redir->mark);
-		//set_target_filter(r, redir);
-		//fw3_ipt_rule_extra(r, redir->extra);
-		//set_comment(r, redir->name, num, false);
-		//append_chain_filter(r, redir);
-		break;
-
 	default:
 		break;
 	}
@@ -562,16 +515,6 @@ print_reflection(struct fw3_ipt_handle *h, struct fw3_state *state,
 		fw3_ipt_rule_replace(r, "zone_%s_postrouting", redir->dest.name);
 		break;
 
-	//case FW3_TABLE_FILTER:
-	//	r = fw3_ipt_rule_create(h, proto, NULL, NULL, ia, &redir->ip_redir);
-	//	fw3_ipt_rule_sport_dport(r, NULL, &redir->port_redir);
-	//	fw3_ipt_rule_limit(r, &redir->limit);
-	//	fw3_ipt_rule_time(r, &redir->time);
-	//	set_comment(r, redir->name, num, true);
-	//	fw3_ipt_rule_target(r, "zone_%s_dest_ACCEPT", redir->dest.name);
-	//	fw3_ipt_rule_replace(r, "zone_%s_forward", redir->dest.name);
-	//	break;
-
 	default:
 		break;
 	}
diff --git a/zones.c b/zones.c
index 9824249..fe507b0 100644
--- a/zones.c
+++ b/zones.c
@@ -477,11 +477,13 @@ print_zone_rule(struct fw3_ipt_handle *handle, struct fw3_state *state,
 		{
 			r = fw3_ipt_rule_new(handle);
 			fw3_ipt_rule_extra(r, "-m conntrack --ctstate DNAT");
+			fw3_ipt_rule_comment(r, "Accept port redirections");
 			fw3_ipt_rule_target(r, fw3_flag_names[FW3_FLAG_ACCEPT]);
 			fw3_ipt_rule_append(r, "zone_%s_input", zone->name);
 
 			r = fw3_ipt_rule_new(handle);
 			fw3_ipt_rule_extra(r, "-m conntrack --ctstate DNAT");
+			fw3_ipt_rule_comment(r, "Accept port forwards");
 			fw3_ipt_rule_target(r, fw3_flag_names[FW3_FLAG_ACCEPT]);
 			fw3_ipt_rule_append(r, "zone_%s_forward", zone->name);
 		}