From: Matt Caswell <matt@openssl.org>
Date: Thu, 10 Jul 2014 22:47:31 +0000 (+0100)
Subject: Fixed valgrind complaint due to BN_consttime_swap reading uninitialised data.
X-Git-Tag: master-post-reformat~587^2~4
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=f8571ce82292ed340ed6302635f9bd6dfbc1043a;p=oweals%2Fopenssl.git

Fixed valgrind complaint due to BN_consttime_swap reading uninitialised data.
This is actually ok for this function, but initialised to zero anyway if
PURIFY defined.

This does have the impact of masking any *real* unitialised data reads in bn though.

Patch based on approach suggested by Rich Salz.

PR#3415
---

diff --git a/crypto/bn/bn_lib.c b/crypto/bn/bn_lib.c
index b1e224bb4d..efa77999ff 100644
--- a/crypto/bn/bn_lib.c
+++ b/crypto/bn/bn_lib.c
@@ -324,6 +324,15 @@ static BN_ULONG *bn_expand_internal(const BIGNUM *b, int words)
 		BNerr(BN_F_BN_EXPAND_INTERNAL,ERR_R_MALLOC_FAILURE);
 		return(NULL);
 		}
+#ifdef PURIFY
+	/* Valgrind complains in BN_consttime_swap because we process the whole
+	 * array even if it's not initialised yet. This doesn't matter in that
+	 * function - what's important is constant time operation (we're not
+	 * actually going to use the data)
+	*/
+	memset(a, 0, sizeof(BN_ULONG)*words);
+#endif
+
 #if 1
 	B=b->d;
 	/* Check if the previous number needs to be copied */