From: Denis Osvald <denis.osvald@sartura.hr>
Date: Thu, 2 Jun 2016 15:06:30 +0000 (+0200)
Subject: iwinfo: zero out ccode buffer since library doesn't
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=f8174eacef9b687a83231e58fdd1e53492e3ca84;p=oweals%2Frpcd.git

iwinfo: zero out ccode buffer since library doesn't

Making an ubus call iwinfo countrylist '{"device":"radio0"}' will result
in some entries having garbage uninitialized stack bytes in the "code"
fields.

With this patch we zero-initialize the buffer that libiwinfo writes to,
making it NUL-terminated so that behavior doesn't happen anymore.

Signed-off-by: Denis Osvald <denis.osvald@sartura.hr>
---

diff --git a/iwinfo.c b/iwinfo.c
index 325c07a..b24d0f5 100644
--- a/iwinfo.c
+++ b/iwinfo.c
@@ -588,7 +588,7 @@ rpc_iwinfo_countrylist(struct ubus_context *ctx, struct ubus_object *obj,
 	int rv, len;
 	char cur[3];
 	char iso3166[3];
-	char res[IWINFO_BUFSIZE];
+	char res[IWINFO_BUFSIZE] = {0};
 	const char *ccode;
 	const struct iwinfo_iso3166_label *l;
 	void *c, *d;