From: Dan Cimpoca Date: Mon, 15 Oct 2018 10:09:56 +0000 (+0200) Subject: board: ge: bx50v3: fix initialization of i2c bus0 X-Git-Tag: v2018.11-rc3~6^2~10 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=f767a4e82e37a41414764e619607e424c6d3bc71;p=oweals%2Fu-boot.git board: ge: bx50v3: fix initialization of i2c bus0 I2C bus 0 was not initialized correctly. There is an offset between i2c index and the structure number of pad info. So i2c bus 0 can be in an inconsistent state. This problem become visible on B{4,6}50v3 with the CPUC HW watchdog enabled. Sometimes when the CPUC HW watchdog interrupted the boot process, U-Boot was not able to read VPD from I2C/EEPROM and the system failed to boot up again, because a device connected to that bus was stuck in data transfer state (from previous boot attempt) and there was no method to recover (struct mxc_i2c_bus::idle_bus_fn was not set) courtesy of incorrect initialization. Signed-off-by: Dan Cimpoca Signed-off-by: Fabien Lahoudere --- diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c index 2eb1b65a3d..245852510f 100644 --- a/board/ge/bx50v3/bx50v3.c +++ b/board/ge/bx50v3/bx50v3.c @@ -714,9 +714,9 @@ static void set_confidx(const struct vpd_cache* vpd) int board_init(void) { - setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info1); - setup_i2c(2, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info2); - setup_i2c(3, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info3); + setup_i2c(0, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info1); + setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info2); + setup_i2c(2, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info3); read_vpd(CONFIG_SYS_I2C_EEPROM_BUS);