From: Jo-Philipp Wich <jow@openwrt.org>
Date: Tue, 11 Aug 2009 16:00:26 +0000 (+0000)
Subject: applications/openvpn: properly handle invalid names when defining new instances
X-Git-Tag: 0.10.0~1207
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=f72c9704aeb762a6b51fc73ddf428c16872405ea;p=oweals%2Fluci.git

applications/openvpn: properly handle invalid names when defining new instances
---

diff --git a/applications/luci-openvpn/luasrc/model/cbi/openvpn.lua b/applications/luci-openvpn/luasrc/model/cbi/openvpn.lua
index c220b10a5..1d055a683 100644
--- a/applications/luci-openvpn/luasrc/model/cbi/openvpn.lua
+++ b/applications/luci-openvpn/luasrc/model/cbi/openvpn.lua
@@ -53,16 +53,20 @@ function s.create(self, name)
 		self.sectiontype .. ".select"
 	)
 
-	uci:section(
-		"openvpn", "openvpn", name,
-		uci:get_all( "openvpn_recipes", recipe )
-	)
+	if name and not name:match("[^a-zA-Z0-9_]") then
+		uci:section(
+			"openvpn", "openvpn", name,
+			uci:get_all( "openvpn_recipes", recipe )
+		)
 
-	uci:delete("openvpn", name, "_role")
-	uci:delete("openvpn", name, "_description")
-	uci:save("openvpn")
+		uci:delete("openvpn", name, "_role")
+		uci:delete("openvpn", name, "_description")
+		uci:save("openvpn")
 
-	luci.http.redirect( self.extedit:format(name) )
+		luci.http.redirect( self.extedit:format(name) )
+	else
+		self.invalid_cts = true
+	end
 end