From: Matt Caswell <matt@openssl.org>
Date: Tue, 8 Mar 2016 20:59:50 +0000 (+0000)
Subject: Fix memory leak in ssltest
X-Git-Tag: OpenSSL_1_1_0-pre4~208
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=f58cee8fb47da29ec44e3429e8cf630afd046b79;p=oweals%2Fopenssl.git

Fix memory leak in ssltest

The new Rand usage of Thread API exposed a bug in ssltest. ssltest "cheats"
and uses internal headers to directly call functions that normally you
wouldn't be able to do. This means that auto-init doesn't happen, and
therefore auto-deinit doesn't happen either, meaning that the new rand locks
don't get cleaned up properly.

Reviewed-by: Rich Salz <rsalz@openssl.org>
---

diff --git a/test/ssltest.c b/test/ssltest.c
index 94aeebe9c0..8d9b2c8b1d 100644
--- a/test/ssltest.c
+++ b/test/ssltest.c
@@ -3617,6 +3617,12 @@ static int do_test_cipherlist(void)
     int i = 0;
     const SSL_METHOD *meth;
     const SSL_CIPHER *ci, *tci = NULL;
+
+    /*
+     * This is required because ssltest "cheats" and uses internal headers to
+     * call functions, thus avoiding auto-init
+     */
+    OPENSSL_init_crypto(0, NULL);
 #endif
 
 #ifndef OPENSSL_NO_SSL3