From: Tom Rini <trini@ti.com>
Date: Tue, 25 Feb 2014 15:27:00 +0000 (-0500)
Subject: checkpatch.pl: Add warning for new __packed additions
X-Git-Tag: v2014.04-rc2~72^2~1
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=f503cc49a570b1e28a93b75bc912aedc93ba2cd0;p=oweals%2Fu-boot.git

checkpatch.pl: Add warning for new __packed additions

While there are valid reasons to use __packed, often the answer is that
you should be doing something else here instead.

Signed-off-by: Tom Rini <trini@ti.com>
---

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 88c5bc7735..df0820c1a1 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3331,6 +3331,11 @@ sub process {
 			WARN("PREFER_PACKED",
 			     "__packed is preferred over __attribute__((packed))\n" . $herecurr);
 		}
+# Check for new packed members, warn to use care
+		if ($line =~ /\b(__attribute__\s*\(\s*\(.*\bpacked|__packed)\b/) {
+			WARN("NEW_PACKED",
+			     "Adding new packed members is to be done with care\n" . $herecurr);
+		}
 
 # Check for __attribute__ aligned, prefer __aligned
 		if ($line =~ /\b__attribute__\s*\(\s*\(.*aligned/) {