From: Ben Laurie <ben@openssl.org>
Date: Thu, 5 Apr 2007 17:03:09 +0000 (+0000)
Subject: Errors should actually be errors.
X-Git-Tag: OpenSSL_0_9_8k^2~904
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=f3d2a9db09cd7df736229710cb4c75f8906eeb4e;p=oweals%2Fopenssl.git

Errors should actually be errors.
---

diff --git a/util/mkerr.pl b/util/mkerr.pl
index c8f305c4ea..66b8df35b5 100644
--- a/util/mkerr.pl
+++ b/util/mkerr.pl
@@ -13,6 +13,8 @@ my $staticloader = "";
 my $pack_errcode;
 my $load_errcode;
 
+my $errcount;
+
 while (@ARGV) {
 	my $arg = $ARGV[0];
 	if($arg eq "-conf") {
@@ -195,6 +197,7 @@ while (($hdr, $lib) = each %libinc)
 				$rcodes{$name} = $code;
 				if ($rassigned{$lib} =~ /:$code:/) {
 					print STDERR "!! ERROR: $lib reason code $code assigned twice\n";
+					++$errcount;
 				}
 				$rassigned{$lib} .= "$code:";
 				if(!(exists $rextra{$name}) &&
@@ -204,6 +207,7 @@ while (($hdr, $lib) = each %libinc)
 			} else {
 				if ($fassigned{$lib} =~ /:$code:/) {
 					print STDERR "!! ERROR: $lib function code $code assigned twice\n";
+					++$errcount;
 				}
 				$fassigned{$lib} .= "$code:";
 				if($code > $fmax{$lib}) {
@@ -234,6 +238,7 @@ while (($hdr, $lib) = each %libinc)
 		if ($rmax{$lib} >= 1000) {
 			print STDERR "!! ERROR: SSL error codes 1000+ are reserved for alerts.\n";
 			print STDERR "!!        Any new alerts must be added to $config.\n";
+			++$errcount;
 			print STDERR "\n";
 		}
 	}
@@ -723,3 +728,9 @@ if($debug && defined(@runref) ) {
 		print STDERR "$_\n";
 	}
 }
+
+if($errcount) {
+	print STDERR "There were errors, failing...\n\n";
+	exit $errcount;
+}
+