From: Matt Caswell <matt@openssl.org>
Date: Mon, 21 Nov 2016 17:11:51 +0000 (+0000)
Subject: Add a TLS1.3 TODO for the msg callback
X-Git-Tag: OpenSSL_1_1_1-pre1~2931
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=f31d5e10058115679ba553d53bc0ee9bd17ea646;p=oweals%2Fopenssl.git

Add a TLS1.3 TODO for the msg callback

At the moment the msg callback only received the record header with the
outer record type in it. We never pass the inner record type - we probably
need to at some point.

Reviewed-by: Rich Salz <rsalz@openssl.org>
---

diff --git a/ssl/record/ssl3_record.c b/ssl/record/ssl3_record.c
index bf6967624c..d8e2552dbf 100644
--- a/ssl/record/ssl3_record.c
+++ b/ssl/record/ssl3_record.c
@@ -209,6 +209,11 @@ int ssl3_get_record(SSL *s)
                 }
             } else {
                 /* SSLv3+ style record */
+                /*
+                 * TODO(TLS1.3): This callback only provides the "outer" record
+                 * type to the callback. Somehow we need to pass the "inner"
+                 * record type
+                 */
                 if (s->msg_callback)
                     s->msg_callback(0, 0, SSL3_RT_HEADER, p, 5, s,
                                     s->msg_callback_arg);