From: Jon Trulson <jon@radscan.com>
Date: Sat, 27 Dec 2014 22:54:55 +0000 (-0700)
Subject: dtsession/SmDB: error handling issues (CID 87778, 87926)
X-Git-Tag: 2.2.3~60^2~11
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=f14df58edb6768ed2336a70e15637adb56e4ac52;p=oweals%2Fcde.git

dtsession/SmDB: error handling issues (CID 87778, 87926)
---

diff --git a/cde/programs/dtsession/SmDB.c b/cde/programs/dtsession/SmDB.c
index 7fa5208f..b6c0e9aa 100644
--- a/cde/programs/dtsession/SmDB.c
+++ b/cde/programs/dtsession/SmDB.c
@@ -498,7 +498,8 @@ OpenOutputClientDB(char *fileName,
     /* Open fileName for writing. */
     if ((outputDB->xrmDBFile = fopen(fileName, "w")) == (FILE *)NULL)
     {
-	rename(outputDB->tmpDBFileName, fileName);
+        int rv;
+	rv = rename(outputDB->tmpDBFileName, fileName);
 	XtFree(outputDB->xrmDBFileName);
 	XtFree(outputDB->tmpDBFileName);
 	XtFree((char *)outputDB);
@@ -705,9 +706,10 @@ CloseClientDB(ClientDB clientDBPtr, Boolean writeDB)
     }
     else
     {
+      int rv;
 	/* Close file and remove it; restore original DB. */
 	fclose(clientDB->xrmDBFile);
-	rename(clientDB->tmpDBFileName, clientDB->xrmDBFileName);
+	rv = rename(clientDB->tmpDBFileName, clientDB->xrmDBFileName);
     }
 
     XtFree(clientDB->xrmDBFileName);