From: Pauli <paul.dale@oracle.com>
Date: Sun, 24 Feb 2019 11:27:02 +0000 (+1000)
Subject: CID 1442838:  API usage errors
X-Git-Tag: openssl-3.0.0-alpha1~2481
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=ef9f6066998718ae904fc10d46205d67aad9aebe;p=oweals%2Fopenssl.git

CID 1442838:  API usage errors

Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/8318)
---

diff --git a/test/property_test.c b/test/property_test.c
index 722de05d68..ee942526d8 100644
--- a/test/property_test.c
+++ b/test/property_test.c
@@ -304,10 +304,8 @@ static int test_property(void)
     for (i = 0; i < OSSL_NELEM(queries); i++) {
         OSSL_PROPERTY_LIST *pq = NULL;
 
-        if (!TEST_true(ossl_property_read_lock(store))
-            || !TEST_true(ossl_method_store_fetch(store, queries[i].nid,
-                                                  queries[i].prop, &result))
-            || !TEST_true(ossl_property_unlock(store))
+        if (!TEST_true(ossl_method_store_fetch(store, queries[i].nid,
+                                               queries[i].prop, &result))
             || !TEST_str_eq((char *)result, queries[i].expected)) {
             TEST_note("iteration %zd", i + 1);
             ossl_property_free(pq);