From: Jo-Philipp Wich <jo@mein.io>
Date: Wed, 4 Dec 2019 15:08:40 +0000 (+0100)
Subject: luci-base: ui.js: properly escape dynlist items for rendering
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=ee360669474ddc7d94dd2853b2411da929fb5593;p=oweals%2Fluci.git

luci-base: ui.js: properly escape dynlist items for rendering

Ref: https://forum.openwrt.org/t/luci-theme-openwrt-reports-error/49736
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
---

diff --git a/modules/luci-base/htdocs/luci-static/resources/ui.js b/modules/luci-base/htdocs/luci-static/resources/ui.js
index 1a9504b5d..faf05211d 100644
--- a/modules/luci-base/htdocs/luci-static/resources/ui.js
+++ b/modules/luci-base/htdocs/luci-static/resources/ui.js
@@ -1300,7 +1300,7 @@ var UIDynamicList = UIElement.extend({
 	addItem: function(dl, value, text, flash) {
 		var exists = false,
 		    new_item = E('div', { 'class': flash ? 'item flash' : 'item', 'tabindex': 0 }, [
-				E('span', {}, text || value),
+				E('span', {}, [ text || value ]),
 				E('input', {
 					'type': 'hidden',
 					'name': this.options.name,