From: Bernd Edlinger <bernd.edlinger@hotmail.de>
Date: Wed, 15 Feb 2017 10:36:17 +0000 (+0100)
Subject: Rework error handling of custom_ext_meth_add towards strong exception safety.
X-Git-Tag: OpenSSL_1_1_1-pre1~2391
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=ed874fac6399d5064d6eb8fe2022b918aeaf75af;p=oweals%2Fopenssl.git

Rework error handling of custom_ext_meth_add towards strong exception safety.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/2636)
---

diff --git a/ssl/t1_ext.c b/ssl/t1_ext.c
index 182164760f..b19e75231f 100644
--- a/ssl/t1_ext.c
+++ b/ssl/t1_ext.c
@@ -179,12 +179,8 @@ static int custom_ext_meth_add(custom_ext_methods *exts,
     tmp = OPENSSL_realloc(exts->meths,
                           (exts->meths_count + 1) * sizeof(custom_ext_method));
 
-    if (tmp == NULL) {
-        OPENSSL_free(exts->meths);
-        exts->meths = NULL;
-        exts->meths_count = 0;
+    if (tmp == NULL)
         return 0;
-    }
 
     exts->meths = tmp;
     meth = exts->meths + exts->meths_count;