From: Bin Meng Date: Mon, 8 Oct 2018 09:27:44 +0000 (-0700) Subject: nand: atmel: Initialize pmecc smu with correct size X-Git-Tag: v2018.11-rc3~16 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=ed5df0852f56a3512db283010ad7b6e93cba0612;p=oweals%2Fu-boot.git nand: atmel: Initialize pmecc smu with correct size Currently in pmecc_get_sigma(), the code tries to clear the memory pointed by smu with wrong size 'sizeof(int16_t) * ARRAY_SIZE(smu)'. Since smu is actually a pointer, not an array, so ARRAY_SIZE(smu) does not generate correct size to be cleared. In fact, GCC 8.1.0 reports a warning against it: error: division 'sizeof (int16_t * {aka short int *}) / sizeof (int16_t {aka short int})' does not compute the number of array elements [-Werror=sizeof-pointer-div] Fix it by using the correct size. Signed-off-by: Bin Meng Reviewed-by: Miquel Raynal --- diff --git a/drivers/mtd/nand/raw/atmel_nand.c b/drivers/mtd/nand/raw/atmel_nand.c index a5b76e1aa0..31ad2cfa88 100644 --- a/drivers/mtd/nand/raw/atmel_nand.c +++ b/drivers/mtd/nand/raw/atmel_nand.c @@ -249,7 +249,7 @@ static void pmecc_get_sigma(struct mtd_info *mtd) int diff; /* Init the Sigma(x) */ - memset(smu, 0, sizeof(int16_t) * ARRAY_SIZE(smu)); + memset(smu, 0, sizeof(int16_t) * num * (cap + 2)); dmu_0_count = 0;