From: Eric Andersen <andersen@codepoet.org>
Date: Mon, 12 Sep 2005 19:17:03 +0000 (-0000)
Subject: Kunihiko IMAI writes:
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=e76da05b7502ffed2e9f51aa33e1d0f697d278b9;p=oweals%2Fbusybox.git

Kunihiko IMAI writes:

Hi,

We're using busybox and thank the authors.

I found a short buffer allocation at busybox/sysklod/syslod.c.  It
mis-declares length of filenames, seems to forget for '\0' or two
column numbered suffix of backup files (ex. messages.10).

Here is a patch for the problem.

Thanks.
---

diff --git a/busybox/sysklogd/syslogd.c b/busybox/sysklogd/syslogd.c
index aecd35d58..8f9d75cc6 100644
--- a/busybox/sysklogd/syslogd.c
+++ b/busybox/sysklogd/syslogd.c
@@ -333,7 +333,7 @@ static void message(char *fmt, ...)
 				&& (lseek(fd,0,SEEK_END) > logFileSize) ) {
 				if(logFileRotate > 0) {
 					int i;
-					char oldFile[(strlen(logFilePath)+3)], newFile[(strlen(logFilePath)+3)];
+					char oldFile[(strlen(logFilePath)+4)], newFile[(strlen(logFilePath)+4)];
 					for(i=logFileRotate-1;i>0;i--) {
 						sprintf(oldFile, "%s.%d", logFilePath, i-1);
 						sprintf(newFile, "%s.%d", logFilePath, i);