From: Tomas Mraz Date: Thu, 21 May 2020 11:16:57 +0000 (+0200) Subject: Prevent use after free of global_engine_lock X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=e512efe0894481679a5d3c57d10bf4ea97046c2a;p=oweals%2Fopenssl.git Prevent use after free of global_engine_lock If buggy application calls engine functions after cleanup of engines already happened the global_engine_lock will be used although already freed. See for example: https://bugzilla.redhat.com/show_bug.cgi?id=1831086 Reviewed-by: Bernd Edlinger (Merged from https://github.com/openssl/openssl/pull/11896) (cherry picked from commit e12813d0d31f4f7be2ccc592d382ef3e94bdb842) --- diff --git a/crypto/engine/eng_lib.c b/crypto/engine/eng_lib.c index b851ff6957..dd87ebaca7 100644 --- a/crypto/engine/eng_lib.c +++ b/crypto/engine/eng_lib.c @@ -171,6 +171,7 @@ void engine_cleanup_int(void) cleanup_stack = NULL; } CRYPTO_THREAD_lock_free(global_engine_lock); + global_engine_lock = NULL; } /* Now the "ex_data" support */