From: Denis Vlasenko <vda.linux@googlemail.com>
Date: Sat, 14 Apr 2007 15:08:41 +0000 (-0000)
Subject: msh: style fixes
X-Git-Tag: 1_6_0~152
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=e4712758138aabfce1cfd8ade232fd17988f23f4;p=oweals%2Fbusybox.git

msh: style fixes
shell/README - a place to record things about busybox shells
---

diff --git a/shell/README b/shell/README
new file mode 100644
index 000000000..ea1174379
--- /dev/null
+++ b/shell/README
@@ -0,0 +1,6 @@
+Various bits of what is known about busybox shells, in no particular order.
+
+2007-04-14
+lash, hush: both do setsid() and as a result don't have ctty!
+Ctrl-C doesn't work for any child (try rm -i), etc...
+lash: bare ">file" doesn't create a file (hush works)
diff --git a/shell/msh.c b/shell/msh.c
index ae18061d6..91e302fac 100644
--- a/shell/msh.c
+++ b/shell/msh.c
@@ -2117,7 +2117,6 @@ static struct op *newtp(void)
 
 static struct op *namelist(struct op *t)
 {
-
 	DBGPRINTF7(("NAMELIST: enter, t=%p, type %s, iolist=%p\n", t,
 				T_CMD_NAMES[t->type], iolist));
 
@@ -2658,7 +2657,7 @@ static int execute(struct op *t, int *pin, int *pout, int act)
 
 	};
 
-  broken:
+ broken:
 	t->words = wp2;
 	isbreak = 0;
 	freehere(areanum);
@@ -2681,13 +2680,13 @@ static int execute(struct op *t, int *pin, int *pout, int act)
 
 typedef int (*builtin_func_ptr)(struct op *);
 
-static builtin_func_ptr inbuilt(const char *s) {
+static builtin_func_ptr inbuilt(const char *s)
+{
 	const struct builtincmd *bp;
 
 	for (bp = builtincmds; bp->name; bp++)
 		if (strcmp(bp->name, s) == 0)
 			return bp->builtinfunc;
-
 	return NULL;
 }
 
@@ -4379,8 +4378,7 @@ static struct wdblock *addword(char *wd, struct wdblock *wb)
 	return wb;
 }
 
-static
-char **getwords(struct wdblock *wb)
+static char **getwords(struct wdblock *wb)
 {
 	char **wd;
 	int nb;