From: Stephen Warren Date: Thu, 14 Apr 2016 04:29:52 +0000 (-0600) Subject: serial: bcm283x_mu: make pending values more explicit X-Git-Tag: v2016.05-rc2~14 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=e3a46e3ee22876606254560ec4c10903074475c2;p=oweals%2Fu-boot.git serial: bcm283x_mu: make pending values more explicit dm_serial_ops.pending should return the number of characters, not just a valid C Boolean integer value. The existing code does already does this, but only as an accident since BCM283X_MU_LSR_RX_READY happens to be BIT(0). Enhance the code to be more explicit about the values it returns. Suggested-by: Simon Glass Signed-off-by: Stephen Warren --- diff --git a/drivers/serial/serial_bcm283x_mu.c b/drivers/serial/serial_bcm283x_mu.c index fc36bc0e85..7357bbfb26 100644 --- a/drivers/serial/serial_bcm283x_mu.c +++ b/drivers/serial/serial_bcm283x_mu.c @@ -116,9 +116,9 @@ static int bcm283x_mu_serial_pending(struct udevice *dev, bool input) if (input) { WATCHDOG_RESET(); - return lsr & BCM283X_MU_LSR_RX_READY; + return (lsr & BCM283X_MU_LSR_RX_READY) ? 1 : 0; } else { - return !(lsr & BCM283X_MU_LSR_TX_IDLE); + return (lsr & BCM283X_MU_LSR_TX_IDLE) ? 0 : 1; } }