From: Felix Fietkau <nbd@openwrt.org>
Date: Wed, 28 May 2014 09:43:56 +0000 (+0200)
Subject: http: rework authentication handling - only retry internally for GET requests
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=e1ed2c2250c89be3bed71f8bad038d5610178364;p=oweals%2Fuclient.git

http: rework authentication handling - only retry internally for GET requests

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---

diff --git a/uclient-http.c b/uclient-http.c
index 9652fb8..1ab336f 100644
--- a/uclient-http.c
+++ b/uclient-http.c
@@ -497,9 +497,6 @@ uclient_http_send_headers(struct uclient_http *uh)
 	if (uh->state >= HTTP_STATE_HEADERS_SENT)
 		return;
 
-	if (uh->auth_type == AUTH_TYPE_UNKNOWN)
-		req_type = REQ_HEAD;
-
 	ustream_printf(uh->us,
 		"%s %s HTTP/1.1\r\n"
 		"Host: %s\r\n",
@@ -527,7 +524,8 @@ static void uclient_http_headers_complete(struct uclient_http *uh)
 	uh->uc.meta = uh->meta.head;
 	uclient_http_process_headers(uh);
 
-	if (auth_type == AUTH_TYPE_UNKNOWN) {
+	if (auth_type == AUTH_TYPE_UNKNOWN && uh->uc.status_code == 401 &&
+	    (uh->req_type == REQ_HEAD || uh->req_type == REQ_GET)) {
 		uclient_http_init_request(uh);
 		uclient_http_send_headers(uh);
 		uh->state = HTTP_STATE_REQUEST_DONE;