From: Matt Caswell <matt@openssl.org>
Date: Fri, 15 Apr 2016 13:45:12 +0000 (+0100)
Subject: Fix a missing return value check in v3_addr
X-Git-Tag: OpenSSL_1_1_0-pre6~1089
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=dfefe7ec1e21078be4ad456c3f465cc174071d7c;p=oweals%2Fopenssl.git

Fix a missing return value check in v3_addr

All other instances of extract_min_max are checked for an error return,
except this one.

Reviewed-by: Richard Levitte <levitte@openssl.org>
---

diff --git a/crypto/x509v3/v3_addr.c b/crypto/x509v3/v3_addr.c
index 49d0d4d392..f68f937ffa 100644
--- a/crypto/x509v3/v3_addr.c
+++ b/crypto/x509v3/v3_addr.c
@@ -897,7 +897,8 @@ static int IPAddressOrRanges_canonize(IPAddressOrRanges *aors,
         IPAddressOrRange *a = sk_IPAddressOrRange_value(aors, j);
         if (a != NULL && a->type == IPAddressOrRange_addressRange) {
             unsigned char a_min[ADDR_RAW_BUF_LEN], a_max[ADDR_RAW_BUF_LEN];
-            extract_min_max(a, a_min, a_max, length);
+            if (!extract_min_max(a, a_min, a_max, length))
+                return 0;
             if (memcmp(a_min, a_max, length) > 0)
                 return 0;
         }