From: Matt Caswell <matt@openssl.org>
Date: Thu, 15 Nov 2018 14:50:52 +0000 (+0000)
Subject: Fix shlibloadtest to properly execute the dso_ref test
X-Git-Tag: openssl-3.0.0-alpha1~2668
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=df5228e3b294fc546d0f8ea46e40ac111db58650;p=oweals%2Fopenssl.git

Fix shlibloadtest to properly execute the dso_ref test

Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/7647)
---

diff --git a/test/shlibloadtest.c b/test/shlibloadtest.c
index 4c5d80106e..dcb19752e8 100644
--- a/test/shlibloadtest.c
+++ b/test/shlibloadtest.c
@@ -121,6 +121,7 @@ static int test_lib(void)
 
     switch (test_type) {
     case JUST_CRYPTO:
+    case DSO_REFTEST:
         if (!TEST_true(shlib_load(path_crypto, &cryptolib)))
             goto end;
         break;
@@ -134,10 +135,6 @@ static int test_lib(void)
                 || !TEST_true(shlib_load(path_crypto, &cryptolib)))
             goto end;
         break;
-    case DSO_REFTEST:
-        if (!TEST_true(shlib_load(path_crypto, &cryptolib)))
-            goto end;
-        break;
     }
 
     if (test_type != JUST_CRYPTO && test_type != DSO_REFTEST) {
@@ -210,6 +207,7 @@ static int test_lib(void)
 
     switch (test_type) {
     case JUST_CRYPTO:
+    case DSO_REFTEST:
         if (!TEST_true(shlib_close(cryptolib)))
             goto end;
         break;
@@ -223,10 +221,6 @@ static int test_lib(void)
                 || !TEST_true(shlib_close(cryptolib)))
             goto end;
         break;
-    case DSO_REFTEST:
-        if (!TEST_true(shlib_close(cryptolib)))
-            goto end;
-        break;
     }
 
     result = 1;
@@ -247,7 +241,7 @@ int setup_tests(void)
     } else if (strcmp(p, "-just_crypto") == 0) {
         test_type = JUST_CRYPTO;
     } else if (strcmp(p, "-dso_ref") == 0) {
-        test_type = JUST_CRYPTO;
+        test_type = DSO_REFTEST;
     } else {
         TEST_error("Unrecognised argument");
         return 0;