From: Bin Meng Date: Thu, 1 Jun 2017 10:41:14 +0000 (-0700) Subject: x86: fsp: Remove the call to set up internal uart in fsp_init() X-Git-Tag: v2017.07-rc1~85^2 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=d7f7ba36b2edecb16393f8373cca833adb8ea6c3;p=oweals%2Fu-boot.git x86: fsp: Remove the call to set up internal uart in fsp_init() First of all, it's inappropriate to call setup_internal_uart() in a generic API fsp_init(), as CONFIG_INTERNAL_UART is an option that is only available on BayTrail platform. Secondly even for BayTrail, there is no need to call setup_internal_uart() at all, as Intel FSP will do this for us. Signed-off-by: Bin Meng Reviewed-by: Stefan Roese Reviewed-by: Simon Glass --- diff --git a/arch/x86/lib/fsp/fsp_support.c b/arch/x86/lib/fsp/fsp_support.c index a480361211..ab8340c871 100644 --- a/arch/x86/lib/fsp/fsp_support.c +++ b/arch/x86/lib/fsp/fsp_support.c @@ -110,10 +110,6 @@ void fsp_init(u32 stack_top, u32 boot_mode, void *nvs_buf) struct upd_region *fsp_upd; #endif -#ifdef CONFIG_INTERNAL_UART - setup_internal_uart(1); -#endif - fsp_hdr = find_fsp_header(); if (fsp_hdr == NULL) { /* No valid FSP info header was found */