From: Martin Vystrčil Date: Tue, 20 Aug 2019 20:18:30 +0000 (+0200) Subject: fat: FAT filesystem premature release of info struct. X-Git-Tag: v2019.10-rc3~1^2~14 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=d7af2a863017be1f5fd1b65a858ddc7e87d7b876;p=oweals%2Fu-boot.git fat: FAT filesystem premature release of info struct. File was found on specified location. Info about file was read, but then immediately destroyed using 'free' call. As a result file size was set to 0, hence fat process didn't read any data. Premature 'free' call removed. Resources are freed right before function return. File is read correctly. Signed-off-by: Martin Vystrcil --- diff --git a/fs/fat/fat.c b/fs/fat/fat.c index 06c8ed14bd..29cae8d391 100644 --- a/fs/fat/fat.c +++ b/fs/fat/fat.c @@ -1174,10 +1174,6 @@ int file_fat_read_at(const char *filename, loff_t pos, void *buffer, /* For saving default max clustersize memory allocated to malloc pool */ dir_entry *dentptr = itr->dent; - free(itr); - - itr = NULL; - ret = get_contents(&fsdata, dentptr, pos, buffer, maxsize, actread); out_free_both: