From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Thu, 8 Feb 2018 20:47:10 +0000 (+0100)
Subject: dm: video: correctly clean background in 16bit mode
X-Git-Tag: v2018.05-rc1~137^2~5
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=d7a75d3cd7cd7ce3665442e4e566b147c4c8602b;p=oweals%2Fu-boot.git

dm: video: correctly clean background in 16bit mode

In 16 bit mode we have to copy two bytes per pixels repeatedly and not
four. Otherwise we will see a striped pattern.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c
index dcaceed42c..9a980ea3a1 100644
--- a/drivers/video/video-uclass.c
+++ b/drivers/video/video-uclass.c
@@ -91,14 +91,26 @@ void video_clear(struct udevice *dev)
 {
 	struct video_priv *priv = dev_get_uclass_priv(dev);
 
-	if (priv->bpix == VIDEO_BPP32) {
+	switch (priv->bpix) {
+	case VIDEO_BPP16: {
+		u16 *ppix = priv->fb;
+		u16 *end = priv->fb + priv->fb_size;
+
+		while (ppix < end)
+			*ppix++ = priv->colour_bg;
+		break;
+	}
+	case VIDEO_BPP32: {
 		u32 *ppix = priv->fb;
 		u32 *end = priv->fb + priv->fb_size;
 
 		while (ppix < end)
 			*ppix++ = priv->colour_bg;
-	} else {
+		break;
+	}
+	default:
 		memset(priv->fb, priv->colour_bg, priv->fb_size);
+		break;
 	}
 }