From: Denis Osvald <denis.osvald@sartura.hr>
Date: Thu, 25 Aug 2016 11:54:52 +0000 (+0200)
Subject: ubusd: don't check ACL when object is NULL
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=d6bb4f1a1ddab325024966cd79abd34364dfdd15;p=oweals%2Fubus.git

ubusd: don't check ACL when object is NULL

If there are any ACLs present other than global wildcard "*", the AVL
tree comparator will compare ACL key to object name. However, object
name can be NULL in cases where ACL check is done on call to internal
ubus objects (e.g. ubus monitor).

With this change we skip checking ACLs on such NULL objects.

Signed-off-by: Denis Osvald <denis.osvald@sartura.hr>
---

diff --git a/ubusd_acl.c b/ubusd_acl.c
index 85ada5d..2700c86 100644
--- a/ubusd_acl.c
+++ b/ubusd_acl.c
@@ -101,7 +101,7 @@ ubusd_acl_check(struct ubus_client *cl, const char *obj,
 	struct blob_attr *cur;
 	int rem;
 
-	if (!cl->uid)
+	if (!cl->uid || !obj)
 		return 0;
 
 	acl = avl_find_ge_element(&ubusd_acls, obj, acl, avl);