From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Sat, 16 Apr 2011 17:31:08 +0000 (+0200)
Subject: wget: add a note about bug 3625
X-Git-Tag: 1_19_0~173
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=d506897b4ef94a85013696d543686162293a02f1;p=oweals%2Fbusybox.git

wget: add a note about bug 3625

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
---

diff --git a/networking/wget.c b/networking/wget.c
index 3a4be9878..df6d36358 100644
--- a/networking/wget.c
+++ b/networking/wget.c
@@ -661,6 +661,12 @@ static void download_one_url(const char *url)
 
 #if ENABLE_FEATURE_WGET_AUTHENTICATION
 		if (target.user) {
+//TODO: URL-decode "user:password" string before base64-encoding:
+//wget http://test:my%20pass@example.com should send
+// Authorization: Basic dGVzdDpteSBwYXNz
+//which decodes to "test:my pass", instead of what we send now:
+// Authorization: Basic dGVzdDpteSUyMHBhc3M=
+//Can reuse decodeString() from httpd.c
 			fprintf(sfp, "Proxy-Authorization: Basic %s\r\n"+6,
 				base64enc(target.user));
 		}