From: Matt Caswell <matt@openssl.org>
Date: Tue, 14 Jun 2016 10:27:10 +0000 (+0100)
Subject: Avoid a double-free in crl2pl7
X-Git-Tag: OpenSSL_1_1_0-pre6~458
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=d285b5418ee1ff361f06545e0489ece61bdd1a50;p=oweals%2Fopenssl.git

Avoid a double-free in crl2pl7

The variable |crtflst| could get double freed in an error path.

Reviewed-by: Richard Levitte <levitte@openssl.org>
---

diff --git a/apps/crl2p7.c b/apps/crl2p7.c
index 1631258793..9c5f79f9f3 100644
--- a/apps/crl2p7.c
+++ b/apps/crl2p7.c
@@ -84,10 +84,8 @@ int crl2pkcs7_main(int argc, char **argv)
             if ((certflst == NULL)
                 && (certflst = sk_OPENSSL_STRING_new_null()) == NULL)
                 goto end;
-            if (!sk_OPENSSL_STRING_push(certflst, opt_arg())) {
-                sk_OPENSSL_STRING_free(certflst);
+            if (!sk_OPENSSL_STRING_push(certflst, opt_arg()))
                 goto end;
-            }
             break;
         }
     }