From: Jo-Philipp Wich <jo@mein.io>
Date: Fri, 26 Jul 2019 10:36:04 +0000 (+0200)
Subject: luci-app-firewall: explicitely set 'DNAT' target on new forwards
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=d25f95c93dab254a7bbbb2a5e766f852f26b667b;p=oweals%2Fluci.git

luci-app-firewall: explicitely set 'DNAT' target on new forwards

Fixes: #2920
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
---

diff --git a/applications/luci-app-firewall/htdocs/luci-static/resources/view/firewall/forwards.js b/applications/luci-app-firewall/htdocs/luci-static/resources/view/firewall/forwards.js
index ffbfe3ccd..63af69f8a 100644
--- a/applications/luci-app-firewall/htdocs/luci-static/resources/view/firewall/forwards.js
+++ b/applications/luci-app-firewall/htdocs/luci-static/resources/view/firewall/forwards.js
@@ -107,6 +107,16 @@ return L.view.extend({
 			return uci.get('firewall', section_id, 'name') || _('Unnamed forward');
 		};
 
+		s.handleAdd = function(ev) {
+			var config_name = this.uciconfig || this.map.config,
+			    section_id = uci.add(config_name, this.sectiontype);
+
+			uci.set(config_name, section_id, 'target', 'DNAT');
+
+			this.addedSection = section_id;
+			this.renderMoreOptionsModal(section_id);
+		};
+
 		o = s.taboption('general', form.Value, 'name', _('Name'));
 		o.placeholder = _('Unnamed forward');
 		o.modalonly = true;