From: Jonas Gorski Date: Wed, 10 Jun 2015 09:21:31 +0000 (+0000) Subject: b53: widen stp state mask to 3 bits (instead of 2) X-Git-Tag: reboot~2815 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=d24d5412fff17cc0ddafecc47ca9564795e1df3a;p=oweals%2Fopenwrt.git b53: widen stp state mask to 3 bits (instead of 2) At least on my b53 chip, the mask is 3 bits wide, and because of this some STP states are not set properly and discarded when read. Maybe for some other chips it makes sense to have just 2 bits width, but I don't have other versions around to test/validate. If that's the case then maybe we could add another STP state mask. Signed-off-by: Alexandru Ardelean Signed-off-by: Jonas Gorski SVN-Revision: 45937 --- diff --git a/target/linux/generic/files/drivers/net/phy/b53/b53_regs.h b/target/linux/generic/files/drivers/net/phy/b53/b53_regs.h index eef5c81779..144e1c8703 100644 --- a/target/linux/generic/files/drivers/net/phy/b53/b53_regs.h +++ b/target/linux/generic/files/drivers/net/phy/b53/b53_regs.h @@ -65,7 +65,7 @@ #define PORT_CTRL_RX_MCST_EN BIT(3) /* Multicast RX (P8 only) */ #define PORT_CTRL_RX_UCST_EN BIT(4) /* Unicast RX (P8 only) */ #define PORT_CTRL_STP_STATE_S 5 -#define PORT_CTRL_STP_STATE_MASK (0x3 << PORT_CTRL_STP_STATE_S) +#define PORT_CTRL_STP_STATE_MASK (0x7 << PORT_CTRL_STP_STATE_S) /* SMP Control Register (8 bit) */ #define B53_SMP_CTRL 0x0a