From: Pauli Date: Sun, 8 Sep 2019 22:04:45 +0000 (+1000) Subject: Coverity 1453633: Error handling issues (CHECKED_RETURN) X-Git-Tag: openssl-3.0.0-alpha1~1404 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=d111712f6a7ae0ce37062d75fa3fa72e277e7455;p=oweals%2Fopenssl.git Coverity 1453633: Error handling issues (CHECKED_RETURN) Reviewed-by: Bernd Edlinger (Merged from https://github.com/openssl/openssl/pull/9805) --- diff --git a/providers/common/kdfs/pbkdf2.c b/providers/common/kdfs/pbkdf2.c index ce395576dd..c8480125b2 100644 --- a/providers/common/kdfs/pbkdf2.c +++ b/providers/common/kdfs/pbkdf2.c @@ -107,7 +107,9 @@ static void kdf_pbkdf2_init(KDF_PBKDF2 *ctx) params[0] = OSSL_PARAM_construct_utf8_string(OSSL_KDF_PARAM_DIGEST, SN_sha1, 0); - ossl_prov_digest_load_from_params(&ctx->digest, params, provctx); + if (!ossl_prov_digest_load_from_params(&ctx->digest, params, provctx)) + /* This is an error, but there is no way to indicate such directly */ + ossl_prov_digest_reset(&ctx->digest); ctx->iter = PKCS5_DEFAULT_ITER; ctx->lower_bound_checks = KDF_PBKDF2_DEFAULT_CHECKS; }