From: David Woodhouse Date: Fri, 8 Jul 2016 19:46:07 +0000 (+0100) Subject: Fix SSL_export_keying_material() for DTLS1_BAD_VER X-Git-Tag: OpenSSL_1_1_0~276 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=c8a18468caef4d62778381be0acdadc8a88d6e51;p=oweals%2Fopenssl.git Fix SSL_export_keying_material() for DTLS1_BAD_VER Commit d8e8590e ("Fix missing return value checks in SCTP") made the DTLS handshake fail, even for non-SCTP connections, if SSL_export_keying_material() fails. Which it does, for DTLS1_BAD_VER. Apply the trivial fix to make it succeed, since there's no real reason why it shouldn't even though we never need it. Reviewed-by: Rich Salz Reviewed-by: Matt Caswell --- diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c index df71f7b0dc..8c3c88e227 100644 --- a/ssl/ssl_lib.c +++ b/ssl/ssl_lib.c @@ -2300,7 +2300,7 @@ int SSL_export_keying_material(SSL *s, unsigned char *out, size_t olen, const unsigned char *p, size_t plen, int use_context) { - if (s->version < TLS1_VERSION) + if (s->version < TLS1_VERSION && s->version != DTLS1_BAD_VER) return -1; return s->method->ssl3_enc->export_keying_material(s, out, olen, label,