From: David Benjamin <davidben@google.com>
Date: Mon, 2 Jun 2014 17:55:20 +0000 (+0100)
Subject: Check there is enough room for extension.
X-Git-Tag: master-post-reformat~742
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=c7f267397e9f1f8b43ddc84c4268bccc27d52b04;p=oweals%2Fopenssl.git

Check there is enough room for extension.
---

diff --git a/ssl/t1_lib.c b/ssl/t1_lib.c
index c4e27b972b..cf007f9cce 100644
--- a/ssl/t1_lib.c
+++ b/ssl/t1_lib.c
@@ -1416,6 +1416,8 @@ unsigned char *ssl_add_clienthello_tlsext(SSL *s, unsigned char *p, unsigned cha
 
 #ifndef OPENSSL_NO_HEARTBEATS
 	/* Add Heartbeat extension */
+	if ((limit - ret - 4 - 1) < 0)
+		return NULL;
 	s2n(TLSEXT_TYPE_heartbeat,ret);
 	s2n(1,ret);
 	/* Set mode:
@@ -1698,6 +1700,8 @@ unsigned char *ssl_add_serverhello_tlsext(SSL *s, unsigned char *p, unsigned cha
 	/* Add Heartbeat extension if we've received one */
 	if (s->tlsext_heartbeat & SSL_TLSEXT_HB_ENABLED)
 		{
+		if ((limit - ret - 4 - 1) < 0)
+			return NULL;
 		s2n(TLSEXT_TYPE_heartbeat,ret);
 		s2n(1,ret);
 		/* Set mode: