From: Peter Howkins <flibble@users.sf.net>
Date: Fri, 13 Jul 2018 17:09:23 +0000 (+0100)
Subject: dtcm: Coverity 89499
X-Git-Tag: 2.3.0a~102
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=c7e9625629e0df627cb33b91e776e1b7d3d081f0;p=oweals%2Fcde.git

dtcm: Coverity 89499
---

diff --git a/cde/programs/dtcm/server/rtable2.c b/cde/programs/dtcm/server/rtable2.c
index c4438f13..00d04af3 100644
--- a/cde/programs/dtcm/server/rtable2.c
+++ b/cde/programs/dtcm/server/rtable2.c
@@ -299,14 +299,16 @@ _DtCm_rtable_check_2_svc(Table_Args_2 *args, struct svc_req *svcrq)
         Table_Args_4 *newargs;     
         Table_Status_4 *newres;    
        
-        newargs = _DtCm_tableargs2_to_tableargs4(args);    
-        newres = _DtCm_rtable_check_4_svc(newargs, svcrq);    
+        newargs = _DtCm_tableargs2_to_tableargs4(args);
+        if(newargs) {
+                newres = _DtCm_rtable_check_4_svc(newargs, svcrq);
               
-        res = _DtCm_tablestat4_to_tablestat2(*newres);   
+                res = _DtCm_tablestat4_to_tablestat2(*newres);
      
-        if (newargs!=NULL) xdr_free((xdrproc_t)_DtCm_xdr_Table_Args_4, (char*)newargs);     
-         
-        return(&res); 
+                xdr_free((xdrproc_t)_DtCm_xdr_Table_Args_4, (char*)newargs);
+         }
+
+        return(&res);
 }
 
 /*	PROC #13	*/