From: Matt Sealey Date: Fri, 17 Aug 2012 08:15:11 +0000 (+0000) Subject: spi: fix mxs_spi_slave structure allocation to clear memory X-Git-Tag: v2012.10-rc1~165 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=c6b52c4927df227c94650122363b8b342ddb62f0;p=oweals%2Fu-boot.git spi: fix mxs_spi_slave structure allocation to clear memory Use calloc() instead of malloc() to allocate the mxs_spi_slave structure. Clearing the memory is necessary since most of the time this gets done super early in boot, but on warm reboots, and when SPI probing is done long after the init stages it could actually pick up previously used memory, and things like the chipselect polarity and other data end up being filled with trash data if not explicitly set by the board files. This solves a semi-random, almost unreproducable error whereby SPI devices act very, very strangly on boot. Signed-off-by: Matt Sealey Acked-by: Stefano Babic --- diff --git a/drivers/spi/mxs_spi.c b/drivers/spi/mxs_spi.c index a037c130ef..5fa7f2b73c 100644 --- a/drivers/spi/mxs_spi.c +++ b/drivers/spi/mxs_spi.c @@ -91,7 +91,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs, return NULL; } - mxs_slave = malloc(sizeof(struct mxs_spi_slave)); + mxs_slave = calloc(sizeof(struct mxs_spi_slave), 1); if (!mxs_slave) return NULL;